You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pa...@apache.org on 2012/05/07 11:15:34 UTC

git commit: WICKET-4536: change isVisible to onConfigure to prevent premature attachment of feedbackmessagemodel

Updated Branches:
  refs/heads/wicket-1.5.x 368d5ff46 -> 9f2d9b162


WICKET-4536: change isVisible to onConfigure to prevent premature attachment of feedbackmessagemodel


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/9f2d9b16
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/9f2d9b16
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/9f2d9b16

Branch: refs/heads/wicket-1.5.x
Commit: 9f2d9b162201d44d784c292850699e9eeb9147f0
Parents: 368d5ff
Author: Emond Papegaaij <em...@topicus.nl>
Authored: Mon May 7 11:15:09 2012 +0200
Committer: Emond Papegaaij <em...@topicus.nl>
Committed: Mon May 7 11:15:09 2012 +0200

----------------------------------------------------------------------
 .../wicket/markup/html/panel/FeedbackPanel.java    |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/9f2d9b16/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
index ce60fc1..1a4f9aa 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
@@ -149,9 +149,10 @@ public class FeedbackPanel extends Panel implements IFeedback
 			private static final long serialVersionUID = 1L;
 
 			@Override
-			public boolean isVisible()
+			protected void onConfigure()
 			{
-				return anyMessage();
+				super.onConfigure();
+				setVisible(anyMessage());
 			}
 		};
 		add(messagesContainer);