You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/23 21:30:53 UTC
[GitHub] [incubator-superset] robdiciuccio opened a new pull request #9007:
Serialize nested columns as JSON strings
robdiciuccio opened a new pull request #9007: Serialize nested columns as JSON strings
URL: https://github.com/apache/incubator-superset/pull/9007
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
SQL Lab queries against databases with nested columns/results containing structs or maps are failing with the following error:
```
pyarrow.lib.ArrowNotImplementedError: Not implemented type for list in DataFrameBlock: struct<...>
```
Serializing results to JSON is not the ideal solution, mainly for performance reasons, but there are pending fixes yet to be released in Arrow 1.0 that may improve the situation:
https://github.com/apache/arrow/pull/6199
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Ensure queries against databases containing nested columns (particularly arrays containing maps) are successful. Per https://github.com/apache/incubator-superset/issues/8978, the following query should succeed and produce the proper results:
```
SELECT id, json_agg(json_build_object('table_name',table_name,'database_id',database_id)) FROM (SELECT * FROM tables) AS tables GROUP BY id
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: #8978
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@lxhoang97 @graceguo-supercat @john-bodley @michellethomas @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request
#9007: Serialize nested columns as JSON strings
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9007: Serialize nested columns as JSON strings
URL: https://github.com/apache/incubator-superset/pull/9007#discussion_r370758282
##########
File path: superset/result_set.py
##########
@@ -86,7 +88,18 @@ def __init__(
# related: https://issues.apache.org/jira/browse/ARROW-5248
if pa_data:
for i, column in enumerate(column_names):
- if pa.types.is_temporal(pa_data[i].type):
+ # TODO: revisit nested column serialization once Arrow 1.0 is released with:
+ # https://github.com/apache/arrow/pull/6199
+ # Related issue: #8978
Review comment:
use url instead of issue #?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #9007:
Serialize nested columns as JSON strings
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9007: Serialize nested columns as JSON strings
URL: https://github.com/apache/incubator-superset/pull/9007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9007: Serialize
nested columns as JSON strings
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9007: Serialize nested columns as JSON strings
URL: https://github.com/apache/incubator-superset/pull/9007#issuecomment-577889658
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9007?src=pr&el=h1) Report
> Merging [#9007](https://codecov.io/gh/apache/incubator-superset/pull/9007?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/04be1d4b422648f5a7744bd753f8481d2f2f135f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9007?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9007 +/- ##
=======================================
Coverage 59.16% 59.16%
=======================================
Files 367 367
Lines 11680 11680
Branches 2863 2863
=======================================
Hits 6910 6910
Misses 4591 4591
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9007?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9007?src=pr&el=footer). Last update [04be1d4...bad166a](https://codecov.io/gh/apache/incubator-superset/pull/9007?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org