local-deploy on project-internal plugin

[Sjur Moshagen <sj...@mac.com>]

Hello all,

I've started to make a new plugin for our documetation needs. I wanted  
to keep it in the project documentation tree (ie outside of the  
forrest sources), at least for the moment, so I made a 'plugins'  
folder in the project root dir, and started from there. So far so well.

The problem came when I wanted to deploy the plugin. Here's the error  
message I received:

local-deploy:
      [echo] Locally deploying MultilingualOOoDraw

BUILD FAILED
/usr/local/forrest/plugins/build.xml:117: /Users/sjur/gtsvn/xtdoc/sd/ 
plugins/MultilingualOOoDraw/MultilingualOOoDraw not found.

The action on line 117 in that build file reads:

     <copy toDir="${forrest.plugins.localDeploy.dir}/${plugin-name}">
       <fileset dir="${forrest.plugins.dir}/${plugin-name}">
         <exclude name="lib/**"/>
         <exclude name="build/**"/>
       </fileset>
     </copy>

What I do not understand is how I got the plugin name twice in the  
path. I have done this local-deploy many times from the regular plugin  
dirs, and have had no problems. But something seems to be going wrong  
when deploying from a project dir. Does anyone have any clue as to  
what could go on?

Best regards,
Sjur

PS. The plugin will aggregate several language versions of the same  
document, and turn it into an OpenOffice Draw document, to create a  
multilingual brochure with pictures etc. The purpose is rather project  
specific, but if it can be generalised (and there is interest), I'm  
happy to move the code into Forrest at some more finished point in  
time. DS.

Re: local-deploy on project-internal plugin

[Sjur Moshagen <sj...@mac.com>]

Den 24. mar. 2009 kl. 01.14 skrev Ross Gardler:

> The code to allow a customisable local directory is much newer than
> that. So you probably want to look there.

Do you have any idea where that code is located? The build.xml files  
seemed the relevant place, and I could not find anything new and  
relevant there.

Sjur

Re: local-deploy on project-internal plugin

[Ross Gardler <rg...@apache.org>]

2009/3/23 Sjur Moshagen <sj...@mac.com>:
> Replying to myself:
>
> Den 23. mar. 2009 kl. 14.59 skrev Sjur Moshagen:
>
>> The action on line 117 in that build file reads:
>>
>>   <copy toDir="${forrest.plugins.localDeploy.dir}/${plugin-name}">
>>     <fileset dir="${forrest.plugins.dir}/${plugin-name}">
>>       <exclude name="lib/**"/>
>>       <exclude name="build/**"/>
>>     </fileset>
>>   </copy>
>
> If I change this to the following:
>
>    <copy toDir="${forrest.plugins.localDeploy.dir}/${plugin-name}">
>      <fileset dir="${forrest.plugins.dir}">
>        <exclude name="lib/**"/>
>        <exclude name="build/**"/>
>      </fileset>
>    </copy>
>
> it works ok (cf the second line, where I removed the ${plugin-name}
> variable). But this would probably break the regular plugin deployment. This
> file has not been touched since end of April 2007, and bugs here would
> certainly have been found much earlier.

The code to allow a customisable local directory is much newer than
that. So you probably want to look there.

Ross

-- 
Ross Gardler

OSS Watch - supporting open source in education and research
http://www.oss-watch.ac.uk

Re: local-deploy on project-internal plugin

[Brian M Dube <bd...@apache.org>]

On Mon, Mar 23, 2009 at 10:23:13PM +0200, Sjur Moshagen wrote:
> Replying to myself:
>
> Den 23. mar. 2009 kl. 14.59 skrev Sjur Moshagen:
>
>> The action on line 117 in that build file reads:
>>
>>    <copy toDir="${forrest.plugins.localDeploy.dir}/${plugin-name}">
>>      <fileset dir="${forrest.plugins.dir}/${plugin-name}">
>>        <exclude name="lib/**"/>
>>        <exclude name="build/**"/>
>>      </fileset>
>>    </copy>
>
> If I change this to the following:
>
>     <copy toDir="${forrest.plugins.localDeploy.dir}/${plugin-name}">
>       <fileset dir="${forrest.plugins.dir}">
>         <exclude name="lib/**"/>
>         <exclude name="build/**"/>
>       </fileset>
>     </copy>
>
> it works ok (cf the second line, where I removed the ${plugin-name}  
> variable). But this would probably break the regular plugin deployment. 
> This file has not been touched since end of April 2007, and bugs here 
> would certainly have been found much earlier.
>
> Thus it seems to me that there is inconsisten behaviour between local- 
> deploy of regular plugins (and whiteboard ones) and project plugins.
>
> Can anynoe confirm this? Or am I on the wrong track?

The times I have tried to develop plugins out of tree, I've also run
into problems. I don't recall whether it was this same problem or
something else, but this sounds familiar. If I end up with extra
cycles, I'll help look into it.

Brian

Re: local-deploy on project-internal plugin

[Sjur Moshagen <sj...@mac.com>]

Replying to myself:

Den 23. mar. 2009 kl. 14.59 skrev Sjur Moshagen:

> The action on line 117 in that build file reads:
>
>    <copy toDir="${forrest.plugins.localDeploy.dir}/${plugin-name}">
>      <fileset dir="${forrest.plugins.dir}/${plugin-name}">
>        <exclude name="lib/**"/>
>        <exclude name="build/**"/>
>      </fileset>
>    </copy>

If I change this to the following:

     <copy toDir="${forrest.plugins.localDeploy.dir}/${plugin-name}">
       <fileset dir="${forrest.plugins.dir}">
         <exclude name="lib/**"/>
         <exclude name="build/**"/>
       </fileset>
     </copy>

it works ok (cf the second line, where I removed the ${plugin-name}  
variable). But this would probably break the regular plugin  
deployment. This file has not been touched since end of April 2007,  
and bugs here would certainly have been found much earlier.

Thus it seems to me that there is inconsisten behaviour between local- 
deploy of regular plugins (and whiteboard ones) and project plugins.

Can anynoe confirm this? Or am I on the wrong track?

Sjur