You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Joern Huxhorn (JIRA)" <ji...@apache.org> on 2016/11/16 16:13:58 UTC

[jira] [Updated] (LOG4J2-1710) Build is currently broken.

     [ https://issues.apache.org/jira/browse/LOG4J2-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joern Huxhorn updated LOG4J2-1710:
----------------------------------
    Attachment: 0001-Fixing-LOG4J2-1710.patch

The attached patch contains my workaround/fix for the described problem.

It also comments out {{Assert.assertEquals(10000, socket.getReceiveBufferSize());}} in two tests since those fail in my environment.

{code}
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
Java version: 1.8.0_112, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.1", arch: "x86_64", family: "mac"
{code}

The failing tests are the following:
{code}
Results :

Failed tests:
  SecureSocketAppenderSocketOptionsTest.testSocketOptions:113 expected:<10000> but was:<271312>
  SocketAppenderSocketOptionsTest.testSocketOptions:93 expected:<10000> but was:<271312>

Tests run: 1480, Failures: 2, Errors: 0, Skipped: 33
{code}

I think it's OK to remove those checks since the javadoc of {{Socket.setReceiveBufferSize(int size)}} says the value is only a *hint*
bq. The SocketOptions#SO_RCVBUF SO_RCVBUF option is used by the platform's networking code as a *hint* for the size to set the underlying network I/O buffers.
whereas {{Socket.getReceiveBufferSize()}} returns the actually used size.

> Build is currently broken.
> --------------------------
>
>                 Key: LOG4J2-1710
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1710
>             Project: Log4j 2
>          Issue Type: Bug
>            Reporter: Joern Huxhorn
>         Attachments: 0001-Fixing-LOG4J2-1710.patch
>
>
> {{mvn clean install}} does not work with revision {{2260dc7408246684e6aabecbe654bbae606526e9}}.
> This is caused by a problem described here:
> - http://stackoverflow.com/questions/23190107/cannot-use-jacoco-jvm-args-and-surefire-jvm-args-together-in-maven
> - http://stackoverflow.com/questions/12269558/maven-jacoco-plugin-error
> To fix it, add {{<argLine></argLine>}} to {{<properties>}} of {{pom.xml}} in the root directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org