You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/29 01:15:45 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #19037: [PIP] switch pip doc to markdown
szha opened a new pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037
## Description ##
switch pip doc from rst to markdown
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] switch pip doc from rst to markdown and avoid pandoc text conversion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19037: [PIP] switch pip doc to markdown
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #19037: [PIP] switch pip doc to markdown
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037#discussion_r479694309
##########
File path: tools/pip/setup.py
##########
@@ -164,7 +159,7 @@ def skip_markdown_comments(md):
package_data['mxnet'].append('mxnet/libquadmath.so.0')
if os.path.exists(os.path.join(libdir, 'libopenblas.so.0')):
shutil.copy(os.path.join(libdir, 'libopenblas.so.0'), mxdir)
- package_data['mxnet'].append('mxnet/libquadmath.so.0')
+ package_data['mxnet'].append('mxnet/libopenblas.so.0')
Review comment:
Makes sense, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #19037: [PIP] switch pip doc to markdown
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037#discussion_r479688055
##########
File path: tools/pip/setup.py
##########
@@ -164,7 +159,7 @@ def skip_markdown_comments(md):
package_data['mxnet'].append('mxnet/libquadmath.so.0')
if os.path.exists(os.path.join(libdir, 'libopenblas.so.0')):
shutil.copy(os.path.join(libdir, 'libopenblas.so.0'), mxdir)
- package_data['mxnet'].append('mxnet/libquadmath.so.0')
+ package_data['mxnet'].append('mxnet/libopenblas.so.0')
Review comment:
this part looked wrong as it adds openblas in but records quadmath instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19037: [PIP] switch pip doc to markdown
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037#issuecomment-683211229
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, clang, miscellaneous, sanity, edge, centos-gpu, unix-cpu, unix-gpu, centos-cpu, website, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #19037: [PIP] switch pip doc to markdown
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037#discussion_r479688055
##########
File path: tools/pip/setup.py
##########
@@ -164,7 +159,7 @@ def skip_markdown_comments(md):
package_data['mxnet'].append('mxnet/libquadmath.so.0')
if os.path.exists(os.path.join(libdir, 'libopenblas.so.0')):
shutil.copy(os.path.join(libdir, 'libopenblas.so.0'), mxdir)
- package_data['mxnet'].append('mxnet/libquadmath.so.0')
+ package_data['mxnet'].append('mxnet/libopenblas.so.0')
Review comment:
this part looked wrong as it adds openblas in but records quadmath instead. it's likely not triggered as we didn't switch to dynamic linking with openblas for distribution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #19037: [PIP] switch pip doc to markdown
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #19037:
URL: https://github.com/apache/incubator-mxnet/pull/19037#discussion_r479680594
##########
File path: tools/pip/setup.py
##########
@@ -164,7 +159,7 @@ def skip_markdown_comments(md):
package_data['mxnet'].append('mxnet/libquadmath.so.0')
if os.path.exists(os.path.join(libdir, 'libopenblas.so.0')):
shutil.copy(os.path.join(libdir, 'libopenblas.so.0'), mxdir)
- package_data['mxnet'].append('mxnet/libquadmath.so.0')
+ package_data['mxnet'].append('mxnet/libopenblas.so.0')
Review comment:
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org