You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/10/03 12:37:34 UTC

[GitHub] [incubator-iceberg] gcdata44 commented on a change in pull request #407: [python] Parquet read path

gcdata44 commented on a change in pull request #407: [python] Parquet read path
URL: https://github.com/apache/incubator-iceberg/pull/407#discussion_r331014660
 
 

 ##########
 File path: python/iceberg/api/file_format.py
 ##########
 @@ -20,16 +20,18 @@
 
 @unique
 class FileFormat(Enum):
-
-    ORC = "orc"
-    PARQUET = "parquet"
-    AVRO = "avro"
+    ORC = "orc", True
 
 Review comment:
   Ok, I fixed the lint and test issues.  Makes sense on the enum to make those attributes explicit about what they are.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org