You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/11/03 06:38:03 UTC
Review Request 39889: Windows: Added support for `files/files.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Added support for `files/files.hpp`.
Diffs
-----
src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
Diff: https://reviews.apache.org/r/39889/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39889: Windows: Added support for
`files/files.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 10:11 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-4193
https://issues.apache.org/jira/browse/MESOS-4193
Repository: mesos
Description
-------
Windows: Added support for `files/files.hpp`.
Diffs
-----
src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
Diff: https://reviews.apache.org/r/39889/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39889: Windows: Added support for
`files/files.hpp`.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/#review110540
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Nov. 16, 2015, 9:15 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39889/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:15 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `files/files.hpp`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
>
> Diff: https://reviews.apache.org/r/39889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39889: Windows: Added support for
`files/files.hpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/#review111070
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Nov. 16, 2015, 9:15 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39889/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:15 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `files/files.hpp`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
>
> Diff: https://reviews.apache.org/r/39889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39889: Windows: Added support for
`files/files.hpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/#review106930
-----------------------------------------------------------
Ship it!
Double-checked non-Windows build.
src/files/files.hpp (lines 23 - 24)
<https://reviews.apache.org/r/39889/#comment165737>
I _think_ these headers should be moved down into the lower `#ifdef __WINDOWS__`.
- Joseph Wu
On Nov. 16, 2015, 1:15 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39889/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 1:15 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `files/files.hpp`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
>
> Diff: https://reviews.apache.org/r/39889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39889: Windows: Added support for
`files/files.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:15 a.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Added support for `files/files.hpp`.
Diffs (updated)
-----
src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
Diff: https://reviews.apache.org/r/39889/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39889: Windows: Added support for
`files/files.hpp`.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/#review104877
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560, 39583, 39584, 39620, 39621, 39622, 39623, 39019, 39802, 39803, 39804, 39805, 39834, 39850, 39851, 39852, 39888, 39889]
All tests passed.
- Mesos ReviewBot
On Nov. 3, 2015, 5:38 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39889/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 5:38 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `files/files.hpp`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
>
> Diff: https://reviews.apache.org/r/39889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>