You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Sina K. Heshmati (JIRA)" <ji...@apache.org> on 2007/12/18 15:02:43 UTC
[jira] Created: (FOR-1059) Reusable panels
Reusable panels
---------------
Key: FOR-1059
URL: https://issues.apache.org/jira/browse/FOR-1059
Project: Forrest
Issue Type: Improvement
Components: Plugin: themes.core
Affects Versions: 0.9-dev
Reporter: Sina K. Heshmati
Priority: Minor
Fix For: 0.9-dev
It's useful to have reusable panels for each theme [1]. I'm sending the html-pelt theme that's been chunked into different templates.
[1] http://marc.info/?l=forrest-dev&m=119738096213489&w=2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-1059) Reusable panels
Posted by "Sina K. Heshmati (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sina K. Heshmati updated FOR-1059:
----------------------------------
Attachment: FOR-1059-themes-20071218-01.tar.gz
FOR-1059-themes-20071218-01.patch
* The patch file contains the diff relative to $FORREST_HOME.
* The archive contains the new files added to the Core themes plugin.
> Reusable panels
> ---------------
>
> Key: FOR-1059
> URL: https://issues.apache.org/jira/browse/FOR-1059
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: themes.core
> Affects Versions: 0.9-dev
> Reporter: Sina K. Heshmati
> Priority: Minor
> Fix For: 0.9-dev
>
> Attachments: FOR-1059-themes-20071218-01.patch, FOR-1059-themes-20071218-01.tar.gz
>
>
> It's useful to have reusable panels for each theme [1]. I'm sending the html-pelt theme that's been chunked into different templates.
> [1] http://marc.info/?l=forrest-dev&m=119738096213489&w=2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-1059) Reusable Panels for Core Themes
Posted by "Sina K. Heshmati (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sina K. Heshmati updated FOR-1059:
----------------------------------
Summary: Reusable Panels for Core Themes (was: Reusable panels)
> Reusable Panels for Core Themes
> -------------------------------
>
> Key: FOR-1059
> URL: https://issues.apache.org/jira/browse/FOR-1059
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: themes.core
> Affects Versions: 0.9-dev
> Reporter: Sina K. Heshmati
> Priority: Minor
> Fix For: 0.9-dev
>
> Attachments: FOR-1059-themes-20071218-01.patch, FOR-1059-themes-20071218-01.tar.gz
>
>
> It's useful to have reusable panels for each theme [1]. I'm sending the html-pelt theme that's been chunked into different templates.
> [1] http://marc.info/?l=forrest-dev&m=119738096213489&w=2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FOR-1059) Reusable Panels for Core Themes
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Scherler closed FOR-1059.
----------------------------------
Resolution: Fixed
Committed revision 606863.
Adding example for usage in revision 606864.
> Reusable Panels for Core Themes
> -------------------------------
>
> Key: FOR-1059
> URL: https://issues.apache.org/jira/browse/FOR-1059
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: themes.core
> Affects Versions: 0.9-dev
> Reporter: Sina K. Heshmati
> Priority: Minor
> Fix For: 0.9-dev
>
> Attachments: FOR-1059-themes-20071218-01.patch, FOR-1059-themes-20071218-01.tar.gz
>
>
> It's useful to have reusable panels for each theme [1]. I'm sending the html-pelt theme that's been chunked into different templates.
> [1] http://marc.info/?l=forrest-dev&m=119738096213489&w=2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1059) Reusable Panels for Core Themes
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554395 ]
Thorsten Scherler commented on FOR-1059:
----------------------------------------
Hmm, I do not understand: "Please do NOT add these patches as it will affect other Forrest instances using the Dispatcher. " Sure it will effect other - more all other - instance of the dispatcher.
I reviewed the patch and applied it slightly changed. Thanks for your contribution Sina.
To 1)
we use the fallback mechanism meaning if a plugin does not use its own structurer we use the one from core.
The special case here is that pelt-html.panel.xml is already a panel and applying your patch as it is will affect all themes that are importing the panel.
I slightly changed the patch so that the structurer directly is using the new chunks.
To 2) No, since the pelt theme will provide always a basic css structure. Now one has to override the different chunks.
> Reusable Panels for Core Themes
> -------------------------------
>
> Key: FOR-1059
> URL: https://issues.apache.org/jira/browse/FOR-1059
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: themes.core
> Affects Versions: 0.9-dev
> Reporter: Sina K. Heshmati
> Priority: Minor
> Fix For: 0.9-dev
>
> Attachments: FOR-1059-themes-20071218-01.patch, FOR-1059-themes-20071218-01.tar.gz
>
>
> It's useful to have reusable panels for each theme [1]. I'm sending the html-pelt theme that's been chunked into different templates.
> [1] http://marc.info/?l=forrest-dev&m=119738096213489&w=2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1059) Reusable Panels for Core Themes
Posted by "Sina K. Heshmati (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552795 ]
Sina K. Heshmati commented on FOR-1059:
---------------------------------------
Please do NOT add these patches as it will affect other Forrest instances using the Dispatcher.
The following is a sample 'pelt-html.panel.xml:'
<forrest:template ...
<jx:import uri="cocoon://prepare.panels.pelt-html.head"/>
<forrest:hook name="container">
<jx:import uri="cocoon://prepare.panels.pelt-html.header"/>
<forrest:hook name="page">
<jx:import uri="cocoon://prepare.panels.pelt-html.leftbar"/>
<jx:import uri="cocoon://prepare.panels.pelt-html.content"/>
</forrest:hook>
<jx:import uri="cocoon://prepare.panels.pelt-html.footer"/>
</forrest:hook>
</forrest:template>
Some Questions
-----------------------
(1) Let's say that a given project does not want to change the views at all, that is no project-specific panels. How can make sure that the one included in the core.themes plugin is used? This way, every instance using the Dispatcher won't be affected.
(2) Should I remove the forrest:hooks from the pelt-html.panel.xml? So as to make it easier ti add project-specific contracts to the existing views.
> Reusable Panels for Core Themes
> -------------------------------
>
> Key: FOR-1059
> URL: https://issues.apache.org/jira/browse/FOR-1059
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: themes.core
> Affects Versions: 0.9-dev
> Reporter: Sina K. Heshmati
> Priority: Minor
> Fix For: 0.9-dev
>
> Attachments: FOR-1059-themes-20071218-01.patch, FOR-1059-themes-20071218-01.tar.gz
>
>
> It's useful to have reusable panels for each theme [1]. I'm sending the html-pelt theme that's been chunked into different templates.
> [1] http://marc.info/?l=forrest-dev&m=119738096213489&w=2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.