[jira] [Comment Edited] (OFBIZ-4769) Editing of product suppliers is not working for the Germany locale

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066336#comment-14066336 ] 

Jacopo Cappellato edited comment on OFBIZ-4769 at 7/18/14 1:52 PM:
-------------------------------------------------------------------

Christian,

I think I have identified the root of the issue you are still facing.
When you use the German locale the "Edit" link has the following content:
{code}
https://localhost:8443/catalog/control/EditProductSuppliers?productId=WG-1111&partyId=BigSupplier&currencyUomId=USD&minimumOrderQuantity=500.000000&availableFromDate=2005-01-01%2000:00:00.000
{code}
The format of the minimumOrderQuantity (with value 500) is wrong for the German locale because it should be "500,000000" or "500".
As a consequence the record is not found and the edit form doesn't work; same issue for the delete link.
This is due to the fact that the widgets do not properly convert the parameters of the url into the German locale.
Could you please test the patch that I am attaching to this ticket (WidgetWorker.patch)? With this change the screen seems to work fine but this is just a work in progress and I would like to get some reviews to confirm that the approach and usage of the Conversion framework is right.



was (Author: jacopoc):
Christian,

I think I have identified the root of the issue you are still facing.
When you use the German locale the "Edit" link has the following content:
{code}
https://localhost:8443/catalog/control/EditProductSuppliers?productId=WG-1111&partyId=BigSupplier&currencyUomId=USD&minimumOrderQuantity=500.000000&availableFromDate=2005-01-01%2000:00:00.000
{code}
The format of the minimumOrderQuantity (with value 500) is wrong for the German locale because it should be "500.000000" or "500".
As a consequence the record is not found and the edit form doesn't work; same issue for the delete link.
This is due to the fact that the widgets do not properly convert the parameters of the url into the German locale.
Could you please test the patch that I am attaching to this ticket (WidgetWorker.patch)? With this change the screen seems to work fine but this is just a work in progress and I would like to get some reviews to confirm that the approach and usage of the Conversion framework is right.


> Editing of product suppliers is not working for the Germany locale
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4769
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4769
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>            Reporter: Sergei Biletnikov
>            Assignee: Jacques Le Roux
>         Attachments: JIRA-4769-EditProductSuppliers-20121213.diff, JIRA-4769EditProductSuppliers-20121222.patch, JIRA-4769EditProductSuppliers-20121222.patch, JIRA-4769EditProductSuppliers-20121222.patch, OFBIZ-4769-20121227.patch, OFBIZ-4769-Updated.patch, OFBIZ-4769.patch, WidgetWorker.patch
>
>
> Please, open any product and add to it a supplier (SupplierProduct), than try to edit it (..../catalog/control/EditProductSuppliers?productId=xxx). 
> It works for English locale, but it does not work for German, I have the following error:
> =-=-=-=-=-=-=-=-= Database type warning GenericEntity.set =-=-=-=-=-=-=-=-= In entity field [SupplierProduct.minimumOrderQuantity] set the value passed in [java.lang.String] is not compatible with the Java type of the field [java.math.BigDecimal]
> Exception: java.lang.Exception
> Message: Location of database type warning
> ---- stack trace ---------------------------------------------------------------
> java.lang.Exception: Location of database type warning
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:426)
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:372)
> org.ofbiz.entity.GenericEntity.setAllFields(GenericEntity.java:887)
> ................
> ---- exception report ----------------------------------------------------------
> =-=-=-=-=-=-=-=-= Database type warning GenericEntity.set =-=-=-=-=-=-=-=-= In entity field [SupplierProduct.availableFromDate] set the value passed in [java.lang.String] is not compatible with the Java type of the field [java.sql.Timestamp]
> Exception: java.lang.Exception
> Message: Location of database type warning
> ---- stack trace ---------------------------------------------------------------
> java.lang.Exception: Location of database type warning
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:426)
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:372)
> org.ofbiz.entity.GenericEntity.setAllFields(GenericEntity.java:887)
> org.ofbiz.entity.finder.PrimaryKeyFinder.runFind(PrimaryKeyFinder.java:106)
> ..................
> the investigation says me the following:
>    <screen name="EditSupplierProduct">
>         <section>
>             <actions>
>                 <set field="titleProperty" value="PageTitleEditSupplierProduct"/>
>                 <set field="tabButtonItem" value="EditSupplierProduct"/>
>                 <set field="labelTitleProperty" value="ProductSuppliers"/>
>                 <!-- default currency in framework/common/config/general.properties -->
>                 <property-to-field field="defaultCurrencyUomId" resource="general" property="currency.uom.id.default" default="USD"/>
>                 <set field="productId" from-field="parameters.productId"/>
>                 <set field="orderBy" from-field="parameters.orderBy" default-value="partyId"/>
>                 <entity-and entity-name="SupplierProduct" list="productSuppliers">
>                     <field-map field-name="productId"/>
>                     <order-by field-name="${orderBy}"/>
>                 </entity-and>
>                 <entity-one entity-name="SupplierProduct" value-field="supplierProduct" auto-field-map="true"/>
>             </actions
> ...............
> where <entity-one entity-name="SupplierProduct" value-field="supplierProduct" auto-field-map="true"/>  can not be done.
> I suppose that the problem depends on the German locale, where BigDecimal and Date has another format than we have in the parameters via URL.



--
This message was sent by Atlassian JIRA
(v6.2#6252)