[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1328: Add max background jobs to configuration

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1328:
URL: https://github.com/apache/incubator-kvrocks/pull/1328#discussion_r1141642160


##########
kvrocks.conf:
##########
@@ -575,15 +575,8 @@ rocksdb.target_file_size_base 128
 # allowed.
 rocksdb.max_write_buffer_number 4
 
-# Maximum number of concurrent background compaction jobs, submitted to
-# the default LOW priority thread pool.
-rocksdb.max_background_compactions 4
-
-# Maximum number of concurrent background memtable flush jobs, submitted by
-# default to the HIGH priority thread pool. If the HIGH priority thread pool
-# is configured to have zero threads, flush jobs will share the LOW priority
-# thread pool with compaction jobs.
-rocksdb.max_background_flushes 4

Review Comment:
   Yes, I think we can mark them as deprecated first and set the default value to -1, then encourage users to use the max_background_jobs like RocksDB: https://github.com/facebook/rocksdb/blob/8c445407b79ab02620e15cdd1257b1c99ea09601/include/rocksdb/options.h#L701



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org