You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/27 05:32:28 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4899: [Improvement-4898][API] the paging query interface validates page params
codecov-io commented on pull request #4899:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4899#issuecomment-787009608
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899?src=pr&el=h1) Report
> Merging [#4899](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899?src=pr&el=desc) (a3690ad) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b8788f007b1617605e05d70c0ff33c4aa7318c4b?el=desc) (b8788f0) will **decrease** coverage by `0.16%`.
> The diff coverage is `30.76%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4899 +/- ##
============================================
- Coverage 47.07% 46.90% -0.17%
+ Complexity 3639 3625 -14
============================================
Files 567 567
Lines 23811 23825 +14
Branches 2742 2747 +5
============================================
- Hits 11209 11176 -33
- Misses 11588 11640 +52
+ Partials 1014 1009 -5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...uler/api/controller/ProcessInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `3.44% <0.00%> (-0.19%)` | `2.00 <0.00> (ø)` | |
| [...hinscheduler/api/controller/ProjectController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvamVjdENvbnRyb2xsZXIuamF2YQ==) | `5.12% <0.00%> (-0.43%)` | `2.00 <0.00> (ø)` | |
| [...nscheduler/api/controller/SchedulerController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvU2NoZWR1bGVyQ29udHJvbGxlci5qYXZh) | `5.26% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...cheduler/api/controller/WorkerGroupController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvV29ya2VyR3JvdXBDb250cm9sbGVyLmphdmE=) | `14.28% <0.00%> (-3.90%)` | `2.00 <0.00> (ø)` | |
| [...vice/impl/ProcessDefinitionVersionServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9jZXNzRGVmaW5pdGlvblZlcnNpb25TZXJ2aWNlSW1wbC5qYXZh) | `95.45% <ø> (-0.55%)` | `8.00 <0.00> (-2.00)` | |
| [...heduler/api/controller/TaskInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvVGFza0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `75.00% <50.00%> (-7.36%)` | `3.00 <0.00> (ø)` | |
| [...er/api/controller/ProcessDefinitionController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0RlZmluaXRpb25Db250cm9sbGVyLmphdmE=) | `73.14% <100.00%> (+1.30%)` | `21.00 <2.00> (+1.00)` | |
| [.../server/master/runner/DependentTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvRGVwZW5kZW50VGFza0V4ZWNUaHJlYWQuamF2YQ==) | `51.57% <0.00%> (-16.85%)` | `10.00% <0.00%> (-5.00%)` | |
| [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `43.62% <0.00%> (-9.40%)` | `16.00% <0.00%> (-4.00%)` | |
| [...olphinscheduler/server/utils/DependentExecute.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL0RlcGVuZGVudEV4ZWN1dGUuamF2YQ==) | `61.84% <0.00%> (-9.22%)` | `17.00% <0.00%> (-4.00%)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899?src=pr&el=footer). Last update [b8788f0...a3690ad](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org