[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #15491: [improve][connector] Sink support custom acknowledge type

[GitBox <gi...@apache.org>]

nicoloboschi commented on code in PR #15491:
URL: https://github.com/apache/pulsar/pull/15491#discussion_r879563093


##########
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarRecord.java:
##########
@@ -93,6 +95,15 @@ public Optional<Long> getEventTime() {
         }
     }
 
+    /**
+     * Some sink sometimes wants to control the ack type.
+     *
+     * @param cumulative
+     */
+    public void ack(boolean cumulative) {

Review Comment:
   what about adding `ackCumulative` or `cumulativeAck` instead of a blindly method with a boolean param? 
   
   it is also more similar to Consumer API 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org