You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Nicolas Malin (JIRA)" <ji...@apache.org> on 2019/03/23 10:55:00 UTC

[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

    [ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799604#comment-16799604 ] 

Nicolas Malin commented on OFBIZ-10817:
---------------------------------------

I will finish this issue :)

Thanks for your message, I update the patch[^OFBIZ-10817.patch] with adding two properties :
 * widget.freemarker.template.verbose : if you want for the exception displaying
 * widget.freemarker.template.exception.message :if you want edit your stacktrace string replacement

[~mthl] I agree it would be better to improve the design, currently I have no time to refund it (other priority issue :) ) and I prefer make a simple step to escape the bad case that you send an pdf order with twenty page of ftl stacktrace to the end user due to infra issue.

[~mbrohl] I implement your idea, just by property and direct display configuration (no use flexible expander or context analysis) to start. I can't use EntityUtilProperties easly without delegator. So ... first operational step as goal.

For your second suggest, I prefer to dedicate this part to log4j by production site configuration.

 

 

> Configure stackTrace displaying on ftl rendering
> ------------------------------------------------
>
>                 Key: OFBIZ-10817
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10817
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, OFBIZ-10817.patch, OFBIZ-10817.patch
>
>
> Currently when freemarker failed to execute a template, you have on end screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property widget.verbose is true, no regression during development and when you switch to production site, in general your widget.verbose is false so end user haven't stack trace (that totally unused for them).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)