[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8459: ARROW-10195: [C++] Add string struct extract kernel using re2

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on a change in pull request #8459:
URL: https://github.com/apache/arrow/pull/8459#discussion_r616977780



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -81,6 +83,13 @@ struct ARROW_EXPORT ReplaceSubstringOptions : public FunctionOptions {
   int64_t max_replacements;
 };
 
+struct ARROW_EXPORT ExtractRegexOptions : public FunctionOptions {
+  explicit ExtractRegexOptions(std::string regex) : regex(std::move(regex)) {}
+
+  /// Regular expression with named capture fields
+  std::string regex;

Review comment:
       
   
   Naming nit: I would maybe call this "pattern" instead of "regex"
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org