You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/12/30 07:29:04 UTC
spark git commit: [SPARK-12564][SQL] Improve missing column
AnalysisException
Repository: spark
Updated Branches:
refs/heads/master 7ab0e2289 -> 4f75f785d
[SPARK-12564][SQL] Improve missing column AnalysisException
```
org.apache.spark.sql.AnalysisException: cannot resolve 'value' given input columns text;
```
lets put a `:` after `columns` and put the columns in `[]` so that they match the toString of DataFrame.
Author: gatorsmile <ga...@gmail.com>
Closes #10518 from gatorsmile/improveAnalysisExceptionMsg.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/4f75f785
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/4f75f785
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/4f75f785
Branch: refs/heads/master
Commit: 4f75f785df0e59ca5ae48e86f3dfc00b45d96b18
Parents: 7ab0e22
Author: gatorsmile <ga...@gmail.com>
Authored: Tue Dec 29 22:28:59 2015 -0800
Committer: Reynold Xin <rx...@databricks.com>
Committed: Tue Dec 29 22:28:59 2015 -0800
----------------------------------------------------------------------
.../org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala | 2 +-
sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/4f75f785/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
index 440f679..a1be147 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
@@ -57,7 +57,7 @@ trait CheckAnalysis {
operator transformExpressionsUp {
case a: Attribute if !a.resolved =>
val from = operator.inputSet.map(_.name).mkString(", ")
- a.failAnalysis(s"cannot resolve '${a.prettyString}' given input columns $from")
+ a.failAnalysis(s"cannot resolve '${a.prettyString}' given input columns: [$from]")
case e: Expression if e.checkInputDataTypes().isFailure =>
e.checkInputDataTypes() match {
http://git-wip-us.apache.org/repos/asf/spark/blob/4f75f785/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
index 7fe66e4..c19b5a4 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
@@ -514,7 +514,7 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
val e = intercept[AnalysisException] {
ds.as[ClassData2].collect()
}
- assert(e.getMessage.contains("cannot resolve 'c' given input columns a, b"), e.getMessage)
+ assert(e.getMessage.contains("cannot resolve 'c' given input columns: [a, b]"), e.getMessage)
}
test("runtime nullability check") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org