You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/25 03:13:36 UTC

[GitHub] [flink] JingsongLi opened a new pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

JingsongLi opened a new pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204
 
 
   
   ## What is the purpose of the change
   
   In `CatalogTableImpl.fromProperties`, we can not remove all `schema.*` for TableSchema, because Schema (it is a descriptor) is not same to TableSchema.  Schema contains time attribute, so we need keep them in properties.
   
   ## Brief change log
   
   Remove per key for TableSchema in `CatalogTableImpl.fromProperties`.
   Add test `ConnectTableDescriptorTest`.
   
   ## Verifying this change
   
   `ConnectTableDescriptorTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590664310
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150413263",
       "triggerID" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9fe032f57c6dbe542682c2acf0a187f618b425ca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9fe032f57c6dbe542682c2acf0a187f618b425ca",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0c80dda8bc1a4903b03cf75d3570ecb1fc8b1d68",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0c80dda8bc1a4903b03cf75d3570ecb1fc8b1d68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25f8bebe1722525aab960e1dbc8ef38d4409b899 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150413263) 
   * 9fe032f57c6dbe542682c2acf0a187f618b425ca UNKNOWN
   * 0c80dda8bc1a4903b03cf75d3570ecb1fc8b1d68 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi merged pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590662142
 
 
   Thanks @JingsongLi . I think FLINK-16265 is also introduced by FLINK-15912. We should fix that too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383675893
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/descriptors/ConnectTableDescriptorTest.java
 ##########
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors;
+
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.internal.Registration;
+import org.apache.flink.table.catalog.CatalogTableImpl;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Test for {@link ConnectTableDescriptor}.
+ */
+public class ConnectTableDescriptorTest {
 
 Review comment:
   There should be a rowtime field in `tableEnv.from("EnrichmentSource").getSchema`, because `DummyTableSourceFactory` in sql-client handles this. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590661788
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 25f8bebe1722525aab960e1dbc8ef38d4409b899 (Tue Feb 25 03:16:49 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383677579
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/descriptors/ConnectTableDescriptorTest.java
 ##########
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors;
+
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.internal.Registration;
+import org.apache.flink.table.catalog.CatalogTableImpl;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Test for {@link ConnectTableDescriptor}.
+ */
+public class ConnectTableDescriptorTest {
 
 Review comment:
   Maybe not.
   It is catalog table, not `ConnectorCatalogTable`.
   Real invoking is in `StreamTableSourceScan.translateToPlan`, it is hard to validate it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590842607
 
 
   Travis passed in: https://travis-ci.org/JingsongLi/flink/builds/654822147

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590664310
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150413263",
       "triggerID" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9fe032f57c6dbe542682c2acf0a187f618b425ca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9fe032f57c6dbe542682c2acf0a187f618b425ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25f8bebe1722525aab960e1dbc8ef38d4409b899 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150413263) 
   * 9fe032f57c6dbe542682c2acf0a187f618b425ca UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590842952
 
 
   Thanks @wuchong for reviewing, merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590664310
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25f8bebe1722525aab960e1dbc8ef38d4409b899 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383664396
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/descriptors/ConnectTableDescriptorTest.java
 ##########
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors;
+
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.internal.Registration;
+import org.apache.flink.table.catalog.CatalogTableImpl;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Test for {@link ConnectTableDescriptor}.
+ */
+public class ConnectTableDescriptorTest {
 
 Review comment:
   I think we can add a verification in `org.apache.flink.table.client.gateway.local.ExecutionContextTest#testTemporalTables` to check that the `tableEnv.from("EnrichmentSource").getTableSchema` contains the rowtime field. It can cover the bug path. 
   
   It's not clear what the purpose of this test. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383784570
 
 

 ##########
 File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/TestTableSourceFactoryBase.java
 ##########
 @@ -100,7 +100,7 @@ public TestTableSourceFactoryBase(String type, String testProperty) {
 	public StreamTableSource<Row> createTableSource(TableSourceFactory.Context context) {
 		TableSchema schema = context.getTable().getSchema();
 		final DescriptorProperties params = new DescriptorProperties(true);
-		params.putProperties(context.getTable().getProperties());
+		params.putProperties(context.getTable().toProperties());
 
 Review comment:
   `SchemaValidator.deriveRowtimeAttributes` need properties contains `TableSchema`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383672069
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/descriptors/ConnectTableDescriptorTest.java
 ##########
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors;
+
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.internal.Registration;
+import org.apache.flink.table.catalog.CatalogTableImpl;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Test for {@link ConnectTableDescriptor}.
+ */
+public class ConnectTableDescriptorTest {
 
 Review comment:
   There is no rowtime field in `tableEnv.from("EnrichmentSource").getSchema`. Rowtime field needs special handle in connector codes when translate `select ...` query.
   
   This test is just for making sure `CatalogTable` should be same to properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590664310
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150413263",
       "triggerID" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9fe032f57c6dbe542682c2acf0a187f618b425ca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9fe032f57c6dbe542682c2acf0a187f618b425ca",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0c80dda8bc1a4903b03cf75d3570ecb1fc8b1d68",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150451644",
       "triggerID" : "0c80dda8bc1a4903b03cf75d3570ecb1fc8b1d68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25f8bebe1722525aab960e1dbc8ef38d4409b899 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150413263) 
   * 9fe032f57c6dbe542682c2acf0a187f618b425ca UNKNOWN
   * 0c80dda8bc1a4903b03cf75d3570ecb1fc8b1d68 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150451644) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590664310
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150413263",
       "triggerID" : "25f8bebe1722525aab960e1dbc8ef38d4409b899",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 25f8bebe1722525aab960e1dbc8ef38d4409b899 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150413263) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383786077
 
 

 ##########
 File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/TestTableSourceFactoryBase.java
 ##########
 @@ -100,7 +100,7 @@ public TestTableSourceFactoryBase(String type, String testProperty) {
 	public StreamTableSource<Row> createTableSource(TableSourceFactory.Context context) {
 		TableSchema schema = context.getTable().getSchema();
 		final DescriptorProperties params = new DescriptorProperties(true);
-		params.putProperties(context.getTable().getProperties());
+		params.putProperties(context.getTable().toProperties());
 
 Review comment:
   Thank you. I see. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383784030
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/descriptors/ConnectTableDescriptorTest.java
 ##########
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors;
+
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.internal.Registration;
+import org.apache.flink.table.catalog.CatalogTableImpl;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Test for {@link ConnectTableDescriptor}.
+ */
+public class ConnectTableDescriptorTest {
 
 Review comment:
   OK, it is from SQL-CLI, it is `ConnectorCatalogTable` now, added test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383783751
 
 

 ##########
 File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/TestTableSourceFactoryBase.java
 ##########
 @@ -100,7 +100,7 @@ public TestTableSourceFactoryBase(String type, String testProperty) {
 	public StreamTableSource<Row> createTableSource(TableSourceFactory.Context context) {
 		TableSchema schema = context.getTable().getSchema();
 		final DescriptorProperties params = new DescriptorProperties(true);
-		params.putProperties(context.getTable().getProperties());
+		params.putProperties(context.getTable().toProperties());
 
 Review comment:
   Why do you change this? Is it a mistake?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383785092
 
 

 ##########
 File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/TestTableSourceFactoryBase.java
 ##########
 @@ -100,7 +100,7 @@ public TestTableSourceFactoryBase(String type, String testProperty) {
 	public StreamTableSource<Row> createTableSource(TableSourceFactory.Context context) {
 		TableSchema schema = context.getTable().getSchema();
 		final DescriptorProperties params = new DescriptorProperties(true);
-		params.putProperties(context.getTable().getProperties());
+		params.putProperties(context.getTable().toProperties());
 
 Review comment:
   The class was `createTableSource(properties)`, we should revert to that properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383784570
 
 

 ##########
 File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/TestTableSourceFactoryBase.java
 ##########
 @@ -100,7 +100,7 @@ public TestTableSourceFactoryBase(String type, String testProperty) {
 	public StreamTableSource<Row> createTableSource(TableSourceFactory.Context context) {
 		TableSchema schema = context.getTable().getSchema();
 		final DescriptorProperties params = new DescriptorProperties(true);
-		params.putProperties(context.getTable().getProperties());
+		params.putProperties(context.getTable().toProperties());
 
 Review comment:
   Yes, `SchemaValidator.deriveRowtimeAttributes` need properties contains `TableSchema`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11204: [FLINK-16264][table] Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#issuecomment-590678576
 
 
   > Thanks @JingsongLi . I think FLINK-16265 is also introduced by FLINK-15912. We should fix that too.
   
   I created https://github.com/apache/flink/pull/11205 to fix FLINK-16265.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services