You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Warren Turkal (JIRA)" <ji...@apache.org> on 2011/09/12 18:04:09 UTC
[jira] [Created] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Add eclipse target for supporting Apache IvyDE
----------------------------------------------
Key: ZOOKEEPER-1178
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
Project: ZooKeeper
Issue Type: Improvement
Components: build
Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
Reporter: Warren Turkal
Priority: Minor
This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting Apache IvyDE
Posted by Harsh J <ha...@cloudera.com>.
Warren,
Yes, that should be fine.
On 12-Sep-2011, at 9:57 PM, Warren Turkal wrote:
> Did I submit this patch in the correct way? There wasn't a place to include
> the patch in the submit patch dialog, so I just attached it as an
> attachment.
>
> Thanks,
> wt
Re: [jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by Warren Turkal <wt...@penguintechs.org>.
Did I submit this patch in the correct way? There wasn't a place to include
the patch in the submit patch dialog, so I just attached it as an
attachment.
Thanks,
wt
On Mon, Sep 12, 2011 at 9:10 AM, Warren Turkal (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Warren Turkal updated ZOOKEEPER-1178:
> -------------------------------------
>
> Attachment: eclipse-apache-ivyde-support.patch
>
> > Add eclipse target for supporting Apache IvyDE
> > ----------------------------------------------
> >
> > Key: ZOOKEEPER-1178
> > URL:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> > Project: ZooKeeper
> > Issue Type: Improvement
> > Components: build
> > Environment: Mac OS X w/ Eclipse 3.7. However, I believe this
> will work in any Eclipse environment.
> > Reporter: Warren Turkal
> > Priority: Minor
> > Attachments: eclipse-apache-ivyde-support.patch
> >
> > Original Estimate: 1h
> > Remaining Estimate: 1h
> >
> > This patch adds support for Eclipse with Apache IvyDE, which is the
> extension that integrates Ivy support into Eclipse. This allows the creation
> of what appear to be fully portable .eclipse and .classpath files. I will be
> posting a patch shortly.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
Re: [jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by Warren Turkal <wt...@ooyala.com>.
Ping? Is there anything else I need to do to get this patch in?
Thanks,
wt
On Tue, Aug 7, 2012 at 3:07 PM, Warren Turkal (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430670#comment-13430670]
>
> Warren Turkal commented on ZOOKEEPER-1178:
> ------------------------------------------
>
> Is there anything else that needs to be done before this can be submitted?
>
> > Add eclipse target for supporting Apache IvyDE
> > ----------------------------------------------
> >
> > Key: ZOOKEEPER-1178
> > URL:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> > Project: ZooKeeper
> > Issue Type: Improvement
> > Components: build
> > Environment: Mac OS X w/ Eclipse 3.7. However, I believe this
> will work in any Eclipse environment.
> > Reporter: Warren Turkal
> > Assignee: Warren Turkal
> > Priority: Minor
> > Fix For: 3.5.0
> >
> > Attachments: ZOOKEEPER-1178.patch
> >
> > Original Estimate: 1h
> > Remaining Estimate: 1h
> >
> > This patch adds support for Eclipse with Apache IvyDE, which is the
> extension that integrates Ivy support into Eclipse. This allows the
> creation of what appear to be fully portable .eclipse and .classpath files.
> I will be posting a patch shortly.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
*Warren Turkal*
Site Reliability Engineer |
wt@ooyala.com | 650-961-3400
www.ooyala.com | blog <http://www.ooyala.com/blog> |
@ooyala<http://www.twitter.com/ooyala>
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427631#comment-13427631 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
The newest patch is of that form. I still need to add the license headers. I'll do that now.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434914#comment-13434914 ]
Hadoop QA commented on ZOOKEEPER-1178:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541011/ZOOKEEPER-1178.patch
against trunk revision 1373156.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1162//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1162//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1162//console
This message is automatically generated.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
Re-cut patch from tip of trunk.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425027#comment-13425027 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
Where should these files go? They aren't really templates. They are the actual files that should be used by eclipse. If possible, I'd like to go ahead and tie this one off so that I can add the info about how to use this support to the UsingEclipse page on the wiki.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
This patch makes the eclipse-with-ivyde rule depend on building the generated code.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1178:
---------------------------------------
Assignee: Warren Turkal
Thanks Warren, please do try to name the patch after the JIRA #, ie ZOOKEEPER-1178.patch in this case, see:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: eclipse-apache-ivyde-support.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102780#comment-13102780 ]
Hadoop QA commented on ZOOKEEPER-1178:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494054/eclipse-apache-ivyde-support.patch
against trunk revision 1166970.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/524//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/524//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/524//console
This message is automatically generated.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Attachments: eclipse-apache-ivyde-support.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103758#comment-13103758 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
Looks like this issue is still unassigned. Would anyone be willing to take it on. It's a really small patch.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Attachments: eclipse-apache-ivyde-support.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426231#comment-13426231 ]
Patrick Hunt commented on ZOOKEEPER-1178:
-----------------------------------------
what did you think of my previous comment? specifically:
bq. 3) don't put the "eclipse_with_ivyde" into conf - that's for the main code configuration. Perhaps just put it at the toplevel (same level as conf) as ".eclipse_with_ivyde" ?
Also, for the new files you are adding please add Apache license headers. Thx.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
Updated patch.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: eclipse-apache-ivyde-support.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Fix Version/s: 3.5.0
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: eclipse-apache-ivyde-support.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: eclipse-apache-ivyde-support.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
Oops. Last patch generated with incorrect git config.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: eclipse-apache-ivyde-support.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434841#comment-13434841 ]
Hadoop QA commented on ZOOKEEPER-1178:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541007/ZOOKEEPER-1178.patch
against trunk revision 1373156.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1161//console
This message is automatically generated.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427139#comment-13427139 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
I completely misread that. I now think you were saying to make .eclipse_with_ivyde a directory. That seems reasonable. I'll update the patch.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430670#comment-13430670 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
Is there anything else that needs to be done before this can be submitted?
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435352#comment-13435352 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
I think this one's ready for inclusion submission. Can a committer please pull the trigger?
Thanks.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107364#comment-13107364 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
I changed the filename of the patch to ZOOKEEPER-1178.patch like you said.
As for your other questions:
1) This is better than using the ant-eclipse.jar as it doesn't just try to detect the project structure, you can actually have the real .project and .classpath files checked in. Using ant-eclipse.jar, you cannot do that as the .classpath file will contain absolute paths to some of the jar the are dependencies for the build, which means that .classpath contains local settings. Using this patch with the Apache IvyDE extension for eclipse allows the .classpath to refer to the Ivy deps in a way that doesn't involve putting absolute paths into the .classpath file. Compare the .classpath from a newly generated zookeeper eclipse project with "ant eclipse" vs. the .classpath in this patch. The line containing the string IVYDE is the important one in the new file in the patch. Also, having the real .project file checked in should allow us to have more complex configuration out-of-the-box for Eclipse users, such as having the code style pre-configured.
2) I would love to do so.
3) Ok, that kinda sets a new president for where files like this should go. Is that okay with others in the project?
With regard to this patch, I honestly think that the .eclipse and .classpath files should eventually be moved to the root of the project so that anyone using eclipse can just import the project. We could even include a code style and other project settings that all eclipse users should have. The user specific .settings directory should not be included in the repo, of course. AFAICT, the only thing stopping that from being realistic today is having the ant-eclipse.jar generate a .classpath with absolute paths, which this patch addresses at the cost of requiring the IvyDE extension. However, I think that requiring Eclipse developers to use the IvyDE extension is a pretty small barrier since (a) zookeeper already has an ivy configuration and (b) it's an free and open source (Apache even) extension.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427626#comment-13427626 ]
Patrick Hunt commented on ZOOKEEPER-1178:
-----------------------------------------
Yes, that's what I was thinking - make it a directory.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191448#comment-13191448 ]
Patrick Hunt commented on ZOOKEEPER-1178:
-----------------------------------------
I see pig calls it ".eclipse.templates" while hive calls it "eclipse.templates" so I doubt we'll get my objections - imo we should rename it to ".eclipse.templates" (I don't see any objections to my original suggestion either, so we're probably safe).
Note - if you use git be sure to use the --no-prefix option when creating the patch. Regards.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
Updated to trunk as of 2012-07-29.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: eclipse-apache-ivyde-support.patch
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Attachments: eclipse-apache-ivyde-support.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Assignee: (was: Warren Turkal)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452595#comment-13452595 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
Ping again. :)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440696#comment-13440696 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
*ping*
Is there anything else I need to do to get this patch submitted?
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434641#comment-13434641 ]
Hadoop QA commented on ZOOKEEPER-1178:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538960/ZOOKEEPER-1178.patch
against trunk revision 1373156.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1160//console
This message is automatically generated.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187075#comment-13187075 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
Please give this a new look when you get a chance. It's slightly improved from the last version, and it really improves the eclipse workflow when compared to the current way that the build.xml has to generate the eclipse metadata.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459093#comment-13459093 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
*ping*...Please?
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
Added license headers.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: ZOOKEEPER-1178.patch
Fixed the location of build class files.
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1178) Add eclipse target for
supporting Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426813#comment-13426813 ]
Warren Turkal commented on ZOOKEEPER-1178:
------------------------------------------
Gah, I must have overlooked you commment while I was scanning over the ticket. I really don't like putting them in a hidden file at the top level if they aren't going to be used by eclipse directly. Ideally, the files would just be the toplevel .eclipse and .classpath files and we could just require that folks use the Apache IvyDE extension for Eclipse. If that's no good, I just want to put them in a reasonable and visible place so that they aren't hidden from folks. I also don't want them to clutter the root of the repo if they are not hidden.
If conf isn't a good place, should I just create an /ide_support/eclipse_files directory and put the files there?
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1178) Add eclipse target for supporting
Apache IvyDE
Posted by "Warren Turkal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Warren Turkal updated ZOOKEEPER-1178:
-------------------------------------
Attachment: (was: ZOOKEEPER-1178.patch)
> Add eclipse target for supporting Apache IvyDE
> ----------------------------------------------
>
> Key: ZOOKEEPER-1178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1178
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Environment: Mac OS X w/ Eclipse 3.7. However, I believe this will work in any Eclipse environment.
> Reporter: Warren Turkal
> Assignee: Warren Turkal
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1178.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This patch adds support for Eclipse with Apache IvyDE, which is the extension that integrates Ivy support into Eclipse. This allows the creation of what appear to be fully portable .eclipse and .classpath files. I will be posting a patch shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira