You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/09 00:04:12 UTC
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #446: [YUNIKORN-1366] Read core configuration from shim
codecov[bot] commented on PR #446:
URL: https://github.com/apache/yunikorn-core/pull/446#issuecomment-1308002129
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#446](https://codecov.io/gh/apache/yunikorn-core/pull/446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (effbf9c) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/decbabd8f9b8bf9150aee2f4cda2a47f3f42383a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (decbabd) will **decrease** coverage by `0.06%`.
> The diff coverage is `70.34%`.
```diff
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 72.63% 72.56% -0.07%
==========================================
Files 65 67 +2
Lines 9569 9778 +209
==========================================
+ Hits 6950 7095 +145
- Misses 2381 2445 +64
Partials 238 238
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/configs/config.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZy5nbw==) | `100.00% <ø> (+23.33%)` | :arrow_up: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `75.21% <ø> (+0.42%)` | :arrow_up: |
| [pkg/scheduler/tests/mock\_rm\_callback.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci90ZXN0cy9tb2NrX3JtX2NhbGxiYWNrLmdv) | `33.33% <ø> (+6.66%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.88% <ø> (+0.33%)` | :arrow_up: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `30.19% <8.33%> (-0.83%)` | :arrow_down: |
| [pkg/scheduler/ugm/manager.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci91Z20vbWFuYWdlci5nbw==) | `55.05% <55.05%> (ø)` | |
| [pkg/scheduler/ugm/queue\_tracker.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci91Z20vcXVldWVfdHJhY2tlci5nbw==) | `84.84% <84.84%> (ø)` | |
| [pkg/log/logger.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `91.46% <90.62%> (+11.97%)` | :arrow_up: |
| [pkg/scheduler/objects/node\_collection.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGVfY29sbGVjdGlvbi5nbw==) | `93.23% <100.00%> (-2.26%)` | :arrow_down: |
| [pkg/scheduler/ugm/group\_tracker.go](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci91Z20vZ3JvdXBfdHJhY2tlci5nbw==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/yunikorn-core/pull/446/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org