You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "tuhaihe (via GitHub)" <gi...@apache.org> on 2026/10/13 04:14:41 UTC
[PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
tuhaihe opened a new pull request, #2120:
URL: https://github.com/apache/cloudberry/pull/2120
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#issuecomment-6182620884
Now I think this PR is ready for being merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#issuecomment-6143318450
This PR is mainly about fixing the LICENSE issues in the core that were raised in our 2.2 RC2 release on the Incubator's mailing list.
Could you please help take a look, @pjfanning ? Thank you!
For the `gpAux/extensions/pljava/src/java/Makefile.global`, we will remove this file in #2123.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#discussion_r4268216183
##########
LICENSE:
##########
@@ -480,10 +483,20 @@ Copyright (c) 2004-2020 VMware, Inc. or its affiliates. All Rights Reserved.
All Rights Reserved.
-Some ORCA query optimizer files that Greenplum Database added in 2024
-carry a "Copyright (C) 2024 Broadcom" or "Copyright (C) 2024 VMware by
-Broadcom" notice instead; they are part of Greenplum Database and are
-covered by the same license.
+Files that came from Greenplum Database carry the copyright notice of
+whoever owned the code when they were written: Greenplum, Inc., EMC
+Corporation, Pivotal Software, VMware, Inc., or, for some ORCA query
+optimizer files added in 2024, "Copyright (C) 2024 Broadcom" or
+"Copyright (C) 2024 VMware by Broadcom". Three management scripts carry
+an older "Copyright (c) Metapa 2005" notice; Metapa merged with Didera in
+2003 to form Greenplum:
+
+ gpMgmt/bin/gpinitsystem
+ gpMgmt/bin/lib/gp_bash_functions.sh
+ gpMgmt/bin/lib/gpcreateseg.sh
+
+All of these files are part of Greenplum Database and are covered by the
Review Comment:
this line seems odd given that the next lines are about the Greenplum Database - can this be omitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#discussion_r4268208225
##########
LICENSE:
##########
@@ -480,10 +483,20 @@ Copyright (c) 2004-2020 VMware, Inc. or its affiliates. All Rights Reserved.
All Rights Reserved.
-Some ORCA query optimizer files that Greenplum Database added in 2024
-carry a "Copyright (C) 2024 Broadcom" or "Copyright (C) 2024 VMware by
-Broadcom" notice instead; they are part of Greenplum Database and are
-covered by the same license.
+Files that came from Greenplum Database carry the copyright notice of
+whoever owned the code when they were written: Greenplum, Inc., EMC
+Corporation, Pivotal Software, VMware, Inc., or, for some ORCA query
+optimizer files added in 2024, "Copyright (C) 2024 Broadcom" or
+"Copyright (C) 2024 VMware by Broadcom". Three management scripts carry
+an older "Copyright (c) Metapa 2005" notice; Metapa merged with Didera in
+2003 to form Greenplum:
+
+ gpMgmt/bin/gpinitsystem
+ gpMgmt/bin/lib/gp_bash_functions.sh
+ gpMgmt/bin/lib/gpcreateseg.sh
+
+All of these files are part of Greenplum Database and are covered by the
+same license.
Greenplum Database is licensed under the Apache License Version 2.0
(see LICENSE) and is based on the PostgreSQL Database Management System.
Review Comment:
what LICENSE? - this file is LICENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#issuecomment-6163935334
> There were LICENSE issues in apache-cloudberry-pxf-2.2.0-incubating-src.tar.gz as well. Is there going to be a PR for those?
https://github.com/apache/cloudberry-pxf/pull/170 and https://github.com/apache/cloudberry-pxf/pull/171 seem to be for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#issuecomment-6163849441
Thanks for working through the RC2 license feedback. I checked the new `LICENSE` entries against the file headers on this branch and found a few remaining issues:
1. **`README.apache.md:34`: the Metapa attribution is wrong.** It says Metapa contributed to the Greenplum-based code under Apache-2.0. But by this PR's own account Metapa merged into Greenplum in 2003, before any Apache-2.0 licensing. The Apache-2.0 grant for `gpinitsystem`, `gp_bash_functions.sh` and `gpcreateseg.sh` came from the later owner (Greenplum, then Pivotal/VMware). As written, it will likely draw another review question.
2. **`LICENSE:491`: the Metapa dates don't add up.** It calls "Copyright (c) Metapa 2005" an "older" notice, yet says Metapa merged into Greenplum in 2003. The 2005 notice is also newer than the 2004 Greenplum/VMware notice just above it. Better to call it a legacy Metapa notice and drop "older".
3. **`LICENSE:247`: two headers are described wrongly.** `src/include/getopt_long.h` and `src/include/pg_getopt.h` are listed as each carrying its own UC copyright notice and the 3-clause BSD terms. Neither file contains any BSD license text, only a "Portions Copyright ... The Regents" line. The entry should say they are derived from BSD getopt and covered by `licenses/LICENSE-bsd3-regents.txt`.
4. **`LICENSE:725`: the top-level `configure` script is missing.** The new build-system section mentions it but doesn't list it. It has its own notice ("Copyright (C) 1992-1996, 1998-2012 Free Software Foundation, Inc. ... gives unlimited permission"), so it belongs in the FSF All-Permissive block.
5. **`pom.xml:333`: the existing RAT exclude comment now contradicts `LICENSE` (not a line this PR changes).** `config/ax_pthread.m4` sits under a `<!-- GPLv2-AUTOEXC -->` comment, while the new `LICENSE` correctly lists it as GPL-3.0-or-later with the Autoconf exception. It should move under a GPLv3 + Autoconf exception comment.
Checked and fine:
- The new `config/` entries have the right copyright lines and licenses.
- The `hints.h`, `test_regex` and Metapa script entries match their file headers.
- The googlemock generator in the googletest submodule (at commit `a09ea70`) is Apache-2.0, has no NOTICE to carry over, and the release script includes submodules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#issuecomment-6163880241
There were LICENSE issues in apache-cloudberry-pxf-2.2.0-incubating-src.tar.gz as well. Is there going to be a PR for those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] [REL_2_STABLE] Fix the license issues in RC2 review [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #2120:
URL: https://github.com/apache/cloudberry/pull/2120#issuecomment-6166087198
> Thanks for working through the RC2 license feedback. I checked the new `LICENSE` entries against the file headers on this branch and found a few remaining issues:
>
> 1. **`README.apache.md:34`: the Metapa attribution is wrong.** It says Metapa contributed to the Greenplum-based code under Apache-2.0. But by this PR's own account Metapa merged into Greenplum in 2003, before any Apache-2.0 licensing. The Apache-2.0 grant for `gpinitsystem`, `gp_bash_functions.sh` and `gpcreateseg.sh` came from the later owner (Greenplum, then Pivotal/VMware). As written, it will likely draw another review question.
> 2. **`LICENSE:491`: the Metapa dates don't add up.** It calls "Copyright (c) Metapa 2005" an "older" notice, yet says Metapa merged into Greenplum in 2003. The 2005 notice is also newer than the 2004 Greenplum/VMware notice just above it. Better to call it a legacy Metapa notice and drop "older".
> 3. **`LICENSE:247`: two headers are described wrongly.** `src/include/getopt_long.h` and `src/include/pg_getopt.h` are listed as each carrying its own UC copyright notice and the 3-clause BSD terms. Neither file contains any BSD license text, only a "Portions Copyright ... The Regents" line. The entry should say they are derived from BSD getopt and covered by `licenses/LICENSE-bsd3-regents.txt`.
> 4. **`LICENSE:725`: the top-level `configure` script is missing.** The new build-system section mentions it but doesn't list it. It has its own notice ("Copyright (C) 1992-1996, 1998-2012 Free Software Foundation, Inc. ... gives unlimited permission"), so it belongs in the FSF All-Permissive block.
> 5. **`pom.xml:333`: the existing RAT exclude comment now contradicts `LICENSE` (not a line this PR changes).** `config/ax_pthread.m4` sits under a `<!-- GPLv2-AUTOEXC -->` comment, while the new `LICENSE` correctly lists it as GPL-3.0-or-later with the Autoconf exception. It should move under a GPLv3 + Autoconf exception comment.
>
> Checked and fine:
>
> * The new `config/` entries have the right copyright lines and licenses.
> * The `hints.h`, `test_regex` and Metapa script entries match their file headers.
> * The googlemock generator in the googletest submodule (at commit `a09ea70`) is Apache-2.0, has no NOTICE to carry over, and the release script includes submodules.
Thanks a lot for the careful review, @pjfanning! All points are addressed in d25dc17ce9b:
1. `README.apache.md`: the section now lists these companies as the holders of the copyright notices in the Greenplum-based files, not as contributors under the Apache License 2.0. It also states that Greenplum Database was released under ALv2 in 2015.
2. `LICENSE`: the Metapa notice is now called a "legacy" notice, and "older" is gone.
3. `LICENSE`: `getopt_long.h` and `pg_getopt.h` are now listed separately as headers derived from BSD getopt that carry only the "Portions Copyright ... The Regents" line, still pointing to `licenses/LICENSE-bsd3-regents.txt`.
4. `LICENSE`: the top-level `configure` script is now listed in the FSF All-Permissive block with its own notice. The section is retitled "Build system files".
5. `pom.xml`: `config/ax_pthread.m4` now has its own "GPLv3-or-later with the Autoconf Macro exception" comment.
From the inline comments:
- "(see LICENSE)" now reads "(see the top of this file)", and the Apache License statement opens the Greenplum section.
- The "All of these files ... covered by the same license" sentence is removed, since it is now redundant.
Thanks also for confirming the `googlemock` generator and the `config/` entries, and for finding `cloudberry-pxf#170/#171`.
Thanks for your guidance again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org