[jira] [Resolved] (ACCUMULO-3172) mavanagaiata plugin marks releases "dirty"

["Christopher Tubbs (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ACCUMULO-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christopher Tubbs resolved ACCUMULO-3172.
-----------------------------------------
    Resolution: Fixed

Drop dirty flag for release profile. However, it seems there's another bug with the mavanagaiata plugin which always makes builds dirty, even when they aren't. I'm not too concerned about that, as long as the releases aren't incorrectly marked, and that is fixed here.

> mavanagaiata plugin marks releases "dirty"
> ------------------------------------------
>
>                 Key: ACCUMULO-3172
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3172
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Blocker
>             Fix For: 1.5.3, 1.6.2, 1.7.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The mavanagaiata plugin we use to populate the build number in the META-INF/MANIFEST.MF file appends "-dirty" to the git commit hash. I believe this is probably done because the release plugin is adding additional files to the working branch, but I can't be sure.
> We should alter the build such that the MANIFEST.MF files don't indicate it was built from a dirty state when it wasn't.
> Further, if possible, we should fail the release:prepare goal if it tries to build from a dirty state initially. I know this was a feature of the buildnumber-maven-plugin, but it doesn't appear to be an option for this mavanagaiata one (why did we switch when we added this field back to the manifest files?)
> See https://github.com/koraktor/mavanagaiata/issues/34



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)