[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11163: refactor: Replace usages of Popover from react-bootstrap with Antd [WIP]

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #11163:
URL: https://github.com/apache/incubator-superset/pull/11163#discussion_r501041041



##########
File path: superset-frontend/spec/javascripts/components/URLShortLinkButton_spec.jsx
##########
@@ -20,7 +20,7 @@ import React from 'react';
 import configureStore from 'redux-mock-store';
 import { shallow } from 'enzyme';
 
-import { OverlayTrigger } from 'react-bootstrap';
+import Popover from 'src/common/components/Popover';

Review comment:
       Other components from Antd are placed in `src/common/components` and they are wrapped in `styled` from emotion. I think moving Popover to `src/components/` would lead to inconsistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org