You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/07 15:41:59 UTC
[GitHub] [doris] xy720 commented on a diff in pull request #12424: [fix](array-type) fix the invalid format load for stream load
xy720 commented on code in PR #12424:
URL: https://github.com/apache/doris/pull/12424#discussion_r965006945
##########
be/src/vec/exec/vbroker_scanner.cpp:
##########
@@ -95,6 +91,10 @@ Status VBrokerScanner::_fill_dest_columns(const Slice& line,
return Status::OK();
}
+ if (!check_array_format(_split_values)) {
Review Comment:
I think it is not a good implementation. We can filter the invalid row in tablet_sink.cpp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org