[GitHub] [solr] risdenk commented on a diff in pull request #1062: Fix documentation irrelevant minor mistake

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1062:
URL: https://github.com/apache/solr/pull/1062#discussion_r997339925


##########
solr/solr-ref-guide/modules/deployment-guide/pages/taking-solr-to-production.adoc:
##########
@@ -455,7 +455,7 @@ Ideally this would mean more machines, but budget constraints might make that im
 There is another issue once the heap reaches 32GB.
 Below 32GB, Java is able to use compressed pointers, but above that point, larger pointers are required, which uses more memory and slows down the JVM.

Review Comment:
   Add references here to what this means. For example:
   * https://blog.codecentric.de/35gb-heap-less-32gb-java-jvm-memory-oddities
   * https://blog.foundev.pro/2021/02/03/heap-size-around-31gb.html
   * https://www.baeldung.com/jvm-compressed-oops
   * https://docs.oracle.com/javase/7/docs/technotes/guides/vm/performance-enhancements-7.html#compressedOop



##########
solr/solr-ref-guide/modules/deployment-guide/pages/taking-solr-to-production.adoc:
##########
@@ -455,7 +455,7 @@ Ideally this would mean more machines, but budget constraints might make that im
 There is another issue once the heap reaches 32GB.
 Below 32GB, Java is able to use compressed pointers, but above that point, larger pointers are required, which uses more memory and slows down the JVM.
 
-Because of the potential garbage collection issues and the particular issues that happen at 32GB, if a single instance would require a 64GB heap, performance is likely to improve greatly if the machine is set up with two nodes that each have a 31GB heap.
+Because of the potential garbage collection issues and the particular issues that happen at 32GB, if a single instance would require a 64GB heap, performance is likely to improve greatly if the machine is set up with two nodes that each have a 32GB heap.

Review Comment:
   Remove this section altogether. Replace it (optionally) with something like:
   > If you need to go over 31GB of heap, then you need to consider multiple nodes since they typically will perform better than one node with >32GB of heap.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org