You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/20 03:36:02 UTC
[jira] [Commented] (WEEX-173) iconfont redraw failed sometimes on
iOS
[ https://issues.apache.org/jira/browse/WEEX-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297842#comment-16297842 ]
ASF GitHub Bot commented on WEEX-173:
-------------------------------------
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/944
[WEEX-173][iOS] fix iconfont draw failed sometimes
the order of drawing text and the action of building font-family in javaScript is not reliable,
so the observer needs to be added to every text component which specify the font-family,
when the the custom font download finish, redraw action will compare the font-family with
font-family of text who received notification and then execute redrawing action.
Bug: 173
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex ios-bugfix-text
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #944
----
commit bfbddecf6b5c8ecf16d2df33984f877f6201e70a
Author: acton393 <zh...@...>
Date: 2017-12-20T03:35:13Z
[WEEX-173][iOS] fix iconfont draw failed sometimes
the order of drawing text and the action of building font-family in javaScript is not reliable,
so the observer needs to be added to every text component which specify the font-family,
when the the custom font download finish, redraw action will compare the font-family with
font-family of text who received notification and then execute redrawing action.
Bug: 173
----
> iconfont redraw failed sometimes on iOS
> ---------------------------------------
>
> Key: WEEX-173
> URL: https://issues.apache.org/jira/browse/WEEX-173
> Project: Weex
> Issue Type: Bug
> Reporter: xingZhang
> Assignee: xingZhang
>
> the reason why redraw failed is that the order of drawing text and the action of addRule is not reliable
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)