You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/10 06:51:48 UTC
[GitHub] [skywalking-rocketbot-ui] kagaya85 opened a new pull request #525: add go-kartos component logo
kagaya85 opened a new pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525
part of https://github.com/apache/skywalking/pull/7428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-895775957
Could you share the screenshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kagaya85 commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
kagaya85 commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-913175950
> @kagaya85 @kezhenxu94 What is the status of this?
I think it is ready to merge. The icon is named as `KRATOS.png` and used only one componentID in previous merged PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-895776249
Notice, once this gets merge, you need to update main repo's submodule to include this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kagaya85 commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
kagaya85 commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896084410
> Which components I'd do you want to keep? 5011 or 5010?
client & server components are both needed, respectively correspond to GOKRATOSCLIENT.png and GOKRATOSSERVER.png, is this feasible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-913174823
@kagaya85 @kezhenxu94 What is the status of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896100595
If they share, you need one only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kagaya85 commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
kagaya85 commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896054274
I have only kept KRATOS.png, maybe it is better not to use mapping like GoMicroServer & GoMicroClient to void generating redundant component ids?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896374217
They are always different for any rpc framework. Check the existing plugins. But we can't find the point. Do you? What do 2 IDs help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kagaya85 commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
kagaya85 commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896113920
In fact for a single call, the client and server use different middleware plugins, so maybe we need two componentIDs to distinguish them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kezhenxu94 edited a comment on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896068492
> I have only kept KRATOS.png, maybe it is better not to use mapping like GoMicroServer & GoMicroClient to void generating redundant component ids?
Which components I'd do you want to keep? 5011 or 5010?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896043801
Check https://github.com/apache/skywalking/pull/7435 , you only need one logo file named `KRATOS.png`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #525: add go-kartos component logo
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #525:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/525#issuecomment-896068492
> I have only kept KRATOS.png, maybe it is better not to use mapping like GoMicroServer & GoMicroClient to void generating redundant component ids?
Which components I'd do you want to keep? 5011 or 5012?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org