[jira] [Commented] (KAFKA-8614) Rename the `responses` field of IncrementalAlterConfigsResponse to match AlterConfigs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876544#comment-16876544 ] 

ASF GitHub Bot commented on KAFKA-8614:
---------------------------------------

bob-barrett commented on pull request #7022: KAFKA-8614: Rename the `responses` field of IncrementalAlterConfigsRe…
URL: https://github.com/apache/kafka/pull/7022
 
 
   …sponse to match AlterConfigs
   
   This patch changes the name of the `responses` field of IncrementalAlterConfigsResponse to `Resources`. This makes it consistent with AlterConfigsResponse, which has a differently-named but structurally-identical field.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rename the `responses` field of IncrementalAlterConfigsResponse to match AlterConfigs
> -------------------------------------------------------------------------------------
>
>                 Key: KAFKA-8614
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8614
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 2.3.0
>            Reporter: Bob Barrett
>            Assignee: Bob Barrett
>            Priority: Minor
>
> IncrementalAlterConfigsResponse and AlterConfigsResponse have an identical structure for per-resource error codes, but in AlterConfigsResponse it is named `Resources` while in IncrementalAlterConfigsResponse it is named `responses`.
> AlterConfigsResponse:
> {code:java}
> { "name": "Resources", "type": "[]AlterConfigsResourceResponse", "versions": "0+", "about": "The responses for each resource.", "fields": [
>     { "name": "ErrorCode", "type": "int16", "versions": "0+", "about": "The resource error code." },
>     { "name": "ErrorMessage", "type": "string", "nullableVersions": "0+", "versions": "0+", "about": "The resource error message, or null if there was no error." },
>     { "name": "ResourceType", "type": "int8", "versions": "0+", "about": "The resource type." },
>     { "name": "ResourceName", "type": "string", "versions": "0+", "about": "The resource name." }
> ]}{code}
>  
> IncrementalAlterConfigsResponse:
>  
> {code:java}
> { "name": "responses", "type": "[]AlterConfigsResourceResult", "versions": "0+", "about": "The responses for each resource.", "fields": [
>     { "name": "ErrorCode", "type": "int16", "versions": "0+", "about": "The resource error code." },
>     { "name": "ErrorMessage", "type": "string", "nullableVersions": "0+", "versions": "0+", "about": "The resource error message, or null if there was no error." },
>     { "name": "ResourceType", "type": "int8", "versions": "0+", "about": "The resource type." },
>     { "name": "ResourceName", "type": "string", "versions": "0+", "about": "The resource name." }
> ]}
> {code}
> We should change the field in IncrementalAlterConfigsResponse to be consistent with AlterConfigsResponse.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)