[jira] [Commented] (AIRAVATA-2163) optimize credential store data models

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRAVATA-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569813#comment-15569813 ] 

ASF GitHub Bot commented on AIRAVATA-2163:
------------------------------------------

Github user anujbhan commented on the issue:

    https://github.com/apache/airavata/pull/54
  
    @shamrath,
    
    Here is the follow up JIRA : https://issues.apache.org/jira/browse/AIRAVATA-2163, and I have moved the credential store thrift file to data-models directory, though the actual data models will be created in credential-store modules directory.


> optimize credential store data models
> -------------------------------------
>
>                 Key: AIRAVATA-2163
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2163
>             Project: Airavata
>          Issue Type: Improvement
>          Components: Airavata API
>         Environment: Development
>            Reporter: Anuj Bhandar
>            Assignee: Anuj Bhandar
>              Labels: GATask
>
> This improvement is based on the following Pull request : https://github.com/apache/airavata/pull/54.
> **Improvements agreed upon :** 
> Followings are few suggestions to improve your pull request.
>     * We can do this in a better way by adding generic API method(to AiravataAPIServer) like "getAllCredentialSummary" instead of adding API method for each credential types eg: "getAllGatewaySSHPubKeysSummary" which will return all the credential summary for that particular gatewayId. You may be able to remove few redundant methods from Airavata API server.
>     * Let's introduced one credential summary struct to all credential types, how we differentiate is we have credential type enum field( SSH, PASSWD, CERT etc ) in the credential summary thrift struct.
>      * Move credential data model thrift file to data model directory and merge credential summary thrift file with it.
>      * Credential stubs still have date fields in generated thrift files, not because your changes, but we need to fix it so remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)