You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2014/03/18 01:45:07 UTC
svn commit: r1578687 - in /httpcomponents:
httpasyncclient/trunk/httpasyncclient/src/main/java-deprecated/org/apache/http/nio/conn/scheme/AsyncSchemeRegistry.java
httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/scheme/SchemeRegistry.java
Author: sebb
Date: Tue Mar 18 00:45:07 2014
New Revision: 1578687
URL: http://svn.apache.org/r1578687
Log:
Fixup comments:
- remind readers not to omit the Locale
- avoid possible false positives when searching for missing Locales
Modified:
httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java-deprecated/org/apache/http/nio/conn/scheme/AsyncSchemeRegistry.java
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/scheme/SchemeRegistry.java
Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java-deprecated/org/apache/http/nio/conn/scheme/AsyncSchemeRegistry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java-deprecated/org/apache/http/nio/conn/scheme/AsyncSchemeRegistry.java?rev=1578687&r1=1578686&r2=1578687&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java-deprecated/org/apache/http/nio/conn/scheme/AsyncSchemeRegistry.java (original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java-deprecated/org/apache/http/nio/conn/scheme/AsyncSchemeRegistry.java Tue Mar 18 00:45:07 2014
@@ -103,7 +103,7 @@ public final class AsyncSchemeRegistry {
}
// leave it to the caller to use the correct name - all lowercase
- //name = name.toLowerCase();
+ //name = name.toLowerCase(Locale.ENGLISH);
final AsyncScheme found = registeredSchemes.get(name);
return found;
}
@@ -141,7 +141,7 @@ public final class AsyncSchemeRegistry {
}
// leave it to the caller to use the correct name - all lowercase
- //name = name.toLowerCase();
+ //name = name.toLowerCase(Locale.ENGLISH);
final AsyncScheme gone = registeredSchemes.remove(name);
return gone;
}
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/scheme/SchemeRegistry.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/scheme/SchemeRegistry.java?rev=1578687&r1=1578686&r2=1578687&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/scheme/SchemeRegistry.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/scheme/SchemeRegistry.java Tue Mar 18 00:45:07 2014
@@ -104,7 +104,7 @@ public final class SchemeRegistry {
public final Scheme get(final String name) {
Args.notNull(name, "Scheme name");
// leave it to the caller to use the correct name - all lowercase
- //name = name.toLowerCase();
+ //name = name.toLowerCase(Locale.ENGLISH);
final Scheme found = registeredSchemes.get(name);
return found;
}
@@ -136,7 +136,7 @@ public final class SchemeRegistry {
public final Scheme unregister(final String name) {
Args.notNull(name, "Scheme name");
// leave it to the caller to use the correct name - all lowercase
- //name = name.toLowerCase();
+ //name = name.toLowerCase(Locale.ENGLISH);
final Scheme gone = registeredSchemes.remove(name);
return gone;
}