[GitHub] [nifi] joewitt commented on a diff in pull request #6993: NIFI-11231 Stateless NiFi sensitive parameter context support

["joewitt (via GitHub)" <gi...@apache.org>]

joewitt commented on code in PR #6993:
URL: https://github.com/apache/nifi/pull/6993#discussion_r1128464815


##########
nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/engine/StatelessFlowManager.java:
##########
@@ -270,10 +271,9 @@ public FlowFileQueue createFlowFileQueue(final LoadBalanceStrategy loadBalanceSt
     public ReportingTaskNode createReportingTask(final String type, final String id, final BundleCoordinate bundleCoordinate, final Set<URL> additionalUrls, final boolean firstTimeAdded,
                                                  final boolean register, final String classloaderIsolationKey) {
 
-        if (type == null || id == null || bundleCoordinate == null) {

Review Comment:
   With this removal will the log/exception information still be as specific as it was?  The code is clearly cleaner but we go backwards in communicating intent.  Am i reading that right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org