You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/07/30 19:50:45 UTC

[GitHub] [knox] risdenk opened a new pull request #366: KNOX-2434 - Knox should fallback to JDK default keystore/truststore type instead of hardcoding JKS

risdenk opened a new pull request #366:
URL: https://github.com/apache/knox/pull/366


   ## What changes were proposed in this pull request?
   
   Replace hardcoded `JKS` with `KeyStore.getDefaultType()`
   
   ## How was this patch tested?
   
   * `mvn -U -T.75C clean verify -Ppackage,release -Dshellcheck`
   * Check that this fixes FIPS crypto when default keystore configured at JDK level


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] risdenk merged pull request #366: KNOX-2434 - Knox should fallback to JDK default keystore/truststore type instead of hardcoding JKS

Posted by GitBox <gi...@apache.org>.
risdenk merged pull request #366:
URL: https://github.com/apache/knox/pull/366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] risdenk commented on pull request #366: KNOX-2434 - Knox should fallback to JDK default keystore/truststore type instead of hardcoding JKS

Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #366:
URL: https://github.com/apache/knox/pull/366#issuecomment-666647357


   I'm still working on this - just want to make sure it gets a few CI runs through different JDK versions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org