You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/11/20 21:33:58 UTC
[PR] [MRESOLVER-440] Clean up transport names [maven-resolver]
cstamas opened a new pull request, #375:
URL: https://github.com/apache/maven-resolver/pull/375
---
https://issues.apache.org/jira/browse/MRESOLVER-440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-440] Clean up transport names [maven-resolver]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #375:
URL: https://github.com/apache/maven-resolver/pull/375#discussion_r1400485917
##########
maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/HttpTransporter.java:
##########
@@ -106,16 +106,16 @@
*/
final class HttpTransporter extends AbstractTransporter {
- static final String USE_SYSTEM_PROPERTIES = "aether.connector.http.useSystemProperties";
+ static final String USE_SYSTEM_PROPERTIES = "aether.transport.apache.useSystemProperties";
- static final String HTTP_RETRY_HANDLER_NAME = "aether.connector.http.retryHandler.name";
+ static final String HTTP_RETRY_HANDLER_NAME = "aether.transport.apache.retryHandler.name";
Review Comment:
Why not use the prefixes from `ConfigProperties`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-440] Clean up transport names [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #375:
URL: https://github.com/apache/maven-resolver/pull/375#discussion_r1400547881
##########
maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/HttpTransporter.java:
##########
@@ -106,16 +106,16 @@
*/
final class HttpTransporter extends AbstractTransporter {
- static final String USE_SYSTEM_PROPERTIES = "aether.connector.http.useSystemProperties";
+ static final String USE_SYSTEM_PROPERTIES = "aether.transport.apache.useSystemProperties";
- static final String HTTP_RETRY_HANDLER_NAME = "aether.connector.http.retryHandler.name";
+ static final String HTTP_RETRY_HANDLER_NAME = "aether.transport.apache.retryHandler.name";
Review Comment:
+1 yes, that bothered me as well, will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-440] Clean up transport names and config keys [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #375:
URL: https://github.com/apache/maven-resolver/pull/375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-440] Clean up transport names [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #375:
URL: https://github.com/apache/maven-resolver/pull/375#issuecomment-1819841065
Doco is not yet updated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org