You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/06/02 19:03:00 UTC
[jira] [Work logged] (HIVE-23462) Add option to rewrite NTILE to
sketch functions
[ https://issues.apache.org/jira/browse/HIVE-23462?focusedWorklogId=440395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440395 ]
ASF GitHub Bot logged work on HIVE-23462:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/20 19:02
Start Date: 02/Jun/20 19:02
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1031:
URL: https://github.com/apache/hive/pull/1031#discussion_r434110907
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java
##########
@@ -235,12 +232,21 @@ public String getFunctionName() {
return Optional.empty();
} else {
JavaTypeFactoryImpl typeFactory = new JavaTypeFactoryImpl(new HiveTypeSystemImpl());
+ Type type = returnType;
+ if (type instanceof ParameterizedType) {
+ ParameterizedType parameterizedType = (ParameterizedType) type;
+ if (parameterizedType.getRawType() == List.class) {
+ final RelDataType componentRelType = typeFactory.createType(parameterizedType.getActualTypeArguments()[0]);
+ return Optional
+ .of(typeFactory.createArrayType(typeFactory.createTypeWithNullability(componentRelType, true), -1));
+ }
Review comment:
idea was to leave "typeFactory" to handle it - although it will return something - but it will not work properly
returned `Optional.empty()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 440395)
Time Spent: 1h 40m (was: 1.5h)
> Add option to rewrite NTILE to sketch functions
> -----------------------------------------------
>
> Key: HIVE-23462
> URL: https://issues.apache.org/jira/browse/HIVE-23462
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23462.01.patch, HIVE-23462.02.patch, HIVE-23462.03.patch, HIVE-23462.04.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)