You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/16 09:47:34 UTC

[GitHub] [cloudstack] ravening commented on pull request #4396: Show network name in exception message

ravening commented on pull request #4396:
URL: https://github.com/apache/cloudstack/pull/4396#issuecomment-709944933


   > Thanks for the PR @ravening.
   > 
   > I am **+1** on adding the network's name on exception. I did not add a _looks good_ for this PR in respect to Daan's comment.
   
   @GabrielBrascher Daan was mentioning about networkmodel retuning a null rather than network name being null. So i think this should be fine and no need for extra if check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org