You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/07 05:19:09 UTC
[GitHub] [incubator-doris] ZhangYu0123 opened a new pull request #4282: Fix be crash caused by decimal to date
ZhangYu0123 opened a new pull request #4282:
URL: https://github.com/apache/incubator-doris/pull/4282
## Proposed changes
Fix be crash caused by cast decimal to date. A be crashed bug caused by Unable to find. _ZN5doris18DecimalV2Operators16cast_to_date_val.
also see #4281
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on #ISSUE, and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4282: Fix be crash caused by decimal to date
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4282:
URL: https://github.com/apache/incubator-doris/pull/4282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4282: Fix be crash caused by decimal to date
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #4282:
URL: https://github.com/apache/incubator-doris/pull/4282#discussion_r466837217
##########
File path: be/src/exprs/decimalv2_operators.cpp
##########
@@ -147,6 +147,22 @@ DateTimeVal DecimalV2Operators::cast_to_datetime_val(
return result;
}
+DateTimeVal DecimalV2Operators::cast_to_date_val(
+ FunctionContext* context, const DecimalV2Val& val) {
+ if (val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DecimalV2Value& dv = DecimalV2Value::from_decimal_val(val);
Review comment:
What is the meaning of this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4282: Fix be crash caused by decimal to date
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #4282:
URL: https://github.com/apache/incubator-doris/pull/4282#discussion_r466837217
##########
File path: be/src/exprs/decimalv2_operators.cpp
##########
@@ -147,6 +147,22 @@ DateTimeVal DecimalV2Operators::cast_to_datetime_val(
return result;
}
+DateTimeVal DecimalV2Operators::cast_to_date_val(
+ FunctionContext* context, const DecimalV2Val& val) {
+ if (val.is_null) {
+ return DateTimeVal::null();
+ }
+ const DecimalV2Value& dv = DecimalV2Value::from_decimal_val(val);
Review comment:
what does this line mean
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org