You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ri...@apache.org on 2026/08/06 13:59:41 UTC
(superset) branch master updated: docs: scope AI pre-commit checks to changed files, to align with ci's pre-commit checks (#42835)
This is an automated email from the ASF dual-hosted git repository.
richardfogaca pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new ea8fa58158a docs: scope AI pre-commit checks to changed files, to align with ci's pre-commit checks (#42835)
ea8fa58158a is described below
commit ea8fa58158a9a3b321d1d35a36e2452137d06d8c
Author: Mike Bridge <mi...@preset.io>
AuthorDate: Thu Aug 6 14:59:33 2026 +0100
docs: scope AI pre-commit checks to changed files, to align with ci's pre-commit checks (#42835)
Co-authored-by: Mike Bridge <mi...@ext.preset.io>
---
AGENTS.md | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/AGENTS.md b/AGENTS.md
index 00c35cc582d..67ff1e4c951 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -2,22 +2,29 @@
Apache Superset is a data visualization platform with Flask/Python backend and React/TypeScript frontend.
-## ⚠️ CRITICAL: Always Run Pre-commit Before Pushing
+## Run Pre-commit Before Pushing
-**ALWAYS run `pre-commit run --all-files` before pushing commits.** CI will fail if pre-commit checks don't pass. This is non-negotiable.
+Always run pre-commit against the files changed by the current branch before
+pushing. This matches CI and keeps unrelated failures already present on
+`master` from blocking otherwise independent work.
```bash
# Stage your changes first
git add .
-# Run pre-commit on all files
-pre-commit run --all-files
+# Run pre-commit on staged files
+pre-commit run
# If there are auto-fixes, stage them and commit
git add .
git commit --amend # or new commit
```
+Use `pre-commit run --all-files` when auditing or repairing the repository-wide
+baseline. If that check finds failures in files untouched by the current branch,
+fix them in a separate branch rather than adding unrelated changes to the
+current pull request.
+
Common pre-commit failures:
- **Formatting** - black, oxfmt, eslint will auto-fix
- **Type errors** - mypy failures need manual fixes