You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/05/26 21:12:00 UTC
[jira] [Commented] (CASSANDRA-16696) pylib requirements.txt should
demand six >=1.12.0 rather than 0.12.0
[ https://issues.apache.org/jira/browse/CASSANDRA-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352079#comment-17352079 ]
Ekaterina Dimitrova commented on CASSANDRA-16696:
-------------------------------------------------
I think six is added only in 4.0 and trunk because we need it for compatibility python2-python3. As we don't support python 3 in the previous versions, we don't need it.
> pylib requirements.txt should demand six >=1.12.0 rather than 0.12.0
> --------------------------------------------------------------------
>
> Key: CASSANDRA-16696
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16696
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
> Reporter: Tomasz Lasica
> Assignee: Tomasz Lasica
> Priority: Low
> Fix For: 4.0-rc, 4.0.x
>
>
> In 4.0 min six version is explicitly specified here
> [https://github.com/apache/cassandra/blob/6c8ab5b6b41830ac0d0ee381a7669b06ffd5b43a/pylib/requirements.txt#L5]
> but it is probably a typo: \{{ six>=0.12.0 }}
> and should be {{>=1.12.0}}, version that ensures that "ensure_text" is present:
> see six PR: [https://github.com/benjaminp/six/pull/204]
> It can lead to {{import}} problems with pylib and in effect to problems with the cqlsh tests.
> Proposed fix:
> # request six>=1.12.0 in pylib requirements.txt on all C* branches
> # request six>=1.12.0 in dtest requirements.txt
>
> C* versions before 4.0 does not specify six version at all, which I suspect can be also improved.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org