You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by johnament <gi...@git.apache.org> on 2016/11/16 03:19:45 UTC

[GitHub] cxf pull request #199: CXF-7133 Clean up how default app is loaded and avoid...

GitHub user johnament opened a pull request:

    https://github.com/apache/cxf/pull/199

    CXF-7133 Clean up how default app is loaded and avoid extra XML confi\u2026

    \u2026guration.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnament/cxf CXF-7133-default-app

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit 1c21a8e1b8db2c03e1a20108085a9ba4ef939f5e
Author: John D. Ament <jo...@apache.org>
Date:   2016-11-16T03:16:36Z

    CXF-7133 Clean up how default app is loaded and avoid extra XML configuration.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf pull request #199: CXF-7133 Clean up how default app is loaded and avoid...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cxf/pull/199


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf pull request #199: CXF-7133 Clean up how default app is loaded and avoid...

Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/cxf/pull/199#discussion_r88162864
  
    --- Diff: integration/cdi/src/main/resources/META-INF/beans.xml ---
    @@ -2,7 +2,4 @@
     <beans xmlns="http://java.sun.com/xml/ns/javaee"
     	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
     	xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://jboss.org/schema/cdi/beans_1_1.xsd">
    -	<scan>
    --- End diff --
    
    Having this config here makes shaded JARs hard to deal with in CXF.  CDI has this feature built in to ignore the bean, which works better IMHO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---