You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/01/12 18:46:56 UTC
Re: Review Request 42182: Fixed check thereby allowing HTTP executors
to reconnect.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 5:46 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Modified summary.
Summary (updated)
-----------------
Fixed check thereby allowing HTTP executors to reconnect.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
Previously, we used to return a `ServiceUnavailable` when slave was recovering. However, we only need to do so, for all other calls and let `Subscribe` pass through.
Diffs
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Allowed `Subscribe` Calls to pass through
when agent is recovering.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:56 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
removed attached bug.
Repository: mesos
Description
-------
See Summary.
Diffs
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Allowed `Subscribe` Calls to pass through
when agent is recovering.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:51 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated summary.
Summary (updated)
-----------------
Allowed `Subscribe` Calls to pass through when agent is recovering.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description (updated)
-------
See Summary.
Diffs
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Removed recovery checks in slave/http.cpp.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:49 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated summary.
Summary (updated)
-----------------
Removed recovery checks in slave/http.cpp.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
Removed recovery checks in slave/http.cpp
Diffs
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Removed recovery checks in slave/http.cpp
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:48 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Offline review comment from Vinod.
Summary (updated)
-----------------
Removed recovery checks in slave/http.cpp
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description (updated)
-------
Removed recovery checks in slave/http.cpp
Diffs (updated)
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Fixed check thereby allowing HTTP executors
to reconnect.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:29 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Update Depends on. This should go in 0.27.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
Previously, we used to return a `ServiceUnavailable` when slave was recovering. However, we only need to do so, for all other calls and let `Subscribe` pass through.
Diffs
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Fixed check thereby allowing HTTP executors
to reconnect.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 5:36 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Fixed a missing condition check for `Subscribe`
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
Previously, we used to return a `ServiceUnavailable` when slave was recovering. However, we only need to do so, for all other calls and let `Subscribe` pass through.
Diffs (updated)
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Fixed check thereby allowing HTTP executors
to reconnect.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/#review114645
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 15, 2016, 2:30 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42182/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 2:30 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we used to return a `ServiceUnavailable` when slave was recovering. However, we only need to do so, for all other calls and let `Subscribe` pass through.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/42182/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 42182: Fixed check thereby allowing HTTP executors
to reconnect.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 2:30 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comment
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
Previously, we used to return a `ServiceUnavailable` when slave was recovering. However, we only need to do so, for all other calls and let `Subscribe` pass through.
Diffs (updated)
-----
src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/42182/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 42182: Fixed check thereby allowing HTTP executors
to reconnect.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42182/#review114625
-----------------------------------------------------------
src/slave/http.cpp (lines 267 - 272)
<https://reviews.apache.org/r/42182/#comment175479>
you can just pull this down to #290 and remove the call type check in the if statement.
- Vinod Kone
On Jan. 12, 2016, 5:46 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42182/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 5:46 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we used to return a `ServiceUnavailable` when slave was recovering. However, we only need to do so, for all other calls and let `Subscribe` pass through.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 66abdcb12d670bc4b77fa5b5f8ce35220f9aa698
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/42182/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>