You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/05/22 16:50:45 UTC
[GitHub] [superset] justinpark opened a new pull request, #24177: fix(explore): rendering regression on standalone
justinpark opened a new pull request, #24177:
URL: https://github.com/apache/superset/pull/24177
### SUMMARY
This commit fixes the rendering regression in standalone mode(and reports) by [#23778](https://github.com/apache/superset/pull/23778)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
(Render a chart in a standalone)
Before:
(Empty screen)
### TESTING INSTRUCTIONS
Go to any chart explore link
Add `&standalone=true` parameter at the end
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #24177: fix(explore): rendering regression on standalone
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #24177:
URL: https://github.com/apache/superset/pull/24177#issuecomment-1559969127
🏷️ preset:2023.21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #24177: fix(explore): rendering regression on standalone
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #24177:
URL: https://github.com/apache/superset/pull/24177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24177: fix(explore): rendering regression on standalone
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24177:
URL: https://github.com/apache/superset/pull/24177#issuecomment-1557677404
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24177?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24177](https://app.codecov.io/gh/apache/superset/pull/24177?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8113d88) into [master](https://app.codecov.io/gh/apache/superset/commit/455e23b01432800e2b29e5424cf0a840714461f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (455e23b) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 8113d88 differs from pull request most recent head 6157d15. Consider uploading reports for the commit 6157d15 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24177 +/- ##
==========================================
+ Coverage 68.27% 68.28% +0.01%
==========================================
Files 1955 1955
Lines 75451 75451
Branches 8215 8215
==========================================
+ Hits 51511 51522 +11
+ Misses 21834 21825 -9
+ Partials 2106 2104 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.70% <100.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...src/explore/components/ExploreChartPanel/index.jsx](https://app.codecov.io/gh/apache/superset/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC9pbmRleC5qc3g=) | `77.63% <100.00%> (+7.89%)` | :arrow_up: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24177/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org