[GitHub] [airflow] SamWheating commented on a change in pull request #22535: Pass X-Trino-Client-Info in trino hook

[GitBox <gi...@apache.org>]

SamWheating commented on a change in pull request #22535:
URL: https://github.com/apache/airflow/pull/22535#discussion_r835797358



##########
File path: airflow/providers/trino/hooks/trino.py
##########
@@ -82,12 +111,15 @@ def get_conn(self) -> Connection:
                 delegate=_boolify(extra.get('kerberos__delegate', False)),
                 ca_bundle=extra.get('kerberos__ca_bundle'),
             )
+
+        http_headers = {"X-Trino-Client-Info": generate_trino_client_info()}

Review comment:
       The `X-Trino` header prefix has been configurable since Trino was rebranded from PrestoSQL:
   
   https://trino.io/docs/current/admin/properties-general.html?highlight=headers#protocol-v1-alternate-header-name
   
   Do you think that its worth supporting the same kind of override here? If a user has overriden the default header prefix then this hardcoded value of `X-Trino-Client-Info` won't get properly picked up or displayed in the Trino UI.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org