You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/07/26 19:01:56 UTC
Review Request 68065: Enabled garbage collection of terminated tasks'
metadata.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68065/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Qian Zhang.
Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947
Repository: mesos
Description
-------
This commit schedules tasks' metadata, whose terminal statuses have been
acknowledged, for garbage collection. GC occurs according to the
existing GC policy (controlled by agent flags --gc_delay and
--gc_disk_headroom). This change helps mitigate potential accumulation
of directories for long-lived, multi-task executors, such as the
default executor.
Diffs
-----
src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591
Diff: https://reviews.apache.org/r/68065/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 68065: Enabled garbage collection of terminated
tasks' metadata.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68065/
-----------------------------------------------------------
(Updated Aug. 22, 2018, 11:33 a.m.)
Review request for mesos, Gilbert Song and Qian Zhang.
Changes
-------
Rebase.
Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947
Repository: mesos
Description
-------
This commit schedules tasks' metadata, whose terminal statuses have been
acknowledged, for garbage collection. GC occurs according to the
existing GC policy (controlled by agent flags --gc_delay and
--gc_disk_headroom). This change helps mitigate potential accumulation
of directories for long-lived, multi-task executors, such as the
default executor.
Diffs (updated)
-----
src/slave/slave.cpp 679394a549cdfe84d64a102164c8652ad96f1eb2
Diff: https://reviews.apache.org/r/68065/diff/2/
Changes: https://reviews.apache.org/r/68065/diff/1-2/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 68065: Enabled garbage collection of terminated
tasks' metadata.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68065/#review206582
-----------------------------------------------------------
Ship it!
- Qian Zhang
On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68065/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 3:01 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit schedules tasks' metadata, whose terminal statuses have been
> acknowledged, for garbage collection. GC occurs according to the
> existing GC policy (controlled by agent flags --gc_delay and
> --gc_disk_headroom). This change helps mitigate potential accumulation
> of directories for long-lived, multi-task executors, such as the
> default executor.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591
>
>
> Diff: https://reviews.apache.org/r/68065/diff/1/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>