You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/02/06 15:38:59 UTC
[GitHub] [incubator-datasketches-cpp] alexandre-p opened a new pull request
#84: Add missing include in CPC compression test
alexandre-p opened a new pull request #84: Add missing include in CPC compression test
URL: https://github.com/apache/incubator-datasketches-cpp/pull/84
Hello,
I ran into an issue when running the tests for the library. It seems just a simple include missing from a test.
```...
[ 54%] Building CXX object cpc/test/CMakeFiles/cpc_test.dir/compression_test.cpp.o
/data/fork-datasketch/cpc/test/compression_test.cpp: In member function ‘void datasketches::compression_test::compress_and_uncompress_pairs()’:
/data/fork-datasketch/cpc/test/compression_test.cpp:51:5: error: ‘sort’ is not a member of ‘std’
std::sort(pairArray, &pairArray[N]);
^
cpc/test/CMakeFiles/cpc_test.dir/build.make:88: recipe for target 'cpc/test/CMakeFiles/cpc_test.dir/compression_test.cpp.o' failed
make[2]: *** [cpc/test/CMakeFiles/cpc_test.dir/compression_test.cpp.o] Error 1
CMakeFiles/Makefile2:285: recipe for target 'cpc/test/CMakeFiles/cpc_test.dir/all' failed
make[1]: *** [cpc/test/CMakeFiles/cpc_test.dir/all] Error 2
Makefile:140: recipe for target 'all' failed```
Note that I get this issue on my local machine (Ubuntu, gcc 5.4) but it works in a Docker with gcc 4.8.5.
This PR should fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov merged pull request
#84: Add missing include in CPC compression test
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #84: Add missing include in CPC compression test
URL: https://github.com/apache/incubator-datasketches-cpp/pull/84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov commented on issue
#84: Add missing include in CPC compression test
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #84: Add missing include in CPC compression test
URL: https://github.com/apache/incubator-datasketches-cpp/pull/84#issuecomment-583023197
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org