Re: [PR] HIVE-27728: Renaming partition from legacy tables should move the par… [hive]

["saihemanth-cloudera (via GitHub)" <gi...@apache.org>]

saihemanth-cloudera commented on code in PR #4752:
URL: https://github.com/apache/hive/pull/4752#discussion_r1343165808


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:
##########
@@ -679,7 +679,9 @@ public Partition alterPartition(RawStore msdb, Warehouse wh, String catName, Str
       // 1) partition SD Location
       // 2) partition column stats if there are any because of part_name field in HMS table PART_COL_STATS
       // 3) rename the partition directory if it is not an external table
-      if (!tbl.getTableType().equals(TableType.EXTERNAL_TABLE.toString())) {
+      boolean shouldMoveData = !(MetaStoreUtils.isExternalTable(tbl) &&
+          !MetaStoreUtils.isPropertyTrue(tbl.getParameters(), "TRANSLATED_TO_EXTERNAL"));

Review Comment:
   Do we need to relocate the partitioned data of all the externally translated tables or only the ones that are translated with the config "hive.create.as.external.legacy"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org