You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/15 20:31:01 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #13387: ARROW-14771: [C++] Export Protobuf symbol table
lidavidm opened a new pull request, #13387:
URL: https://github.com/apache/arrow/pull/13387
This makes it possible to build applications that have Protobuf dependencies on Flight.proto and link to Arrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13387: ARROW-14771: [C++] Export Protobuf symbol table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13387:
URL: https://github.com/apache/arrow/pull/13387#issuecomment-1156901418
https://issues.apache.org/jira/browse/ARROW-14771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13387: ARROW-14771: [C++] Export Protobuf symbol table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13387:
URL: https://github.com/apache/arrow/pull/13387#issuecomment-1156901445
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13387: ARROW-14771: [C++] Export Protobuf symbol table
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13387:
URL: https://github.com/apache/arrow/pull/13387#issuecomment-1156901188
Demo: https://github.com/lidavidm/arrow-14771-demo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a diff in pull request #13387: ARROW-14771: [C++] Export Protobuf symbol table
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on code in PR #13387:
URL: https://github.com/apache/arrow/pull/13387#discussion_r898655819
##########
cpp/src/arrow/symbols.map:
##########
@@ -33,6 +33,8 @@
# Also export C-level helpers
arrow_*;
pyarrow_*;
+ # ARROW-14771: export Protobuf symbol table
+ descriptor_table_Flight_2eproto;
Review Comment:
Is this symbol created by protobuf?
Given `2e` is ascii of `.`, guess it might mean descriptor table of file `Flight.proto`, looks the naming should be stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #13387: ARROW-14771: [C++] Export Protobuf symbol table
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #13387:
URL: https://github.com/apache/arrow/pull/13387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13387: ARROW-14771: [C++] Export Protobuf symbol table
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13387:
URL: https://github.com/apache/arrow/pull/13387#discussion_r898992706
##########
cpp/src/arrow/symbols.map:
##########
@@ -33,6 +33,8 @@
# Also export C-level helpers
arrow_*;
pyarrow_*;
+ # ARROW-14771: export Protobuf symbol table
+ descriptor_table_Flight_2eproto;
Review Comment:
Yes, it's an internal symbol. I don't like dealing with implementation details like this, but hopefully this is reasonably stable, and it appears Protobuf relies on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org