You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/07/17 11:14:33 UTC

[Apache Bloodhound] #146: In-place editing of objects

#146: In-place editing of objects
-------------------------+-----------------------
 Reporter:  jdreimann    |      Owner:  nobody
     Type:  enhancement  |     Status:  new
 Priority:  major        |  Milestone:  Release 2
Component:  dashboard    |    Version:
 Keywords:               |
-------------------------+-----------------------
 Objects such as Tickets, Milestones, Versions and Products should be
 editable in place, rather than via a separate 'modify' or 'change'
 section.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------
Changes (by jdreimann):

 * priority:  major => critical


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by olemis):

 btw ... /me finishing . Will let you know soon . Later today .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:35>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------
Changes (by olemis):

 * status:  assigned => accepted
 * owner:   => olemis


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:26>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by gjm):

 Note: t146/t146_r1418195_scrollspy_btn.diff committed as part of #295

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:31>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 After a lot of fighting against external js libs , I think I won the first
 battle and managed to implement in place editor for ticket checkbox fields
 . I have refreshed patches accordingly and updated application order
 mentioned before in comment:14 . Only frontend has been improved so it's
 still work in progress at the moment , as the backend still needs to be
 developed .

 New features described below .

 ==== Dashboard plugin ====

   - [http://github.com/tdreyno/iphone-style-checkboxes iPhone style
 checkboxes js library] added .
     ''MIT license''
   - Modifications for ''jEditable'' .
   - Architecture of Bloodhound editable data API modified to support
 references to functions
     in `data-edit*` attributes (by using `javascript:` prefix) .
   - iPhone checkbox jEditable type ... some minor enhancements still
 needed .

 ==== Theme plugin ====

   - Enhanced code to load values for select and checkbox fields
   - Changes for iPhone checkbox editable type propagated to render these
 controls in
     ticket view .

 This is closer to completion now ... at least the frontend is almost ready
 . This is what iPhone checkboxes look like . Feedback is welcome .

 [[Image(bh_theme_x_70_ticket_inplace_iphone_cb.png, width=600)]]

 Only editors for radio ticket type are missing ... coming soon .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:16>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by jdreimann):

 Am I right in thinking that the licensing question regarding jEditable
 [http://mail-archives.apache.org/mod_mbox/incubator-bloodhound-
 dev/201203.mbox/%3C4F61C392.7060403%40wandisco.com%3E raised by Gary
 previously] hasn't been resolved yet?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 Patch order updated after [comment:12:ticket:203 splitting original patch
 for #203]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:15>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by olemis):

 Replying to [comment:33 jdreimann]:
 > Replying to [comment:32 olemis]:
 > > [...] Anyway , after all this editable state will look like shown
 below :
 > >
 > > [img]
 >
 > I assume the look of the drop down button and the red background for
 selected radio button/checkbox are browser dependent?

 Browser dependent. Would be nice to have consistent look and feel across
 different platforms .

 > Just checking to make sure it isn't styled that way.

 ;)

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:34>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by jdreimann):

 Replying to [comment:28 gjm]:
 > Replying to [comment:27 olemis]:
 > >   1. What happens after ticket enters editable state ?
 > after edits we clearly need a Submit Changes button and a cancel button.
 Submission and cancelling probably imply a change back to the non-editable
 state so perhaps we need a revert button that only resets the fields as
 well?

 I think Submit button and a Cancel button (with `btn-link` class to show
 it's a secondary action) will be enough.

 > >   2. What about workflow actions now that Modify Ticket section is
 gone?
 > We still need the modify ticket area for that until there is an
 alternative solution for workflow.

 What stops us from workflow simply being a dropdown of options? `review,
 resolve, info request` etc.

 > >   3. Should description, keywords and summary be put into editable
 > >      as well (... IMO they should , I'm just looking for
 > >      confirmation ...) ?
 > Yes.. until otherwise noted, we will require that.
 +1

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:29>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by olemis):

 The new approach to in-place editing in ticket view is not compatible with
 jEditable afaics . Hence I've built everything from scratch . Attached
 patches against theme plugin add the following features :

   1. Enhanced ticket fields list updated according to responsive mockups
   2. Enhanced scroll spy nav bar implemented with Bootstrap button groups
      like sketched in responsive mockups
   3. Modify ticket section is gone
   4. On clicking Modify Ticket button in scroll spy nav bar , ticket view
      enters editable state (suggested by jure)

 Patches should be applied against bloodhound_theme @ r1418195 in the
 following order :

 {{{
 #!sh

 $ hg qapplied
 t146/t146_r1418195_scrollspy_btn.diff
 t146/t146_r1418195_ticket_header.diff
 t146/t146_r1418195_inplace_ticket_fields.diff

 }}}

 Issues found so far :

   1. In editable state scroll spy does not activate nav item accurately.
      This happens because heights are different (e.g. wiki toolbar added
      on top of some textarea elements , etc ...) to the values when
      scroll spy was installed.

 ... /me figuring out how to fix .

 After all this ticket view will look like shown below in view mode ...

 [[Image(bh_theme_x_86_ticket_responsive_view_state.png, width=600)]]

 ... and in editable mode ...

 [[Image(bh_theme_x_87_ticket_responsive_edit_state.png, width=600)]]

 Still there are many open questions :

   1. What happens after ticket enters editable state ?
   2. What about workflow actions now that Modify Ticket section is gone?
   3. Should description, keywords and summary be put into editable
      as well (... IMO they should , I'm just looking for
      confirmation ...) ?

 Feedback is welcome .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:27>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  gjm
      Type:  enhancement  |     Status:  review
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by gjm):

 This looks pretty good for committing. There are a few issues left but I
 think it is probably better to commit this work and raise new tickets for
 any required tweaks.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:39>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by jdreimann):

 Replying to [comment:4 olemis]:
 > [...] If ''Modify'' / ''Change'' will disappear then what is supposed to
 happen when ''Javascript'' is disabled ?

 How about they stay until Javascript removes them? Or what would you
 suggest?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  gjm
      Type:  enhancement  |     Status:  closed
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:  fixed        |   Keywords:  inplace bheditable
--------------------------+--------------------------------
Changes (by gjm):

 * status:  review => closed
 * resolution:   => fixed


Comment:

 Calling this complete - further enhancements in new tickets.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:42>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 The way I see it we have three options :

   1. Use ''jEditable'' except auto-grow plugin.
     - We'd have to decide whether this is a crucial feature
   2. Use ''jEditable'' and implement a replacement
      for auto-grow functionality
     - We'd have to assess whether this is a feasible task
   3. Do not use ''jEditable'' at all, and choose
      a similar library
     - So far I have not found something as complete
       as ''jEditable'' , especially supporting integrate of
       the editor with server-side WikiFormatting renderer .
     - I'm not an expert and I have not exhausted all
       the possibilities

 Beyond that , there is something else we need to discuss . If ''Modify'' /
 ''Change'' will disappear then what is supposed to happen when
 ''Javascript'' is disabled ?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  jdreimann
      Type:  enhancement  |     Status:  review
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------
Changes (by olemis):

 * owner:  olemis => jdreimann
 * status:  accepted => review


Comment:

 After comment:32 I have refreshed previous patches and attached new patch
 implementing ticket submission . Patch order in comment:27 updated
 accordingly . Other minor enhancements have been added consisting of :

 summary:     BH Theme #146 : In-place submit form . Sticky panel relocated
 and other minor changes
 summary:     BH Theme #146 : Discard inline modifications
 summary:     BH Theme #146 : Tooltips for workflow actions
 summary:     BH Theme #146 : Edit mode not reentrant plus .editing =>
 .edit-active
 summary:     BH Theme #146 : Workflow drop down visible on affix
 summary:     BH Theme #146 : Use JS templates to render in-place submit
 controls
 summary:     BH Theme #146 : Ticket in-plece submit controls

 Anyway , after all this editable state will look like shown below :

 [[Image(bh_theme_x_91_ticket_responsive_submit_workflow.png, width=600)]]

 I'm forwarding ticket for further review of workflow drop down menu from a
 UI/UX perspective .

 A few comments on that subject .

   1. Update / cancel buttons placed in sticky panel so that they'll
     always be handy in edit mode
   2. Update button highlighted (`btn-primary`) because it has to
     be that relevant on edit mode . Otherwise it's hard to notice
     since it shows up out of nowhere .
   3. Reduced space => reduced visibility of action hints (i.e. tooltips)
   4. Selected workflow action appended to ''Update'' label to allow
     one click edits . Otherwise it is obscured the intentions and
 difficult
     to figure out what's gonna happen with ticket in the end .

 Beyond this , there should be some room for enhancements . That's sure . I
 suggest to tackle improvements on separate tickets .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:36>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 So what shall we do about this ticket ?
 Is it ok to use ''jEditable'' for this ?
 If the decision is to move forward with another library then which one ?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 I have refreshed one of the patches submitted before for dashboard plugin.
 Changes are :

   - Inplace editor for wiki textarea (bhwiki)

 However it's not finished yet , because wiki toolbar is not usable due to
 the fact that editor disappears on clicking the toolbar itself . I guess
 this happens because its outside expected editor area ... but not sure yet
 of how to fix it .

 In my local patch queue repository they have been tested against dashboard
 plugin @ r1386655 after applying them in the following order

 {{{
 #!sh

 $ hg qapplied
 t146/t146_r1386655_jeditable.diff
 t146/t146_r1386655_bheditable.diff

 }}}

 Besides I added a new one for theme plugin mainly modifying ticket view to
 incorporate in-place editors. I tested by applying it on top of patches
 submitted to #203 , #206 and #208 against theme plugin @ r1386655 using my
 local patch queue repository .

 {{{
 #!sh

 $ hg qapplied
 t203/t203_r1386655_wiki_toolbar.diff
 t208/t208_r1386655_inline_ticket_radio.diff
 t206/t206_r1386655_ticket_textarea_fields.diff
 t206/t206_r1386655_ticket_desc_top.diff
 t146/t146_r1386655_inplace_ticket_select.diff

 }}}

 '''Disclaimer''' Like I said before , this is still work in progress .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:
      Type:  enhancement  |     Status:  assigned
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------
Changes (by olemis):

 * status:  needinfo => assigned


Comment:

 Instructions confirmed in [http://mail-archives.apache.org/mod_mbox
 /incubator-bloodhound-dev/201211.mbox/%3cCAKoya91u=peYCkfxXJ4LgZ-
 FUV6yJ5zt-_Q=HCd3yNmrrfgv1A@mail.gmail.com%3e a message] sent to
 bloodhound-dev ML .

 I'll start working on this following suggestions provided by gjm and
 jdreimann .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:25>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 I have attached two patches . The former incorporates jeditable files into
 dashboard plugin . I have detected that the library uses built-in `eval()`
 function to parse [Acronym:JSON JSON] strings rather than safe functions
 e.g. `$.parseJSON()` . That's a potential security hole afaics . What
 shall we do about that ?

 The later patch implements ''Bloodhound'' editable architecture , adds
 default settings to insert submit button plus a new editable type named
 `bhselect` supporting option groups . It is still work in progress (so it
 will be changed in the near future) . However it is offered for the moment
 as a preview of what's been done in this direction . They have been used
 to build preliminary incomplete implementation in ticket view . The
 following screenshot illustrates what it looks like . Feedback is welcome
 .

 [[Image(bh_theme_x_66_ticket_inplace_select.png, width=600)]]

 '''Disclaimer''' Please do not commit any of these yet .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 Replying to [comment:17 jdreimann]:
 > Replying to [comment:16 olemis]:
 > > This is closer to completion now ... at least the frontend is almost
 ready . This is what iPhone checkboxes look like . Feedback is welcome .
 >
 > Where does the requirement for iPhone checkboxes come from? I don't
 remember this being discussed anywhere.

 just a suggestion ...

 > If you want to implement them, please propose that in a separate ticket.
 In this ticket, please focus on enabling inline edits.
 >

 ... so if this is not correct I revert those changes and use plain-old
 checkboxes . No big deal .

 Now I ask , what inplace radio ticket fields editor will look like ?

 > For now I'd appreciate if you would remove them from proposed patches
 because they are inconsistent with the current design and were never
 designed for mouse-operation.

 ok

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:18>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 I have refreshed and uploaded two patches . I've also erased patches
 introducing iPhone style checkboxes from my local patch queue . Hence I've
 also updated [comment:14:ticket:146 patch order] . Main changes are :

   - Use plain old checkboxes
   - Inplace editor for ticket radio fields . Please take a look at image
 below .
     Feedback is welcome

 [[Image(bh_theme_x_71_ticket_inplace_radio.png, width=600)]]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:19>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  gjm
      Type:  enhancement  |     Status:  review
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------
Changes (by jdreimann):

 * owner:  jdreimann => gjm


Comment:

 I assume the textfield next to the Update button is the ticket summary?
 I would change the button style from btn-primary to btn-warning or btn-
 danger for higher contrast, but other than that I'd say +1 to commit this
 so we can actually run it locally and improve on what's built already.
 This ticket has been going on for too long and unwieldy.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:37>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by gjm):

 Replying to [comment:27 olemis]:
 >   1. What happens after ticket enters editable state ?
 after edits we clearly need a Submit Changes button and a cancel button.
 Submission and cancelling probably imply a change back to the non-editable
 state so perhaps we need a revert button that only resets the fields as
 well?
 >   2. What about workflow actions now that Modify Ticket section is gone?
 We still need the modify ticket area for that until there is an
 alternative solution for workflow.
 >   3. Should description, keywords and summary be put into editable
 >      as well (... IMO they should , I'm just looking for
 >      confirmation ...) ?
 Yes.. until otherwise noted, we will require that.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:28>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------
Changes (by olemis):

 * status:  new => accepted
 * owner:  nobody => olemis


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by olemis):

 I have submitted new files to rebase patches against r1420132 . Patch
 order in comment:27 updated accordingly . I have also added a new patch to
 edit special ticket fields , namely description, keywords, summary and
 reporter . At present they will remain in view state if permissions are
 not sufficient . Other minor enhancements have been added like tagging
 editable fields with `data-edit="inplace"` , custom textarea size , etc
 ...

 Anyway , after all this editable state will look like shown below :

 [[Image(bh_theme_x_90_ticket_responsive_edit_all.png, width=600)]]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:32>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by jdreimann):

 Replying to [comment:32 olemis]:
 > [...] Anyway , after all this editable state will look like shown below
 :
 >
 > [[Image(bh_theme_x_90_ticket_responsive_edit_all.png, width=600)]]

 I assume the look of the drop down button and the red background for
 selected radio button/checkbox are browser dependent? Just checking to
 make sure it isn't styled that way.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:33>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 Replying to [comment:5 jdreimann]:
 > Replying to [comment:4 olemis]:
 > > [...] If ''Modify'' / ''Change'' will disappear then what is supposed
 to happen when ''Javascript'' is disabled ?
 >
 > How about they stay until Javascript removes them?

 That's ok afaics.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------
Changes (by olemis):

 * keywords:   => inplace bheditable


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:22>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by jdreimann):

 Replying to [comment:19 olemis]:
 >   Inplace editor for ticket radio fields . Please take a look at image
 below .
 >   Feedback is welcome

 Looks good to me.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:21>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  gjm
      Type:  enhancement  |     Status:  review
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by olemis):

 Replying to [comment:39 gjm]:
 [...]
 > There are a few issues left

 I've detected some potential issues too ... low priority afaics .

 > but I think it is probably better to commit this work and raise new
 tickets for any required tweaks.

 I'm ok with that approach .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:40>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by jdreimann):

 Replying to [comment:12 olemis]:
 > IMO submit button does need to be required for all kinds of text fields
 and
 > [..] there's a need to cancel / undo in place modifications , like is
 the case for text fields .
 Yep, that's what I was trying to say :)
 +1

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  gjm
      Type:  enhancement  |     Status:  review
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by gjm):

 r1427698 applies t146_r1418195_ticket_header.diff

 r1427699 applies t146_r1420132_inplace_ticket_fields.diff

 r1427702 applies t146_r1420132_inplace_ticket_desc.diff

 r1427717 applies t146_r1420132_inplace_ticket_form.diff

 thanks olemis.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:41>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by jdreimann):

 Replying to [comment:16 olemis]:
 > This is closer to completion now ... at least the frontend is almost
 ready . This is what iPhone checkboxes look like . Feedback is welcome .

 Where does the requirement for iPhone checkboxes come from? I don't
 remember this being discussed anywhere. If you want to implement them,
 please propose that in a separate ticket. In this ticket, please focus on
 enabling inline edits.

 For now I'd appreciate if you would remove them from proposed patches
 because they are inconsistent with the current design and were never
 designed for mouse-operation. Not even Apple uses them in their desktop
 software, apart from a handful exceptions.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:17>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by jdreimann):

 Replying to [comment:10 olemis]:
 > The following screenshot illustrates what it looks like . Feedback is
 welcome .

 I assume the button with the check mark is to confirm the selection and
 'commit' it? This should not be required. Part of the case for inline
 editing is that confirmation is only required when
 1. It's difficult (time, effort) or impossible to revert fully.
 1. Automatically saved information would be incomplete.

 An example for 1. is when a ticket is when stuff gets deleted. An example
 for 2. is changing a ticket description, which you probably wouldn't want
 to change for everyone before you're done typing.

 I think we'll get closer to a proper definition by trial and error, but I
 think our default approach should be to not ask for confirmation unless in
 cases of grave danger.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by gjm):

 Replying to [comment:4 olemis]:
 >
 > The way I see it we have three options :
 >
 >   1. Use ''jEditable'' except auto-grow plugin.
 >     - We'd have to decide whether this is a crucial feature

 OK, go with option 1. We can at least see if the autogrow functionality is
 missed

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by olemis):

 Attached patches have to be refreshed after #217 , #223 and especially
 considering [comment:9:ticket:206 enhancements] in ticket fields UI .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:23>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 Replying to [comment:11 jdreimann]:
 > Replying to [comment:10 olemis]:
 > > The following screenshot illustrates what it looks like . Feedback is
 welcome .
 >
 > I assume the button with the check mark is to confirm the selection and
 'commit' it?

 yes

 > This should not be required.

 ok. I'll remove that for select fields .

 > Part of the case for inline editing is that confirmation is only
 required when
 > 1. It's difficult (time, effort) or impossible to revert fully.
 > 1. Automatically saved information would be incomplete.
 >
 > An example for 1. is when a ticket is when stuff gets deleted. An
 example for 2. is changing a ticket description, which you probably
 wouldn't want to change for everyone before you're done typing.
 >

 IMO submit button does need to be required for all kinds of text fields
 (i.e. raw &wiki textarea, raw and wiki text field ) . Consider the case
 when user starts typing but suddenly decides it's all wrong . Hence there
 should be a way to revert in place edits (e.g. Submit + Cancel button ?)

 > I think we'll get closer to a proper definition by trial and error, but
 I think our default approach should be to not ask for confirmation unless
 in cases of grave danger.

 ... and when there's a need to cancel / undo in place modifications , like
 is the case for text fields .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:
      Type:  enhancement  |     Status:  needinfo
  Priority:  critical     |  Milestone:  Release 3
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------
Changes (by olemis):

 * status:  accepted => needinfo
 * owner:  olemis =>


Comment:

 Work on this ticket is suspended until we figure out how in-place editing
 should work . Open discussion's been held in bloodhound-
 dev@incubator.apache.org

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:24>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects (was: In-place editing of objects)

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  major        |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by gjm):

 Replying to [comment:29 jdreimann]:
 > Replying to [comment:28 gjm]:
 > > Replying to [comment:27 olemis]:
 > > >   1. What happens after ticket enters editable state ?
 > > after edits we clearly need a Submit Changes button and a cancel
 button. Submission and cancelling probably imply a change back to the non-
 editable state so perhaps we need a revert button that only resets the
 fields as well?
 >
 > I think Submit button and a Cancel button (with `btn-link` class to show
 it's a secondary action) will be enough.

 Fair enough.. certainly good enough for now

 >
 > > >   2. What about workflow actions now that Modify Ticket section is
 gone?
 > > We still need the modify ticket area for that until there is an
 alternative solution for workflow.
 >
 > What stops us from workflow simply being a dropdown of options? `review,
 resolve, info request` etc.

 I was thinking a similar way but the control is a little more complicated
 in needing a second input to change assignment for some actions. I don't
 know if there would be more cases to take into account with plugins that
 extend the functionality of course.

 > > >   3. Should description, keywords and summary be put into editable
 > > >      as well (... IMO they should , I'm just looking for
 > > >      confirmation ...) ?
 > > Yes.. until otherwise noted, we will require that.
 > +1

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:30>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+--------------------------------
  Reporter:  jdreimann    |      Owner:  gjm
      Type:  enhancement  |     Status:  review
  Priority:  critical     |  Milestone:  Release 4
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:  inplace bheditable
--------------------------+--------------------------------

Comment (by olemis):

 Replying to [comment:37 jdreimann]:
 > I assume the textfield next to the Update button is the ticket summary?

 yes , placeholder = Ticket summary

 > I would change the button style from btn-primary to btn-warning or btn-
 danger for higher contrast,

 fwiw +1 for btn-warning

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:38>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Peter Koželj <pe...@digiverse.si>.
Typo: I actually meant: "... by saving tickets without explicit save
action ..."

On Thu, Oct 4, 2012 at 5:58 PM, Peter Koželj <pe...@digiverse.si> wrote:

> Even if I ignore possible user confusion by saving tickets with explicit
> save action,
> wouldn't this actually trigger multiple ticket change notification and
> create multiple ticket history entries?
>
> Peter
>
> On Thu, Oct 4, 2012 at 5:54 PM, Joachim Dreimann <
> joachim.dreimann@wandisco.com> wrote:
>
>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
>> >> On 03/10/12 20:50, Olemis Lang wrote:
>> >>   - Decide how to notify in-place modifications (verbose vs quiet ,
>> >> configurable ? , ...)
>> >
>> > Does this mean that each change individually updates the ticket on the
>> server? I thought that we would be going with users submitting all changes
>> once they are happy with the new state of the ticket.
>> >
>>
>> I would expect every radio button / drop down change to save immediately,
>> users should only need to confirm textfields or similar where incomplete
>> information would be very likely if we save after every letter or when the
>> box loses focus.
>>
>> Joe
>>
>>
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 10/4/12, Peter Koželj <pe...@digiverse.si> wrote:
> Even if I ignore possible user confusion by saving tickets with explicit
> save action,
> wouldn't this actually trigger multiple ticket change notification and
> create multiple ticket history entries?
>

yes , that's the case . It also happens that e-mail notification is
sent , of course, *IF* we decide these changes should be notified ,
like it happens after applying the patch . That's why I asked
;)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Peter Koželj <pe...@digiverse.si>.
Even if I ignore possible user confusion by saving tickets with explicit
save action,
wouldn't this actually trigger multiple ticket change notification and
create multiple ticket history entries?

Peter

On Thu, Oct 4, 2012 at 5:54 PM, Joachim Dreimann <
joachim.dreimann@wandisco.com> wrote:

> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
> >> On 03/10/12 20:50, Olemis Lang wrote:
> >>   - Decide how to notify in-place modifications (verbose vs quiet ,
> >> configurable ? , ...)
> >
> > Does this mean that each change individually updates the ticket on the
> server? I thought that we would be going with users submitting all changes
> once they are happy with the new state of the ticket.
> >
>
> I would expect every radio button / drop down change to save immediately,
> users should only need to confirm textfields or similar where incomplete
> information would be very likely if we save after every letter or when the
> box loses focus.
>
> Joe
>
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 11/5/12, Jure Zitnik <ju...@digiverse.si> wrote:
> On 11/5/12 12:44 PM, Gary Martin wrote:
>> Individual confirmation on every field? That sounds like the same thing
>> as
>> an immediate save. I think that so far the consensus is that we don't
>> want
>> that.
>
> +1
>
>> I've been using a few developers at apachecon as sounding boards as I am
>> worried that things might be more complicated than necessary. The
>> solution
>> that would seem most efficient would be that all the fields that are
>> editable are considered to be in an editable state already. The problem
>> with this is then how it is made abundantly clear that a field is
>> editable

So far it turns out that we don't need jEditable at all . It seems to
me that we are moving towards an scenario in which existing «Modify
Ticket» is redesigned to look like fields list and then toggle it to
switch back and forth between editable form and initial read only
field / value list .

Did I understand what you mean ?

>>
>> - and it would be nice to see when a field has been edited too.
>>

this introduces some complexities . IMO if edits are canceled
read/only ticket field/value list should be reverted to reflect its
initial state .

>> I am not yet convinced that a button to make all fields editable is the
>> right approach at the moment - it seems like a step you shouldn't need.
>
> I think that the ticket could be shown as read only initially, with the
> scroll spy component being visible from start (I think that was
> discussed in another thread already). As the scroll spy already includes
> the 'Modify ticket' button, clicking that button would enable 'edit
> mode' which would replace ticket fields inline (read only for editable)
> - that is, w/o scrolling to the 'Modify ticket' section. So, I would go
> for one button to enable the 'edit' state and one button for submission.
>
>> Other than that, a submit all changes button would probably work well.
> +1
>

Well this looks like what I mentioned above , isn't it ?

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
Joe,

Interesting point. I am not sure that a separate submit button is a 
particularly good idea so I am not sure why I created point 5. In fact I 
would prefer to encourage users to provide a comment on why they made 
the change but I was hoping to avoid enhancements relating to comments 
in this proposal. I suggest that for now we stick with the current 
submit button.

I was also thinking that per field reverts could be considered an 
enhancement for later too.

Anyway, given that there was a feeling that tickets should not start in 
an editable state, I was assuming that the ability to toggle between 
states would be wanted to avoid accidental changes. Without that I 
suppose users are encouraged to submit their changes earlier so I am 
happy to lose that aspect.

Cheers,
     Gary


On 23/11/12 19:15, Joe Dreimann wrote:
> I think that sounds like a reasonable process given our requirements.
>
> Regarding point 5. though maybe there shouldn't be a submit button in the view state - to avoid confusion users should only be able to leave the edit state by submitting or reversing their changes.
>
> That way a submit button in the view state is only needed for the 'new comment' section.
>
> - Joe
>
> ________________________
> @jdreimann - Twitter
> Sent from my phone
>
> On 23 Nov 2012, at 18:50, Gary Martin <ga...@wandisco.com> wrote:
>
>> OK,
>>
>> Given the lack of further discussion, I will attempt to propose a solution that begins to fit the requirements:
>>
>> 1. Initial access to a page shows the potentially editable fields in
>>    the view state which should more or less match the current view
>>    subject to differences specified below
>> 2. If the user has the appropriate permissions to modify the ticket, a
>>    button is added to toggle between editable and view states (keyboard
>>    shortcuts for these actions would also be nice enhancements for later.)
>> 3. In the editable state, all fields will be changed to the appropriate
>>    kind of control for the field
>>      * Any fields that the user does not have permission to change
>>        should be locked in a way that is obvious - I would probably say
>>        that it is better to be changed to a locked control to make it
>>        feel that it is locked on purpose
>> 4. A field that is changed relative to the original state should
>>    provide an indication of this status in both edit and view states.
>> 5. A submit button should be available from either edit or view states
>>    - active when there are changes that can be submitted.
>> 6. For javascript turned off on the browser, behaviour should revert
>>    back to the current separate form with an appropriate links to skip
>>    down to it. With javascript on, the form is hidden and the
>>    associated navigation item is then not required.
>>
>> Or something like that. So, apart from a clear idea of how we clearly mark fields as edited, are there any other holes in this? It is also worth considering if this fits with the current mechanisms for guarding against conflicts dues to concurrent edits.
>>
>> Cheers,
>>     Gary
>>
>> On 06/11/12 06:08, Peter Koželj wrote:
>>> On 5 November 2012 16:17, Jure Zitnik <ju...@digiverse.si> wrote:
>>>
>>>> On 11/5/12 12:44 PM, Gary Martin wrote:
>>>>
>>>>> Individual confirmation on every field? That sounds like the same thing as
>>>>> an immediate save. I think that so far the consensus is that we don't want
>>>>> that.
>>>> +1
>>>      +1
>>>
>>>>   I've been using a few developers at apachecon as sounding boards as I am
>>>>> worried that things might be more complicated than necessary. The solution
>>>>> that would seem most efficient would be that all the fields that are
>>>>> editable are considered to be in an editable state already. The problem
>>>>> with this is then how it is made abundantly clear that a field is editable
>>>>> - and it would be nice to see when a field has been edited too.
>>>>>
>>>>> I am not yet convinced that a button to make all fields editable is the
>>>>> right approach at the moment - it seems like a step you shouldn't need.
>>>> I think that the ticket could be shown as read only initially, with the
>>>> scroll spy component being visible from start (I think that was discussed
>>>> in another thread already). As the scroll spy already includes the 'Modify
>>>> ticket' button, clicking that button would enable 'edit mode' which would
>>>> replace ticket fields inline (read only for editable) - that is, w/o
>>>> scrolling to the 'Modify ticket' section. So, I would go for one button to
>>>> enable the 'edit' state and one button for submission.
>>> +100 :)
>>>
>>>
>>>>   Other than that, a submit all changes button would probably work well.
>>>> +1
>>>      +1
>>>
>>>> Cheers,
>>>> Jure
>>>>
>>>>
>>>>   Cheers,
>>>>>       Gary
>>>>>
>>>>> On 5 November 2012 10:21, Joachim Dreimann <joachim.dreimann@wandisco.com
>>>>> **>wrote:
>>>>>
>>>>>   I notice that there were no replies to my last message (see below) and
>>>>>> the
>>>>>> ticket has therefore been put on hold. We've made no progress in a whole
>>>>>> month on an issue all seemed to agree was important.
>>>>>>
>>>>>> The question remains:
>>>>>>
>>>>>>> Should we enable the 'edit' state for all fields using one button and
>>>>>> submit using one button, or should we take Jira's approach of asking for
>>>>>> individual confirmation on every field?
>>>>>>
>>>>>>
>>>>>> - Joe
>>>>>>
>>>>>> On 5 Oct 2012, at 20:10, Joe Dreimann <joachim.dreimann@wandisco.com**>
>>>>>> wrote:
>>>>>>
>>>>>>   Ok, that sounds like we have a decision: All are in favour of
>>>>>> non-immediate saves for edits.
>>>>>>
>>>>>>> Now, should we enable the 'edit' state for all fields using one button
>>>>>> and submit using one button, or should we take Jira's approach of asking
>>>>>> for individual confirmation on every field?
>>>>>>
>>>>>>>   http://www.youtube.com/watch?**feature=player_detailpage&v=**
>>>>>> EsQ__dR6Nrw#t=59s<http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s>
>>>>>>
>>>>>>> I'm bringing up Jira because it's used in a very similar context as
>>>>>> Bloodhound.
>>>>>>
>>>>>>> Cheers,
>>>>>>> Joe
>>>>>>>
>>>>>>> ________________________
>>>>>>> @jdreimann - Twitter
>>>>>>> Sent from my phone
>>>>>>>
>>>>>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
>>>>>>>
>>>>>>>   I too am strongly against inline editing causing auto-save. Ticket
>>>>>>>> changes must be intended and atomical!
>>>>>>>> 1. Tickets are versioned and this messes up the ticket history
>>>>>>>> 2. Multiple ticket notifications get sent out
>>>>>>>> 3. Any ticket statistics get incorrect
>>>>>>>> 4. In bigger enterprise environments tracking systems are integrated
>>>>>>> with
>>>>>>> other infrastructure, which means unintended inconsistencies are
>>>>>>> propagated
>>>>>>> to other systems as well
>>>>>>>> 5. Companies will offen grant their customers access to tracking system
>>>>>>> and
>>>>>>> last person that I want to burdon with this, is my client.
>>>>>>>> 6. If this works only for half of the tickt's fields, it is
>>>>>>> inconsistent!
>>>>>>> And the problem will just be worse when we try to get rid of that
>>>>>>> "Modify"
>>>>>>> section.
>>>>>>>> I do find the proposed concept appealing for things like user
>>>>>>> preferences
>>>>>>> but even for that we would need to weight pros and cons.
>>>>>>>> Peter
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <gary.martin@wandisco.com
>>>>>>> wrote:
>>>>>>>
>>>>>>>>> Olemis Lang <ol...@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>   On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>>>>>>>>
>>>>>>>>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <gary.martin@wandisco.com
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>>>>>>>>>>>>>> [...]
>>>>>>>>>>>>> As a user using a web application with the server 50 hops away
>>>>>>>>>>>>> with
>>>>>>>>>>>> a
>>>>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>>>>>>>>>>>> make
>>>>>>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>>>>>>>>>>> (even
>>>>>>>>>>> worse! then I don't know in what order the server actually receives
>>>>>>>>>>>> the
>>>>>>>>>>> requests).
>>>>>>>>>>>> ... if you take a look at #146 attachments you'll notice that my
>>>>>>>>>>> first
>>>>>>>>>>> proposal included submit button for select fields . I was told to
>>>>>>>>>>>> revert that .
>>>>>>>>>>> Hmm. "Told to" implies hierarchy.
>>>>>>>>>> ... or respect to the opinions of the experts , and Joachim is the UI
>>>>>>>>>> expert . When I have radical objections to other people's thoughts
>>>>>>>>>> and
>>>>>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>>>>>>>>> there are underlying technical decisions that make it impossible to
>>>>>>>>>> realize some ideas then I express my opinion . This time I don't
>>>>>>>>>> think
>>>>>>>>>> it was the case . /me studying and learning about UI design , etc ...
>>>>>>>>>> but that's just work in progress . Hence most of the time I won't
>>>>>>>>>> criticize UI decisions beyond «evident» issues I might notice.
>>>>>>>>>>
>>>>>>>>>> So to clarify my position , in this particular case i.e. #146 , I
>>>>>>>>>> declare myself a completely happy neophyte and *so far* I have no
>>>>>>>>>> strong arguments in favor or against any of both approaches . Please
>>>>>>>>>> get to an agreement . In the meantime , if I have something to say
>>>>>>>>>> I'll say it . Just let me know what needs to be done to continue work
>>>>>>>>>> needed to finish patches  for #146 , please .
>>>>>>>>>>
>>>>>>>>>> ;)
>>>>>>>>> This is why we need more decisions to be made here. No one person is
>>>>>>>> going
>>>>>>> to be right on every decision.
>>>>>>>>> For some reason I didn't get the impression from the discussion in the
>>>>>>>>> ticket that it would result in immediate edits. If more people were
>>>>>>>>> watching the discussion, this might have been caught earlier as
>>>>>>>> something
>>>>>>> that people would frown upon. Maybe.
>>>>>>>>> Anyway, personally I want to see in-place edits implemented such that
>>>>>>>> the
>>>>>>> changes are not sent immediately but should be submitted with a single
>>>>>>>>> button.
>>>>>>>>>
>>>>>>>>> I would probably be attempting to effectively use the existing form to
>>>>>>>>> send the data - I suspect that at some point we will want the old form
>>>>>>>>> hidden but it should probably be available for js disabled situations.
>>>>>>>>>
>>>>>>>>> For me, that would be enough work on the ticket. After that we can
>>>>>>>> build
>>>>>>> on that work with things like indicating which fields are edited and
>>>>>>>>> perhaps making it easier to comment on the changes (the comment field
>>>>>>>> is
>>>>>>> way down the page on long tickets). I would also be interested in
>>>>>>>> whether
>>>>>>> people would want to see a confirmation that the user should move away
>>>>>>>> from
>>>>>>> a page when there are edits that are not submitted.
>>>>>>>>> Cheers,
>>>>>>>>>     Gary


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Joe Dreimann <jo...@wandisco.com>.
I think that sounds like a reasonable process given our requirements.

Regarding point 5. though maybe there shouldn't be a submit button in the view state - to avoid confusion users should only be able to leave the edit state by submitting or reversing their changes.

That way a submit button in the view state is only needed for the 'new comment' section.

- Joe

________________________
@jdreimann - Twitter
Sent from my phone

On 23 Nov 2012, at 18:50, Gary Martin <ga...@wandisco.com> wrote:

> OK,
> 
> Given the lack of further discussion, I will attempt to propose a solution that begins to fit the requirements:
> 
> 1. Initial access to a page shows the potentially editable fields in
>   the view state which should more or less match the current view
>   subject to differences specified below
> 2. If the user has the appropriate permissions to modify the ticket, a
>   button is added to toggle between editable and view states (keyboard
>   shortcuts for these actions would also be nice enhancements for later.)
> 3. In the editable state, all fields will be changed to the appropriate
>   kind of control for the field
>     * Any fields that the user does not have permission to change
>       should be locked in a way that is obvious - I would probably say
>       that it is better to be changed to a locked control to make it
>       feel that it is locked on purpose
> 4. A field that is changed relative to the original state should
>   provide an indication of this status in both edit and view states.
> 5. A submit button should be available from either edit or view states
>   - active when there are changes that can be submitted.
> 6. For javascript turned off on the browser, behaviour should revert
>   back to the current separate form with an appropriate links to skip
>   down to it. With javascript on, the form is hidden and the
>   associated navigation item is then not required.
> 
> Or something like that. So, apart from a clear idea of how we clearly mark fields as edited, are there any other holes in this? It is also worth considering if this fits with the current mechanisms for guarding against conflicts dues to concurrent edits.
> 
> Cheers,
>    Gary
> 
> On 06/11/12 06:08, Peter Koželj wrote:
>> On 5 November 2012 16:17, Jure Zitnik <ju...@digiverse.si> wrote:
>> 
>>> On 11/5/12 12:44 PM, Gary Martin wrote:
>>> 
>>>> Individual confirmation on every field? That sounds like the same thing as
>>>> an immediate save. I think that so far the consensus is that we don't want
>>>> that.
>>> +1
>>     +1
>> 
>>> 
>>>  I've been using a few developers at apachecon as sounding boards as I am
>>>> worried that things might be more complicated than necessary. The solution
>>>> that would seem most efficient would be that all the fields that are
>>>> editable are considered to be in an editable state already. The problem
>>>> with this is then how it is made abundantly clear that a field is editable
>>>> - and it would be nice to see when a field has been edited too.
>>>> 
>>>> I am not yet convinced that a button to make all fields editable is the
>>>> right approach at the moment - it seems like a step you shouldn't need.
>>> I think that the ticket could be shown as read only initially, with the
>>> scroll spy component being visible from start (I think that was discussed
>>> in another thread already). As the scroll spy already includes the 'Modify
>>> ticket' button, clicking that button would enable 'edit mode' which would
>>> replace ticket fields inline (read only for editable) - that is, w/o
>>> scrolling to the 'Modify ticket' section. So, I would go for one button to
>>> enable the 'edit' state and one button for submission.
>> 
>> +100 :)
>> 
>> 
>>> 
>>>  Other than that, a submit all changes button would probably work well.
>>> +1
>>     +1
>> 
>>> Cheers,
>>> Jure
>>> 
>>> 
>>>  Cheers,
>>>>      Gary
>>>> 
>>>> On 5 November 2012 10:21, Joachim Dreimann <joachim.dreimann@wandisco.com
>>>> **>wrote:
>>>> 
>>>>  I notice that there were no replies to my last message (see below) and
>>>>> the
>>>>> ticket has therefore been put on hold. We've made no progress in a whole
>>>>> month on an issue all seemed to agree was important.
>>>>> 
>>>>> The question remains:
>>>>> 
>>>>>> Should we enable the 'edit' state for all fields using one button and
>>>>> submit using one button, or should we take Jira's approach of asking for
>>>>> individual confirmation on every field?
>>>>> 
>>>>> 
>>>>> - Joe
>>>>> 
>>>>> On 5 Oct 2012, at 20:10, Joe Dreimann <joachim.dreimann@wandisco.com**>
>>>>> wrote:
>>>>> 
>>>>>  Ok, that sounds like we have a decision: All are in favour of
>>>>> non-immediate saves for edits.
>>>>> 
>>>>>> Now, should we enable the 'edit' state for all fields using one button
>>>>> and submit using one button, or should we take Jira's approach of asking
>>>>> for individual confirmation on every field?
>>>>> 
>>>>>>  http://www.youtube.com/watch?**feature=player_detailpage&v=**
>>>>> EsQ__dR6Nrw#t=59s<http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s>
>>>>> 
>>>>>> I'm bringing up Jira because it's used in a very similar context as
>>>>> Bloodhound.
>>>>> 
>>>>>> Cheers,
>>>>>> Joe
>>>>>> 
>>>>>> ________________________
>>>>>> @jdreimann - Twitter
>>>>>> Sent from my phone
>>>>>> 
>>>>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
>>>>>> 
>>>>>>  I too am strongly against inline editing causing auto-save. Ticket
>>>>>>> changes must be intended and atomical!
>>>>>>> 1. Tickets are versioned and this messes up the ticket history
>>>>>>> 2. Multiple ticket notifications get sent out
>>>>>>> 3. Any ticket statistics get incorrect
>>>>>>> 4. In bigger enterprise environments tracking systems are integrated
>>>>>> with
>>>>>> other infrastructure, which means unintended inconsistencies are
>>>>>> propagated
>>>>>> to other systems as well
>>>>>>> 5. Companies will offen grant their customers access to tracking system
>>>>>> and
>>>>>> last person that I want to burdon with this, is my client.
>>>>>>> 6. If this works only for half of the tickt's fields, it is
>>>>>> inconsistent!
>>>>>> And the problem will just be worse when we try to get rid of that
>>>>>> "Modify"
>>>>>> section.
>>>>>>> I do find the proposed concept appealing for things like user
>>>>>> preferences
>>>>>> but even for that we would need to weight pros and cons.
>>>>>>> Peter
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <gary.martin@wandisco.com
>>>>>> wrote:
>>>>>> 
>>>>>>>> Olemis Lang <ol...@gmail.com> wrote:
>>>>>>>> 
>>>>>>>>  On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>>>>>>> 
>>>>>>>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>>>> 
>>>>>>>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>>>>>>> 
>>>>>>>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>>>>>>> 
>>>>>>>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <gary.martin@wandisco.com
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>>>>>>>>>>>>> [...]
>>>>>>>>>>>> As a user using a web application with the server 50 hops away
>>>>>>>>>>>> with
>>>>>>>>>>> a
>>>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>>>>>>>>>>> make
>>>>>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>>>>>>>>>> (even
>>>>>>>>>> worse! then I don't know in what order the server actually receives
>>>>>>>>>>> the
>>>>>>>>>> requests).
>>>>>>>>>>> ... if you take a look at #146 attachments you'll notice that my
>>>>>>>>>> first
>>>>>>>>>> proposal included submit button for select fields . I was told to
>>>>>>>>>>> revert that .
>>>>>>>>>> Hmm. "Told to" implies hierarchy.
>>>>>>>>> ... or respect to the opinions of the experts , and Joachim is the UI
>>>>>>>>> expert . When I have radical objections to other people's thoughts
>>>>>>>>> and
>>>>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>>>>>>>> there are underlying technical decisions that make it impossible to
>>>>>>>>> realize some ideas then I express my opinion . This time I don't
>>>>>>>>> think
>>>>>>>>> it was the case . /me studying and learning about UI design , etc ...
>>>>>>>>> but that's just work in progress . Hence most of the time I won't
>>>>>>>>> criticize UI decisions beyond «evident» issues I might notice.
>>>>>>>>> 
>>>>>>>>> So to clarify my position , in this particular case i.e. #146 , I
>>>>>>>>> declare myself a completely happy neophyte and *so far* I have no
>>>>>>>>> strong arguments in favor or against any of both approaches . Please
>>>>>>>>> get to an agreement . In the meantime , if I have something to say
>>>>>>>>> I'll say it . Just let me know what needs to be done to continue work
>>>>>>>>> needed to finish patches  for #146 , please .
>>>>>>>>> 
>>>>>>>>> ;)
>>>>>>>> This is why we need more decisions to be made here. No one person is
>>>>>>> going
>>>>>> to be right on every decision.
>>>>>>>> For some reason I didn't get the impression from the discussion in the
>>>>>>>> ticket that it would result in immediate edits. If more people were
>>>>>>>> watching the discussion, this might have been caught earlier as
>>>>>>> something
>>>>>> that people would frown upon. Maybe.
>>>>>>>> Anyway, personally I want to see in-place edits implemented such that
>>>>>>> the
>>>>>> changes are not sent immediately but should be submitted with a single
>>>>>>>> button.
>>>>>>>> 
>>>>>>>> I would probably be attempting to effectively use the existing form to
>>>>>>>> send the data - I suspect that at some point we will want the old form
>>>>>>>> hidden but it should probably be available for js disabled situations.
>>>>>>>> 
>>>>>>>> For me, that would be enough work on the ticket. After that we can
>>>>>>> build
>>>>>> on that work with things like indicating which fields are edited and
>>>>>>>> perhaps making it easier to comment on the changes (the comment field
>>>>>>> is
>>>>>> way down the page on long tickets). I would also be interested in
>>>>>>> whether
>>>>>> people would want to see a confirmation that the user should move away
>>>>>>> from
>>>>>> a page when there are edits that are not submitted.
>>>>>>>> Cheers,
>>>>>>>>    Gary
> 

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 11/30/12, Joachim Dreimann <jo...@wandisco.com> wrote:
> The look won't change that much, so I'm not sure a wireframe would be that
> helpful. I will restate Gary's last 'reset' email though:
>
[...]

ok . I'll create new patches asap .
Thanks for the feedback .

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Joachim Dreimann <jo...@wandisco.com>.
The look won't change that much, so I'm not sure a wireframe would be that
helpful. I will restate Gary's last 'reset' email though:

1. Initial access to a page shows the potentially editable fields in
   the view state which should more or less match the current view
   subject to differences specified below
2. If the user has the appropriate permissions to modify the ticket, a
   button is added to toggle between editable and view states (keyboard
   shortcuts for these actions would also be nice enhancements for later.)
3. In the editable state, all fields will be changed to the appropriate
   kind of control for the field
     * Any fields that the user does not have permission to change
       should be locked in a way that is obvious - I would probably say
       that it is better to be changed to a locked control to make it
       feel that it is locked on purpose
4. A field that is changed relative to the original state should
   provide an indication of this status in both edit and view states.
*
*
*[ point 5 removed because discussion indicated this won't be necessary ]*
*
*6. For javascript turned off on the browser, behaviour should revert
   back to the current separate form with an appropriate links to skip
   down to it. With javascript on, the form is hidden and the
   associated navigation item is then not required.

I believe this should be the basis of our work going forward. Specific
details should be decided in the implementation phase.

Cheers,
Joe


On 28 November 2012 10:47, Peter Koželj <pe...@digiverse.si> wrote:

> After 40+ mails on this topic where other things (quick create ticket, app
> links, js fallbacks) in the mix  I have lost track of what everybody on
> here visualizes the new "inline" edit ticket should look like.
>
> Maybe we should reset this with a mock or wire diagram for new edit ticket
> and discuss other things like create ticket button in new thread?
>
> Peter
>
> On 28 November 2012 07:59, Olemis Lang <ol...@gmail.com> wrote:
>
> > On 11/27/12, Gary Martin <ga...@wandisco.com> wrote:
> > > On 27/11/12 16:00, Olemis Lang wrote:
> > >> On 11/23/12, Gary Martin <ga...@wandisco.com> wrote:
> > >> [...]
> > >>> Or something like that. So, apart from a clear idea of how we clearly
> > >>> mark fields as edited, are there any other holes in this? It is also
> > >>> worth considering if this fits with the current mechanisms for
> guarding
> > >>> against conflicts dues to concurrent edits.
> > >>
> > >> Yes. I notice a gap here (unless I'm missing something ...) , and it
> > >> is related to ticket workflow . Inline edits have to pass through
> > >> workflow . Ideally we could always force `leave` action on in place
> > >> edits but if Modify Ticket section won't be there then what shall we
> > >> do ?
> > >>
> > >
> > > I wouldn't say that changes to the ticket details imply a change of
> > > ticket status within the workflow so I was hoping to leave this as a
> > > separate proposal.
> > >
> >
> > A change of ticket status ? Well , no . You are right . That's what
> > built-in leave action is for . However IMO edits must always pass
> > through workflow . If action=leave nothing remarkable happens though .
> >
> > > However, it does seem worthy of comment as there are a few
> > > inconsistencies.
> >
> > yes
> >
> > > For example, it would be nice to be able to change the
> > > "assigned to" user but the ability to do that is dependent on workflow
> > > too. Meanwhile "reported by" could be considered an in-place edit. A
> > > similar thing happens with the status and ticket type fields that are
> > > close together. The attempts to change the workflow related items would
> > > probably have to either send you to the "Action" control or present you
> > > with the control somehow.
> > >
> >
> > I'd rather prefer to see workflow actions when editing other fields as
> > well .
> >
> > OTOH , editing «owner» leads to the ambiguous situation when there are
> > many choices to assign a ticket to somebody (e.g. info request ,
> > review , assign to , test , ...) . Not to mention and custom workflow
> > actions / controllers and related side-effects happening at once .
> > This makes me wander whether it's better (correct ?) to focus on
> > workflow actions rather than fields when analyzing this particular
> > subject from a user experience perspective .
> >
> > > At this point I really have to see what those with more knowledge of ui
> > > design will come up with though.
> > >
> >
> > beyond UI , or UX ... it may also be about domain / business logic ,
> > and workflow semantics
> > ;)
> >
> > --
> > Regards,
> >
> > Olemis.
> >
> > Blog ES: http://simelo-es.blogspot.com/
> > Blog EN: http://simelo-en.blogspot.com/
> >
> > Featured article:
> >
>



-- 
Joe Dreimann
UX Designer | WANdisco <http://www.wandisco.com/>
*
*
*Transform your software development department. Register for a free SVN
HealthCheck <http://go.wandisco.com/HealthCheck-Sig.html> *

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Peter Koželj <pe...@digiverse.si>.
After 40+ mails on this topic where other things (quick create ticket, app
links, js fallbacks) in the mix  I have lost track of what everybody on
here visualizes the new "inline" edit ticket should look like.

Maybe we should reset this with a mock or wire diagram for new edit ticket
and discuss other things like create ticket button in new thread?

Peter

On 28 November 2012 07:59, Olemis Lang <ol...@gmail.com> wrote:

> On 11/27/12, Gary Martin <ga...@wandisco.com> wrote:
> > On 27/11/12 16:00, Olemis Lang wrote:
> >> On 11/23/12, Gary Martin <ga...@wandisco.com> wrote:
> >> [...]
> >>> Or something like that. So, apart from a clear idea of how we clearly
> >>> mark fields as edited, are there any other holes in this? It is also
> >>> worth considering if this fits with the current mechanisms for guarding
> >>> against conflicts dues to concurrent edits.
> >>
> >> Yes. I notice a gap here (unless I'm missing something ...) , and it
> >> is related to ticket workflow . Inline edits have to pass through
> >> workflow . Ideally we could always force `leave` action on in place
> >> edits but if Modify Ticket section won't be there then what shall we
> >> do ?
> >>
> >
> > I wouldn't say that changes to the ticket details imply a change of
> > ticket status within the workflow so I was hoping to leave this as a
> > separate proposal.
> >
>
> A change of ticket status ? Well , no . You are right . That's what
> built-in leave action is for . However IMO edits must always pass
> through workflow . If action=leave nothing remarkable happens though .
>
> > However, it does seem worthy of comment as there are a few
> > inconsistencies.
>
> yes
>
> > For example, it would be nice to be able to change the
> > "assigned to" user but the ability to do that is dependent on workflow
> > too. Meanwhile "reported by" could be considered an in-place edit. A
> > similar thing happens with the status and ticket type fields that are
> > close together. The attempts to change the workflow related items would
> > probably have to either send you to the "Action" control or present you
> > with the control somehow.
> >
>
> I'd rather prefer to see workflow actions when editing other fields as
> well .
>
> OTOH , editing «owner» leads to the ambiguous situation when there are
> many choices to assign a ticket to somebody (e.g. info request ,
> review , assign to , test , ...) . Not to mention and custom workflow
> actions / controllers and related side-effects happening at once .
> This makes me wander whether it's better (correct ?) to focus on
> workflow actions rather than fields when analyzing this particular
> subject from a user experience perspective .
>
> > At this point I really have to see what those with more knowledge of ui
> > design will come up with though.
> >
>
> beyond UI , or UX ... it may also be about domain / business logic ,
> and workflow semantics
> ;)
>
> --
> Regards,
>
> Olemis.
>
> Blog ES: http://simelo-es.blogspot.com/
> Blog EN: http://simelo-en.blogspot.com/
>
> Featured article:
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 11/27/12, Gary Martin <ga...@wandisco.com> wrote:
> On 27/11/12 16:00, Olemis Lang wrote:
>> On 11/23/12, Gary Martin <ga...@wandisco.com> wrote:
>> [...]
>>> Or something like that. So, apart from a clear idea of how we clearly
>>> mark fields as edited, are there any other holes in this? It is also
>>> worth considering if this fits with the current mechanisms for guarding
>>> against conflicts dues to concurrent edits.
>>
>> Yes. I notice a gap here (unless I'm missing something ...) , and it
>> is related to ticket workflow . Inline edits have to pass through
>> workflow . Ideally we could always force `leave` action on in place
>> edits but if Modify Ticket section won't be there then what shall we
>> do ?
>>
>
> I wouldn't say that changes to the ticket details imply a change of
> ticket status within the workflow so I was hoping to leave this as a
> separate proposal.
>

A change of ticket status ? Well , no . You are right . That's what
built-in leave action is for . However IMO edits must always pass
through workflow . If action=leave nothing remarkable happens though .

> However, it does seem worthy of comment as there are a few
> inconsistencies.

yes

> For example, it would be nice to be able to change the
> "assigned to" user but the ability to do that is dependent on workflow
> too. Meanwhile "reported by" could be considered an in-place edit. A
> similar thing happens with the status and ticket type fields that are
> close together. The attempts to change the workflow related items would
> probably have to either send you to the "Action" control or present you
> with the control somehow.
>

I'd rather prefer to see workflow actions when editing other fields as well .

OTOH , editing «owner» leads to the ambiguous situation when there are
many choices to assign a ticket to somebody (e.g. info request ,
review , assign to , test , ...) . Not to mention and custom workflow
actions / controllers and related side-effects happening at once .
This makes me wander whether it's better (correct ?) to focus on
workflow actions rather than fields when analyzing this particular
subject from a user experience perspective .

> At this point I really have to see what those with more knowledge of ui
> design will come up with though.
>

beyond UI , or UX ... it may also be about domain / business logic ,
and workflow semantics
;)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
On 27/11/12 16:00, Olemis Lang wrote:
> On 11/23/12, Gary Martin <ga...@wandisco.com> wrote:
> [...]
>> Or something like that. So, apart from a clear idea of how we clearly
>> mark fields as edited, are there any other holes in this? It is also
>> worth considering if this fits with the current mechanisms for guarding
>> against conflicts dues to concurrent edits.
> Yes. I notice a gap here (unless I'm missing something ...) , and it
> is related to ticket workflow . Inline edits have to pass through
> workflow . Ideally we could always force `leave` action on in place
> edits but if Modify Ticket section won't be there then what shall we
> do ?
>

I wouldn't say that changes to the ticket details imply a change of 
ticket status within the workflow so I was hoping to leave this as a 
separate proposal.

However, it does seem worthy of comment as there are a few 
inconsistencies. For example, it would be nice to be able to change the 
"assigned to" user but the ability to do that is dependent on workflow 
too. Meanwhile "reported by" could be considered an in-place edit. A 
similar thing happens with the status and ticket type fields that are 
close together. The attempts to change the workflow related items would 
probably have to either send you to the "Action" control or present you 
with the control somehow.

At this point I really have to see what those with more knowledge of ui 
design will come up with though.

Cheers,
     Gary


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 11/23/12, Gary Martin <ga...@wandisco.com> wrote:
[...]
>
> Or something like that. So, apart from a clear idea of how we clearly
> mark fields as edited, are there any other holes in this? It is also
> worth considering if this fits with the current mechanisms for guarding
> against conflicts dues to concurrent edits.

Yes. I notice a gap here (unless I'm missing something ...) , and it
is related to ticket workflow . Inline edits have to pass through
workflow . Ideally we could always force `leave` action on in place
edits but if Modify Ticket section won't be there then what shall we
do ?

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Peter Koželj <pe...@digiverse.si>.
I agree, HTML5 brings improvements beyond DOM/JS API standardization in we
can and I think we should adopt it regardless of what our policy with JS is.

I also do not mind maintaining non-JS version if that is something our
users need, let's just not design our default UX around that and I am happy
with that.

Peter

On 26 November 2012 13:51, Joachim Dreimann
<jo...@wandisco.com>wrote:

> HTML5 and JavaScript are two different issues, most obviously because one
> is a fix for the other: http://en.wikipedia.org/wiki/HTML5_Shiv
> HTML5 will also take some of the weight off JavaScript going forward, for
> example with contentEditable in this context:
> http://html5demos.com/contenteditable
>
> Public sector organisations usually require all software to meet certain
> accessibility standards, and I would suggest that we build to their most
> basic standards at least. Screen readers often struggle with javascript, so
> Gary's suggestion was to at least have JS-less fallback (the current edit
> form). It's acceptable that this won't be pretty; most users will never see
> it.
>
> - Joe
>
>
> On 26 November 2012 06:49, Peter Koželj <pe...@digiverse.si> wrote:
>
> > Not sure how much does support for javascript disabled browsers
> complicate
> > things, but do we really care to support this when everybody is rushing
> to
> > HTML5?
> >
> > I haven't that kind of requirement for a web application in the last 7
> > years or so.
> >
> > Peter
> >
> > On 23 November 2012 19:50, Gary Martin <ga...@wandisco.com> wrote:
> >
> > > OK,
> > >
> > > Given the lack of further discussion, I will attempt to propose a
> > solution
> > > that begins to fit the requirements:
> > >
> > > 1. Initial access to a page shows the potentially editable fields in
> > >    the view state which should more or less match the current view
> > >    subject to differences specified below
> > > 2. If the user has the appropriate permissions to modify the ticket, a
> > >    button is added to toggle between editable and view states (keyboard
> > >    shortcuts for these actions would also be nice enhancements for
> > later.)
> > > 3. In the editable state, all fields will be changed to the appropriate
> > >    kind of control for the field
> > >      * Any fields that the user does not have permission to change
> > >        should be locked in a way that is obvious - I would probably say
> > >        that it is better to be changed to a locked control to make it
> > >        feel that it is locked on purpose
> > > 4. A field that is changed relative to the original state should
> > >    provide an indication of this status in both edit and view states.
> > > 5. A submit button should be available from either edit or view states
> > >    - active when there are changes that can be submitted.
> > > 6. For javascript turned off on the browser, behaviour should revert
> > >    back to the current separate form with an appropriate links to skip
> > >    down to it. With javascript on, the form is hidden and the
> > >    associated navigation item is then not required.
> > >
> > > Or something like that. So, apart from a clear idea of how we clearly
> > mark
> > > fields as edited, are there any other holes in this? It is also worth
> > > considering if this fits with the current mechanisms for guarding
> against
> > > conflicts dues to concurrent edits.
> > >
> > > Cheers,
> > >     Gary
> > >
> > >
> > > On 06/11/12 06:08, Peter Koželj wrote:
> > >
> > >> On 5 November 2012 16:17, Jure Zitnik <ju...@digiverse.si> wrote:
> > >>
> > >>  On 11/5/12 12:44 PM, Gary Martin wrote:
> > >>>
> > >>>  Individual confirmation on every field? That sounds like the same
> > thing
> > >>>> as
> > >>>> an immediate save. I think that so far the consensus is that we
> don't
> > >>>> want
> > >>>> that.
> > >>>>
> > >>>>  +1
> > >>>
> > >>      +1
> > >>
> > >>
> > >>>   I've been using a few developers at apachecon as sounding boards
> as I
> > >>> am
> > >>>
> > >>>> worried that things might be more complicated than necessary. The
> > >>>> solution
> > >>>> that would seem most efficient would be that all the fields that are
> > >>>> editable are considered to be in an editable state already. The
> > problem
> > >>>> with this is then how it is made abundantly clear that a field is
> > >>>> editable
> > >>>> - and it would be nice to see when a field has been edited too.
> > >>>>
> > >>>> I am not yet convinced that a button to make all fields editable is
> > the
> > >>>> right approach at the moment - it seems like a step you shouldn't
> > need.
> > >>>>
> > >>>>  I think that the ticket could be shown as read only initially, with
> > the
> > >>> scroll spy component being visible from start (I think that was
> > discussed
> > >>> in another thread already). As the scroll spy already includes the
> > >>> 'Modify
> > >>> ticket' button, clicking that button would enable 'edit mode' which
> > would
> > >>> replace ticket fields inline (read only for editable) - that is, w/o
> > >>> scrolling to the 'Modify ticket' section. So, I would go for one
> button
> > >>> to
> > >>> enable the 'edit' state and one button for submission.
> > >>>
> > >>
> > >> +100 :)
> > >>
> > >>
> > >>
> > >>>   Other than that, a submit all changes button would probably work
> > well.
> > >>> +1
> > >>>
> > >>>       +1
> > >>
> > >>  Cheers,
> > >>> Jure
> > >>>
> > >>>
> > >>>   Cheers,
> > >>>
> > >>>>       Gary
> > >>>>
> > >>>> On 5 November 2012 10:21, Joachim Dreimann <
> > >>>> joachim.dreimann@wandisco.com
> > >>>> **>wrote:
> > >>>>
> > >>>>
> > >>>>   I notice that there were no replies to my last message (see below)
> > and
> > >>>>
> > >>>>> the
> > >>>>> ticket has therefore been put on hold. We've made no progress in a
> > >>>>> whole
> > >>>>> month on an issue all seemed to agree was important.
> > >>>>>
> > >>>>> The question remains:
> > >>>>>
> > >>>>>  Should we enable the 'edit' state for all fields using one button
> > and
> > >>>>>>
> > >>>>>>  submit using one button, or should we take Jira's approach of
> > asking
> > >>>>> for
> > >>>>> individual confirmation on every field?
> > >>>>>
> > >>>>>
> > >>>>> - Joe
> > >>>>>
> > >>>>> On 5 Oct 2012, at 20:10, Joe Dreimann <
> joachim.dreimann@wandisco.com
> > **
> > >>>>> **>
> > >>>>>
> > >>>>> wrote:
> > >>>>>
> > >>>>>   Ok, that sounds like we have a decision: All are in favour of
> > >>>>> non-immediate saves for edits.
> > >>>>>
> > >>>>>  Now, should we enable the 'edit' state for all fields using one
> > button
> > >>>>>>
> > >>>>>>  and submit using one button, or should we take Jira's approach of
> > >>>>> asking
> > >>>>> for individual confirmation on every field?
> > >>>>>
> > >>>>>
> http://www.youtube.com/watch?****feature=player_detailpage&v=****
> > <http://www.youtube.com/watch?**feature=player_detailpage&v=**>
> > >>>>>>
> > >>>>> EsQ__dR6Nrw#t=59s<http://www.**youtube.com/watch?feature=**
> > >>>>> player_detailpage&v=EsQ__**dR6Nrw#t=59s<
> >
> http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s
> > >
> > >>>>> >
> > >>>>>
> > >>>>>
> > >>>>>  I'm bringing up Jira because it's used in a very similar context
> as
> > >>>>>>
> > >>>>>>  Bloodhound.
> > >>>>>
> > >>>>>  Cheers,
> > >>>>>> Joe
> > >>>>>>
> > >>>>>> ________________________
> > >>>>>> @jdreimann - Twitter
> > >>>>>> Sent from my phone
> > >>>>>>
> > >>>>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
> > >>>>>>
> > >>>>>>   I too am strongly against inline editing causing auto-save.
> Ticket
> > >>>>>>
> > >>>>>>> changes must be intended and atomical!
> > >>>>>>> 1. Tickets are versioned and this messes up the ticket history
> > >>>>>>> 2. Multiple ticket notifications get sent out
> > >>>>>>> 3. Any ticket statistics get incorrect
> > >>>>>>> 4. In bigger enterprise environments tracking systems are
> > integrated
> > >>>>>>>
> > >>>>>>>  with
> > >>>>>> other infrastructure, which means unintended inconsistencies are
> > >>>>>> propagated
> > >>>>>> to other systems as well
> > >>>>>>
> > >>>>>>> 5. Companies will offen grant their customers access to tracking
> > >>>>>>> system
> > >>>>>>>
> > >>>>>>>  and
> > >>>>>> last person that I want to burdon with this, is my client.
> > >>>>>>
> > >>>>>>> 6. If this works only for half of the tickt's fields, it is
> > >>>>>>>
> > >>>>>>>  inconsistent!
> > >>>>>> And the problem will just be worse when we try to get rid of that
> > >>>>>> "Modify"
> > >>>>>> section.
> > >>>>>>
> > >>>>>>> I do find the proposed concept appealing for things like user
> > >>>>>>>
> > >>>>>>>  preferences
> > >>>>>> but even for that we would need to weight pros and cons.
> > >>>>>>
> > >>>>>>> Peter
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <
> > >>>>>>> gary.martin@wandisco.com
> > >>>>>>>
> > >>>>>>>  wrote:
> > >>>>>>
> > >>>>>>  Olemis Lang <ol...@gmail.com> wrote:
> > >>>>>>>>
> > >>>>>>>>   On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> > >>>>>>>>
> > >>>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
> > >>>>>>>>>>
> > >>>>>>>>>>  On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> > >>>>>>>>>>>
> > >>>>>>>>>>>  On 04.10.2012 18:33, Olemis Lang wrote:
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>  On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>>  On 04/10/12 16:54, Joachim Dreimann wrote:
> > >>>>>>>>>>>>>>
> > >>>>>>>>>>>>>>  On 4 Oct 2012, at 12:01, Gary Martin <
> > >>>>>>>>>>>>>>> gary.martin@wandisco.com
> > >>>>>>>>>>>>>>> wrote:
> > >>>>>>>>>>>>>>>
> > >>>>>>>>>>>>>>>  On 03/10/12 20:50, Olemis Lang wrote:
> > >>>>>>>>>>>>>>>> [...]
> > >>>>>>>>>>>>>>>>
> > >>>>>>>>>>>>>>> As a user using a web application with the server 50 hops
> > >>>>>>>>>>>> away
> > >>>>>>>>>>>> with
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>  a
> > >>>>>>>>>>>
> > >>>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every
> > click
> > >>>>>>>>>> I
> > >>>>>>>>>>
> > >>>>>>>>>>> make
> > >>>>>>>>>>>
> > >>>>>>>>>> generates a POST request to somewhere; even if it's an async
> XHR
> > >>>>>>>>>>
> > >>>>>>>>>>> (even
> > >>>>>>>>>>>
> > >>>>>>>>>> worse! then I don't know in what order the server actually
> > >>>>>>>>>> receives
> > >>>>>>>>>>
> > >>>>>>>>>>> the
> > >>>>>>>>>>>
> > >>>>>>>>>> requests).
> > >>>>>>>>>>
> > >>>>>>>>>>> ... if you take a look at #146 attachments you'll notice that
> > my
> > >>>>>>>>>>>
> > >>>>>>>>>>>  first
> > >>>>>>>>>> proposal included submit button for select fields . I was told
> > to
> > >>>>>>>>>>
> > >>>>>>>>>>> revert that .
> > >>>>>>>>>>>
> > >>>>>>>>>>>  Hmm. "Told to" implies hierarchy.
> > >>>>>>>>>>
> > >>>>>>>>>>  ... or respect to the opinions of the experts , and Joachim
> is
> > >>>>>>>>> the UI
> > >>>>>>>>> expert . When I have radical objections to other people's
> > thoughts
> > >>>>>>>>> and
> > >>>>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree
> > but
> > >>>>>>>>> there are underlying technical decisions that make it
> impossible
> > to
> > >>>>>>>>> realize some ideas then I express my opinion . This time I
> don't
> > >>>>>>>>> think
> > >>>>>>>>> it was the case . /me studying and learning about UI design ,
> etc
> > >>>>>>>>> ...
> > >>>>>>>>> but that's just work in progress . Hence most of the time I
> won't
> > >>>>>>>>> criticize UI decisions beyond «evident» issues I might notice.
> > >>>>>>>>>
> > >>>>>>>>> So to clarify my position , in this particular case i.e. #146
> , I
> > >>>>>>>>> declare myself a completely happy neophyte and *so far* I have
> no
> > >>>>>>>>> strong arguments in favor or against any of both approaches .
> > >>>>>>>>> Please
> > >>>>>>>>> get to an agreement . In the meantime , if I have something to
> > say
> > >>>>>>>>> I'll say it . Just let me know what needs to be done to
> continue
> > >>>>>>>>> work
> > >>>>>>>>> needed to finish patches  for #146 , please .
> > >>>>>>>>>
> > >>>>>>>>> ;)
> > >>>>>>>>>
> > >>>>>>>>>  This is why we need more decisions to be made here. No one
> > person
> > >>>>>>>> is
> > >>>>>>>>
> > >>>>>>>>  going
> > >>>>>>>
> > >>>>>> to be right on every decision.
> > >>>>>>
> > >>>>>>> For some reason I didn't get the impression from the discussion
> in
> > >>>>>>>> the
> > >>>>>>>> ticket that it would result in immediate edits. If more people
> > were
> > >>>>>>>> watching the discussion, this might have been caught earlier as
> > >>>>>>>>
> > >>>>>>>>  something
> > >>>>>>>
> > >>>>>> that people would frown upon. Maybe.
> > >>>>>>
> > >>>>>>> Anyway, personally I want to see in-place edits implemented such
> > that
> > >>>>>>>>
> > >>>>>>>>  the
> > >>>>>>>
> > >>>>>> changes are not sent immediately but should be submitted with a
> > single
> > >>>>>>
> > >>>>>>> button.
> > >>>>>>>>
> > >>>>>>>> I would probably be attempting to effectively use the existing
> > form
> > >>>>>>>> to
> > >>>>>>>> send the data - I suspect that at some point we will want the
> old
> > >>>>>>>> form
> > >>>>>>>> hidden but it should probably be available for js disabled
> > >>>>>>>> situations.
> > >>>>>>>>
> > >>>>>>>> For me, that would be enough work on the ticket. After that we
> can
> > >>>>>>>>
> > >>>>>>>>  build
> > >>>>>>>
> > >>>>>> on that work with things like indicating which fields are edited
> and
> > >>>>>>
> > >>>>>>> perhaps making it easier to comment on the changes (the comment
> > field
> > >>>>>>>>
> > >>>>>>>>  is
> > >>>>>>>
> > >>>>>> way down the page on long tickets). I would also be interested in
> > >>>>>>
> > >>>>>>> whether
> > >>>>>>>
> > >>>>>> people would want to see a confirmation that the user should move
> > away
> > >>>>>>
> > >>>>>>> from
> > >>>>>>>
> > >>>>>> a page when there are edits that are not submitted.
> > >>>>>>
> > >>>>>>> Cheers,
> > >>>>>>>>     Gary
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >
> >
>
>
>
> --
> Joe Dreimann
> UX Designer | WANdisco <http://www.wandisco.com/>
> *
> *
> *Transform your software development department. Register for a free SVN
> HealthCheck <http://go.wandisco.com/HealthCheck-Sig.html> *
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
Joe,

If we don't we could potentially provide a site map if it is considered
useful more generally. I quite like that solution, though I could equally
imagine that those links could still be somewhere on the page for no-js
situations. I suppose it could even still be quite discreet. Anyway, we
shouldn't think this through too far. Let's just make sure that there is
some fallback for now.

Cheers,
    Gary


On 27 November 2012 17:14, Joe Dreimann <jo...@wandisco.com>wrote:

> I like the fallback for the Quick Ticket button. For the Apps drop down,
> (we should really rename that to *More*) we could alternatively link to the
> site map (do we have a functional site map?).
>
> - Joe
>
> ________________________
> @jdreimann - Twitter
> Sent from my phone
>
> On 27 Nov 2012, at 16:54, Gary Martin <ga...@wandisco.com> wrote:
>
> > On 27/11/12 15:56, Olemis Lang wrote:
> >> On 11/26/12, Joachim Dreimann <jo...@wandisco.com> wrote:
> >>> On 26 November 2012 06:49, Peter Koželj <pe...@digiverse.si> wrote:
> >>>
> >>>> Not sure how much does support for javascript disabled browsers
> >>>> complicate
> >>>> things, but do we really care to support this when everybody is
> rushing
> >>>> to
> >>>> HTML5?
> >>>>
> >>>> I haven't that kind of requirement for a web application in the last 7
> >>>> years or so.
> >>> HTML5 and JavaScript are two different issues, most obviously because
> one
> >>> is a fix for the other: http://en.wikipedia.org/wiki/HTML5_Shiv
> >>> HTML5 will also take some of the weight off JavaScript going forward,
> for
> >>> example with contentEditable in this context:
> >>> http://html5demos.com/contenteditable
> >>>
> >>> Public sector organisations usually require all software to meet
> certain
> >>> accessibility standards, and I would suggest that we build to their
> most
> >>> basic standards at least. Screen readers often struggle with
> javascript, so
> >>> Gary's suggestion was to at least have JS-less fallback (the current
> edit
> >>> form). It's acceptable that this won't be pretty; most users will
> never see
> >>> it.
> >>
> >> Yes . Sometimes javascript solution is not available (e.g. disabled,
> >> blocked by firewalls, unexpected errors ...) and pages should fallback
> >> to non-JS behavior . There are even browsers like Netsurf built
> >> without JS support ...
> >>
> >> {{{
> >> #!sh
> >>
> >> $ apt-cache show netsurf
> >> Package: netsurf
> >> Priority: extra
> >> Section: universe/web
> >> Installed-Size: 1248
> >> [...]
> >> Description: Small portable web browser with CSS and Unicode support
> >>  NetSurf is a multi-platform lightweight web browser. Its aim is to
> provide
> >>  comprehensive rendering of HTML 4 with CSS 2 in a small resource
> footprint
> >>  while remaining fast.
> >> [...]
> >>
> >> }}}
> >>
> >> BTW , some parts of the site are not looking good on Netsurf . If that
> >> deserves some attention , please let me know to create a new ticket
> >> with screenshots .
> >>
> >> Unfortunately at the moment that also means that e.g. mainnav and
> >> create ticket shortcut menus won't work . We should take a look at
> >> that too .
> >
> >
> > Yeah, I suspected as much.
> >
> > Is there a particular reason that these buttons cannot fall back to
> being links? I wouldn't mind the Create Ticket button being a link to
> /newticket with the potential side effect of being able to open /newticket
> in a new tab. Actually, I can't think of a good place for the Apps to link
> to at short notice. Would there be any problems with having all the menu
> items visible, perhaps wrapping when there are too many, when js is not
> available?
> >
> > It does not need to be a particularly beautiful solution, we just need
> to let users access the links that they would otherwise lose. All without
> compromising on the experience for those with js enabled.
> >
> > Cheers,
> >    Gary
> >
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Joe Dreimann <jo...@wandisco.com>.
I like the fallback for the Quick Ticket button. For the Apps drop down, (we should really rename that to *More*) we could alternatively link to the site map (do we have a functional site map?).

- Joe

________________________
@jdreimann - Twitter
Sent from my phone

On 27 Nov 2012, at 16:54, Gary Martin <ga...@wandisco.com> wrote:

> On 27/11/12 15:56, Olemis Lang wrote:
>> On 11/26/12, Joachim Dreimann <jo...@wandisco.com> wrote:
>>> On 26 November 2012 06:49, Peter Koželj <pe...@digiverse.si> wrote:
>>> 
>>>> Not sure how much does support for javascript disabled browsers
>>>> complicate
>>>> things, but do we really care to support this when everybody is rushing
>>>> to
>>>> HTML5?
>>>> 
>>>> I haven't that kind of requirement for a web application in the last 7
>>>> years or so.
>>> HTML5 and JavaScript are two different issues, most obviously because one
>>> is a fix for the other: http://en.wikipedia.org/wiki/HTML5_Shiv
>>> HTML5 will also take some of the weight off JavaScript going forward, for
>>> example with contentEditable in this context:
>>> http://html5demos.com/contenteditable
>>> 
>>> Public sector organisations usually require all software to meet certain
>>> accessibility standards, and I would suggest that we build to their most
>>> basic standards at least. Screen readers often struggle with javascript, so
>>> Gary's suggestion was to at least have JS-less fallback (the current edit
>>> form). It's acceptable that this won't be pretty; most users will never see
>>> it.
>> 
>> Yes . Sometimes javascript solution is not available (e.g. disabled,
>> blocked by firewalls, unexpected errors ...) and pages should fallback
>> to non-JS behavior . There are even browsers like Netsurf built
>> without JS support ...
>> 
>> {{{
>> #!sh
>> 
>> $ apt-cache show netsurf
>> Package: netsurf
>> Priority: extra
>> Section: universe/web
>> Installed-Size: 1248
>> [...]
>> Description: Small portable web browser with CSS and Unicode support
>>  NetSurf is a multi-platform lightweight web browser. Its aim is to provide
>>  comprehensive rendering of HTML 4 with CSS 2 in a small resource footprint
>>  while remaining fast.
>> [...]
>> 
>> }}}
>> 
>> BTW , some parts of the site are not looking good on Netsurf . If that
>> deserves some attention , please let me know to create a new ticket
>> with screenshots .
>> 
>> Unfortunately at the moment that also means that e.g. mainnav and
>> create ticket shortcut menus won't work . We should take a look at
>> that too .
> 
> 
> Yeah, I suspected as much.
> 
> Is there a particular reason that these buttons cannot fall back to being links? I wouldn't mind the Create Ticket button being a link to /newticket with the potential side effect of being able to open /newticket in a new tab. Actually, I can't think of a good place for the Apps to link to at short notice. Would there be any problems with having all the menu items visible, perhaps wrapping when there are too many, when js is not available?
> 
> It does not need to be a particularly beautiful solution, we just need to let users access the links that they would otherwise lose. All without compromising on the experience for those with js enabled.
> 
> Cheers,
>    Gary
> 

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
On 27/11/12 15:56, Olemis Lang wrote:
> On 11/26/12, Joachim Dreimann <jo...@wandisco.com> wrote:
>> On 26 November 2012 06:49, Peter Koželj <pe...@digiverse.si> wrote:
>>
>>> Not sure how much does support for javascript disabled browsers
>>> complicate
>>> things, but do we really care to support this when everybody is rushing
>>> to
>>> HTML5?
>>>
>>> I haven't that kind of requirement for a web application in the last 7
>>> years or so.
>>>
>> HTML5 and JavaScript are two different issues, most obviously because one
>> is a fix for the other: http://en.wikipedia.org/wiki/HTML5_Shiv
>> HTML5 will also take some of the weight off JavaScript going forward, for
>> example with contentEditable in this context:
>> http://html5demos.com/contenteditable
>>
>> Public sector organisations usually require all software to meet certain
>> accessibility standards, and I would suggest that we build to their most
>> basic standards at least. Screen readers often struggle with javascript, so
>> Gary's suggestion was to at least have JS-less fallback (the current edit
>> form). It's acceptable that this won't be pretty; most users will never see
>> it.
>>
>
> Yes . Sometimes javascript solution is not available (e.g. disabled,
> blocked by firewalls, unexpected errors ...) and pages should fallback
> to non-JS behavior . There are even browsers like Netsurf built
> without JS support ...
>
> {{{
> #!sh
>
> $ apt-cache show netsurf
> Package: netsurf
> Priority: extra
> Section: universe/web
> Installed-Size: 1248
> [...]
> Description: Small portable web browser with CSS and Unicode support
>   NetSurf is a multi-platform lightweight web browser. Its aim is to provide
>   comprehensive rendering of HTML 4 with CSS 2 in a small resource footprint
>   while remaining fast.
> [...]
>
> }}}
>
> BTW , some parts of the site are not looking good on Netsurf . If that
> deserves some attention , please let me know to create a new ticket
> with screenshots .
>
> Unfortunately at the moment that also means that e.g. mainnav and
> create ticket shortcut menus won't work . We should take a look at
> that too .


Yeah, I suspected as much.

Is there a particular reason that these buttons cannot fall back to 
being links? I wouldn't mind the Create Ticket button being a link to 
/newticket with the potential side effect of being able to open 
/newticket in a new tab. Actually, I can't think of a good place for the 
Apps to link to at short notice. Would there be any problems with having 
all the menu items visible, perhaps wrapping when there are too many, 
when js is not available?

It does not need to be a particularly beautiful solution, we just need 
to let users access the links that they would otherwise lose. All 
without compromising on the experience for those with js enabled.

Cheers,
     Gary


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 11/26/12, Joachim Dreimann <jo...@wandisco.com> wrote:
> On 26 November 2012 06:49, Peter Koželj <pe...@digiverse.si> wrote:
>
>> Not sure how much does support for javascript disabled browsers
>> complicate
>> things, but do we really care to support this when everybody is rushing
>> to
>> HTML5?
>>
>> I haven't that kind of requirement for a web application in the last 7
>> years or so.
>>
> HTML5 and JavaScript are two different issues, most obviously because one
> is a fix for the other: http://en.wikipedia.org/wiki/HTML5_Shiv
> HTML5 will also take some of the weight off JavaScript going forward, for
> example with contentEditable in this context:
> http://html5demos.com/contenteditable
>
> Public sector organisations usually require all software to meet certain
> accessibility standards, and I would suggest that we build to their most
> basic standards at least. Screen readers often struggle with javascript, so
> Gary's suggestion was to at least have JS-less fallback (the current edit
> form). It's acceptable that this won't be pretty; most users will never see
> it.
>


Yes . Sometimes javascript solution is not available (e.g. disabled,
blocked by firewalls, unexpected errors ...) and pages should fallback
to non-JS behavior . There are even browsers like Netsurf built
without JS support ...

{{{
#!sh

$ apt-cache show netsurf
Package: netsurf
Priority: extra
Section: universe/web
Installed-Size: 1248
[...]
Description: Small portable web browser with CSS and Unicode support
 NetSurf is a multi-platform lightweight web browser. Its aim is to provide
 comprehensive rendering of HTML 4 with CSS 2 in a small resource footprint
 while remaining fast.
[...]

}}}

BTW , some parts of the site are not looking good on Netsurf . If that
deserves some attention , please let me know to create a new ticket
with screenshots .

Unfortunately at the moment that also means that e.g. mainnav and
create ticket shortcut menus won't work . We should take a look at
that too .

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Joachim Dreimann <jo...@wandisco.com>.
HTML5 and JavaScript are two different issues, most obviously because one
is a fix for the other: http://en.wikipedia.org/wiki/HTML5_Shiv
HTML5 will also take some of the weight off JavaScript going forward, for
example with contentEditable in this context:
http://html5demos.com/contenteditable

Public sector organisations usually require all software to meet certain
accessibility standards, and I would suggest that we build to their most
basic standards at least. Screen readers often struggle with javascript, so
Gary's suggestion was to at least have JS-less fallback (the current edit
form). It's acceptable that this won't be pretty; most users will never see
it.

- Joe


On 26 November 2012 06:49, Peter Koželj <pe...@digiverse.si> wrote:

> Not sure how much does support for javascript disabled browsers complicate
> things, but do we really care to support this when everybody is rushing to
> HTML5?
>
> I haven't that kind of requirement for a web application in the last 7
> years or so.
>
> Peter
>
> On 23 November 2012 19:50, Gary Martin <ga...@wandisco.com> wrote:
>
> > OK,
> >
> > Given the lack of further discussion, I will attempt to propose a
> solution
> > that begins to fit the requirements:
> >
> > 1. Initial access to a page shows the potentially editable fields in
> >    the view state which should more or less match the current view
> >    subject to differences specified below
> > 2. If the user has the appropriate permissions to modify the ticket, a
> >    button is added to toggle between editable and view states (keyboard
> >    shortcuts for these actions would also be nice enhancements for
> later.)
> > 3. In the editable state, all fields will be changed to the appropriate
> >    kind of control for the field
> >      * Any fields that the user does not have permission to change
> >        should be locked in a way that is obvious - I would probably say
> >        that it is better to be changed to a locked control to make it
> >        feel that it is locked on purpose
> > 4. A field that is changed relative to the original state should
> >    provide an indication of this status in both edit and view states.
> > 5. A submit button should be available from either edit or view states
> >    - active when there are changes that can be submitted.
> > 6. For javascript turned off on the browser, behaviour should revert
> >    back to the current separate form with an appropriate links to skip
> >    down to it. With javascript on, the form is hidden and the
> >    associated navigation item is then not required.
> >
> > Or something like that. So, apart from a clear idea of how we clearly
> mark
> > fields as edited, are there any other holes in this? It is also worth
> > considering if this fits with the current mechanisms for guarding against
> > conflicts dues to concurrent edits.
> >
> > Cheers,
> >     Gary
> >
> >
> > On 06/11/12 06:08, Peter Koželj wrote:
> >
> >> On 5 November 2012 16:17, Jure Zitnik <ju...@digiverse.si> wrote:
> >>
> >>  On 11/5/12 12:44 PM, Gary Martin wrote:
> >>>
> >>>  Individual confirmation on every field? That sounds like the same
> thing
> >>>> as
> >>>> an immediate save. I think that so far the consensus is that we don't
> >>>> want
> >>>> that.
> >>>>
> >>>>  +1
> >>>
> >>      +1
> >>
> >>
> >>>   I've been using a few developers at apachecon as sounding boards as I
> >>> am
> >>>
> >>>> worried that things might be more complicated than necessary. The
> >>>> solution
> >>>> that would seem most efficient would be that all the fields that are
> >>>> editable are considered to be in an editable state already. The
> problem
> >>>> with this is then how it is made abundantly clear that a field is
> >>>> editable
> >>>> - and it would be nice to see when a field has been edited too.
> >>>>
> >>>> I am not yet convinced that a button to make all fields editable is
> the
> >>>> right approach at the moment - it seems like a step you shouldn't
> need.
> >>>>
> >>>>  I think that the ticket could be shown as read only initially, with
> the
> >>> scroll spy component being visible from start (I think that was
> discussed
> >>> in another thread already). As the scroll spy already includes the
> >>> 'Modify
> >>> ticket' button, clicking that button would enable 'edit mode' which
> would
> >>> replace ticket fields inline (read only for editable) - that is, w/o
> >>> scrolling to the 'Modify ticket' section. So, I would go for one button
> >>> to
> >>> enable the 'edit' state and one button for submission.
> >>>
> >>
> >> +100 :)
> >>
> >>
> >>
> >>>   Other than that, a submit all changes button would probably work
> well.
> >>> +1
> >>>
> >>>       +1
> >>
> >>  Cheers,
> >>> Jure
> >>>
> >>>
> >>>   Cheers,
> >>>
> >>>>       Gary
> >>>>
> >>>> On 5 November 2012 10:21, Joachim Dreimann <
> >>>> joachim.dreimann@wandisco.com
> >>>> **>wrote:
> >>>>
> >>>>
> >>>>   I notice that there were no replies to my last message (see below)
> and
> >>>>
> >>>>> the
> >>>>> ticket has therefore been put on hold. We've made no progress in a
> >>>>> whole
> >>>>> month on an issue all seemed to agree was important.
> >>>>>
> >>>>> The question remains:
> >>>>>
> >>>>>  Should we enable the 'edit' state for all fields using one button
> and
> >>>>>>
> >>>>>>  submit using one button, or should we take Jira's approach of
> asking
> >>>>> for
> >>>>> individual confirmation on every field?
> >>>>>
> >>>>>
> >>>>> - Joe
> >>>>>
> >>>>> On 5 Oct 2012, at 20:10, Joe Dreimann <joachim.dreimann@wandisco.com
> **
> >>>>> **>
> >>>>>
> >>>>> wrote:
> >>>>>
> >>>>>   Ok, that sounds like we have a decision: All are in favour of
> >>>>> non-immediate saves for edits.
> >>>>>
> >>>>>  Now, should we enable the 'edit' state for all fields using one
> button
> >>>>>>
> >>>>>>  and submit using one button, or should we take Jira's approach of
> >>>>> asking
> >>>>> for individual confirmation on every field?
> >>>>>
> >>>>>    http://www.youtube.com/watch?****feature=player_detailpage&v=****
> <http://www.youtube.com/watch?**feature=player_detailpage&v=**>
> >>>>>>
> >>>>> EsQ__dR6Nrw#t=59s<http://www.**youtube.com/watch?feature=**
> >>>>> player_detailpage&v=EsQ__**dR6Nrw#t=59s<
> http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s
> >
> >>>>> >
> >>>>>
> >>>>>
> >>>>>  I'm bringing up Jira because it's used in a very similar context as
> >>>>>>
> >>>>>>  Bloodhound.
> >>>>>
> >>>>>  Cheers,
> >>>>>> Joe
> >>>>>>
> >>>>>> ________________________
> >>>>>> @jdreimann - Twitter
> >>>>>> Sent from my phone
> >>>>>>
> >>>>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
> >>>>>>
> >>>>>>   I too am strongly against inline editing causing auto-save. Ticket
> >>>>>>
> >>>>>>> changes must be intended and atomical!
> >>>>>>> 1. Tickets are versioned and this messes up the ticket history
> >>>>>>> 2. Multiple ticket notifications get sent out
> >>>>>>> 3. Any ticket statistics get incorrect
> >>>>>>> 4. In bigger enterprise environments tracking systems are
> integrated
> >>>>>>>
> >>>>>>>  with
> >>>>>> other infrastructure, which means unintended inconsistencies are
> >>>>>> propagated
> >>>>>> to other systems as well
> >>>>>>
> >>>>>>> 5. Companies will offen grant their customers access to tracking
> >>>>>>> system
> >>>>>>>
> >>>>>>>  and
> >>>>>> last person that I want to burdon with this, is my client.
> >>>>>>
> >>>>>>> 6. If this works only for half of the tickt's fields, it is
> >>>>>>>
> >>>>>>>  inconsistent!
> >>>>>> And the problem will just be worse when we try to get rid of that
> >>>>>> "Modify"
> >>>>>> section.
> >>>>>>
> >>>>>>> I do find the proposed concept appealing for things like user
> >>>>>>>
> >>>>>>>  preferences
> >>>>>> but even for that we would need to weight pros and cons.
> >>>>>>
> >>>>>>> Peter
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <
> >>>>>>> gary.martin@wandisco.com
> >>>>>>>
> >>>>>>>  wrote:
> >>>>>>
> >>>>>>  Olemis Lang <ol...@gmail.com> wrote:
> >>>>>>>>
> >>>>>>>>   On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> >>>>>>>>
> >>>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
> >>>>>>>>>>
> >>>>>>>>>>  On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>  On 04.10.2012 18:33, Olemis Lang wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>  On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>  On 04/10/12 16:54, Joachim Dreimann wrote:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>  On 4 Oct 2012, at 12:01, Gary Martin <
> >>>>>>>>>>>>>>> gary.martin@wandisco.com
> >>>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>  On 03/10/12 20:50, Olemis Lang wrote:
> >>>>>>>>>>>>>>>> [...]
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> As a user using a web application with the server 50 hops
> >>>>>>>>>>>> away
> >>>>>>>>>>>> with
> >>>>>>>>>>>>
> >>>>>>>>>>>>  a
> >>>>>>>>>>>
> >>>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every
> click
> >>>>>>>>>> I
> >>>>>>>>>>
> >>>>>>>>>>> make
> >>>>>>>>>>>
> >>>>>>>>>> generates a POST request to somewhere; even if it's an async XHR
> >>>>>>>>>>
> >>>>>>>>>>> (even
> >>>>>>>>>>>
> >>>>>>>>>> worse! then I don't know in what order the server actually
> >>>>>>>>>> receives
> >>>>>>>>>>
> >>>>>>>>>>> the
> >>>>>>>>>>>
> >>>>>>>>>> requests).
> >>>>>>>>>>
> >>>>>>>>>>> ... if you take a look at #146 attachments you'll notice that
> my
> >>>>>>>>>>>
> >>>>>>>>>>>  first
> >>>>>>>>>> proposal included submit button for select fields . I was told
> to
> >>>>>>>>>>
> >>>>>>>>>>> revert that .
> >>>>>>>>>>>
> >>>>>>>>>>>  Hmm. "Told to" implies hierarchy.
> >>>>>>>>>>
> >>>>>>>>>>  ... or respect to the opinions of the experts , and Joachim is
> >>>>>>>>> the UI
> >>>>>>>>> expert . When I have radical objections to other people's
> thoughts
> >>>>>>>>> and
> >>>>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree
> but
> >>>>>>>>> there are underlying technical decisions that make it impossible
> to
> >>>>>>>>> realize some ideas then I express my opinion . This time I don't
> >>>>>>>>> think
> >>>>>>>>> it was the case . /me studying and learning about UI design , etc
> >>>>>>>>> ...
> >>>>>>>>> but that's just work in progress . Hence most of the time I won't
> >>>>>>>>> criticize UI decisions beyond «evident» issues I might notice.
> >>>>>>>>>
> >>>>>>>>> So to clarify my position , in this particular case i.e. #146 , I
> >>>>>>>>> declare myself a completely happy neophyte and *so far* I have no
> >>>>>>>>> strong arguments in favor or against any of both approaches .
> >>>>>>>>> Please
> >>>>>>>>> get to an agreement . In the meantime , if I have something to
> say
> >>>>>>>>> I'll say it . Just let me know what needs to be done to continue
> >>>>>>>>> work
> >>>>>>>>> needed to finish patches  for #146 , please .
> >>>>>>>>>
> >>>>>>>>> ;)
> >>>>>>>>>
> >>>>>>>>>  This is why we need more decisions to be made here. No one
> person
> >>>>>>>> is
> >>>>>>>>
> >>>>>>>>  going
> >>>>>>>
> >>>>>> to be right on every decision.
> >>>>>>
> >>>>>>> For some reason I didn't get the impression from the discussion in
> >>>>>>>> the
> >>>>>>>> ticket that it would result in immediate edits. If more people
> were
> >>>>>>>> watching the discussion, this might have been caught earlier as
> >>>>>>>>
> >>>>>>>>  something
> >>>>>>>
> >>>>>> that people would frown upon. Maybe.
> >>>>>>
> >>>>>>> Anyway, personally I want to see in-place edits implemented such
> that
> >>>>>>>>
> >>>>>>>>  the
> >>>>>>>
> >>>>>> changes are not sent immediately but should be submitted with a
> single
> >>>>>>
> >>>>>>> button.
> >>>>>>>>
> >>>>>>>> I would probably be attempting to effectively use the existing
> form
> >>>>>>>> to
> >>>>>>>> send the data - I suspect that at some point we will want the old
> >>>>>>>> form
> >>>>>>>> hidden but it should probably be available for js disabled
> >>>>>>>> situations.
> >>>>>>>>
> >>>>>>>> For me, that would be enough work on the ticket. After that we can
> >>>>>>>>
> >>>>>>>>  build
> >>>>>>>
> >>>>>> on that work with things like indicating which fields are edited and
> >>>>>>
> >>>>>>> perhaps making it easier to comment on the changes (the comment
> field
> >>>>>>>>
> >>>>>>>>  is
> >>>>>>>
> >>>>>> way down the page on long tickets). I would also be interested in
> >>>>>>
> >>>>>>> whether
> >>>>>>>
> >>>>>> people would want to see a confirmation that the user should move
> away
> >>>>>>
> >>>>>>> from
> >>>>>>>
> >>>>>> a page when there are edits that are not submitted.
> >>>>>>
> >>>>>>> Cheers,
> >>>>>>>>     Gary
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >
>



-- 
Joe Dreimann
UX Designer | WANdisco <http://www.wandisco.com/>
*
*
*Transform your software development department. Register for a free SVN
HealthCheck <http://go.wandisco.com/HealthCheck-Sig.html> *

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Peter Koželj <pe...@digiverse.si>.
Not sure how much does support for javascript disabled browsers complicate
things, but do we really care to support this when everybody is rushing to
HTML5?

I haven't that kind of requirement for a web application in the last 7
years or so.

Peter

On 23 November 2012 19:50, Gary Martin <ga...@wandisco.com> wrote:

> OK,
>
> Given the lack of further discussion, I will attempt to propose a solution
> that begins to fit the requirements:
>
> 1. Initial access to a page shows the potentially editable fields in
>    the view state which should more or less match the current view
>    subject to differences specified below
> 2. If the user has the appropriate permissions to modify the ticket, a
>    button is added to toggle between editable and view states (keyboard
>    shortcuts for these actions would also be nice enhancements for later.)
> 3. In the editable state, all fields will be changed to the appropriate
>    kind of control for the field
>      * Any fields that the user does not have permission to change
>        should be locked in a way that is obvious - I would probably say
>        that it is better to be changed to a locked control to make it
>        feel that it is locked on purpose
> 4. A field that is changed relative to the original state should
>    provide an indication of this status in both edit and view states.
> 5. A submit button should be available from either edit or view states
>    - active when there are changes that can be submitted.
> 6. For javascript turned off on the browser, behaviour should revert
>    back to the current separate form with an appropriate links to skip
>    down to it. With javascript on, the form is hidden and the
>    associated navigation item is then not required.
>
> Or something like that. So, apart from a clear idea of how we clearly mark
> fields as edited, are there any other holes in this? It is also worth
> considering if this fits with the current mechanisms for guarding against
> conflicts dues to concurrent edits.
>
> Cheers,
>     Gary
>
>
> On 06/11/12 06:08, Peter Koželj wrote:
>
>> On 5 November 2012 16:17, Jure Zitnik <ju...@digiverse.si> wrote:
>>
>>  On 11/5/12 12:44 PM, Gary Martin wrote:
>>>
>>>  Individual confirmation on every field? That sounds like the same thing
>>>> as
>>>> an immediate save. I think that so far the consensus is that we don't
>>>> want
>>>> that.
>>>>
>>>>  +1
>>>
>>      +1
>>
>>
>>>   I've been using a few developers at apachecon as sounding boards as I
>>> am
>>>
>>>> worried that things might be more complicated than necessary. The
>>>> solution
>>>> that would seem most efficient would be that all the fields that are
>>>> editable are considered to be in an editable state already. The problem
>>>> with this is then how it is made abundantly clear that a field is
>>>> editable
>>>> - and it would be nice to see when a field has been edited too.
>>>>
>>>> I am not yet convinced that a button to make all fields editable is the
>>>> right approach at the moment - it seems like a step you shouldn't need.
>>>>
>>>>  I think that the ticket could be shown as read only initially, with the
>>> scroll spy component being visible from start (I think that was discussed
>>> in another thread already). As the scroll spy already includes the
>>> 'Modify
>>> ticket' button, clicking that button would enable 'edit mode' which would
>>> replace ticket fields inline (read only for editable) - that is, w/o
>>> scrolling to the 'Modify ticket' section. So, I would go for one button
>>> to
>>> enable the 'edit' state and one button for submission.
>>>
>>
>> +100 :)
>>
>>
>>
>>>   Other than that, a submit all changes button would probably work well.
>>> +1
>>>
>>>       +1
>>
>>  Cheers,
>>> Jure
>>>
>>>
>>>   Cheers,
>>>
>>>>       Gary
>>>>
>>>> On 5 November 2012 10:21, Joachim Dreimann <
>>>> joachim.dreimann@wandisco.com
>>>> **>wrote:
>>>>
>>>>
>>>>   I notice that there were no replies to my last message (see below) and
>>>>
>>>>> the
>>>>> ticket has therefore been put on hold. We've made no progress in a
>>>>> whole
>>>>> month on an issue all seemed to agree was important.
>>>>>
>>>>> The question remains:
>>>>>
>>>>>  Should we enable the 'edit' state for all fields using one button and
>>>>>>
>>>>>>  submit using one button, or should we take Jira's approach of asking
>>>>> for
>>>>> individual confirmation on every field?
>>>>>
>>>>>
>>>>> - Joe
>>>>>
>>>>> On 5 Oct 2012, at 20:10, Joe Dreimann <joachim.dreimann@wandisco.com**
>>>>> **>
>>>>>
>>>>> wrote:
>>>>>
>>>>>   Ok, that sounds like we have a decision: All are in favour of
>>>>> non-immediate saves for edits.
>>>>>
>>>>>  Now, should we enable the 'edit' state for all fields using one button
>>>>>>
>>>>>>  and submit using one button, or should we take Jira's approach of
>>>>> asking
>>>>> for individual confirmation on every field?
>>>>>
>>>>>    http://www.youtube.com/watch?****feature=player_detailpage&v=****<http://www.youtube.com/watch?**feature=player_detailpage&v=**>
>>>>>>
>>>>> EsQ__dR6Nrw#t=59s<http://www.**youtube.com/watch?feature=**
>>>>> player_detailpage&v=EsQ__**dR6Nrw#t=59s<http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s>
>>>>> >
>>>>>
>>>>>
>>>>>  I'm bringing up Jira because it's used in a very similar context as
>>>>>>
>>>>>>  Bloodhound.
>>>>>
>>>>>  Cheers,
>>>>>> Joe
>>>>>>
>>>>>> ________________________
>>>>>> @jdreimann - Twitter
>>>>>> Sent from my phone
>>>>>>
>>>>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
>>>>>>
>>>>>>   I too am strongly against inline editing causing auto-save. Ticket
>>>>>>
>>>>>>> changes must be intended and atomical!
>>>>>>> 1. Tickets are versioned and this messes up the ticket history
>>>>>>> 2. Multiple ticket notifications get sent out
>>>>>>> 3. Any ticket statistics get incorrect
>>>>>>> 4. In bigger enterprise environments tracking systems are integrated
>>>>>>>
>>>>>>>  with
>>>>>> other infrastructure, which means unintended inconsistencies are
>>>>>> propagated
>>>>>> to other systems as well
>>>>>>
>>>>>>> 5. Companies will offen grant their customers access to tracking
>>>>>>> system
>>>>>>>
>>>>>>>  and
>>>>>> last person that I want to burdon with this, is my client.
>>>>>>
>>>>>>> 6. If this works only for half of the tickt's fields, it is
>>>>>>>
>>>>>>>  inconsistent!
>>>>>> And the problem will just be worse when we try to get rid of that
>>>>>> "Modify"
>>>>>> section.
>>>>>>
>>>>>>> I do find the proposed concept appealing for things like user
>>>>>>>
>>>>>>>  preferences
>>>>>> but even for that we would need to weight pros and cons.
>>>>>>
>>>>>>> Peter
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <
>>>>>>> gary.martin@wandisco.com
>>>>>>>
>>>>>>>  wrote:
>>>>>>
>>>>>>  Olemis Lang <ol...@gmail.com> wrote:
>>>>>>>>
>>>>>>>>   On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>
>>>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>>>>>>>
>>>>>>>>>>  On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>  On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>  On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>  On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>  On 4 Oct 2012, at 12:01, Gary Martin <
>>>>>>>>>>>>>>> gary.martin@wandisco.com
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>  On 03/10/12 20:50, Olemis Lang wrote:
>>>>>>>>>>>>>>>> [...]
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> As a user using a web application with the server 50 hops
>>>>>>>>>>>> away
>>>>>>>>>>>> with
>>>>>>>>>>>>
>>>>>>>>>>>>  a
>>>>>>>>>>>
>>>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click
>>>>>>>>>> I
>>>>>>>>>>
>>>>>>>>>>> make
>>>>>>>>>>>
>>>>>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>>>>>>>>>
>>>>>>>>>>> (even
>>>>>>>>>>>
>>>>>>>>>> worse! then I don't know in what order the server actually
>>>>>>>>>> receives
>>>>>>>>>>
>>>>>>>>>>> the
>>>>>>>>>>>
>>>>>>>>>> requests).
>>>>>>>>>>
>>>>>>>>>>> ... if you take a look at #146 attachments you'll notice that my
>>>>>>>>>>>
>>>>>>>>>>>  first
>>>>>>>>>> proposal included submit button for select fields . I was told to
>>>>>>>>>>
>>>>>>>>>>> revert that .
>>>>>>>>>>>
>>>>>>>>>>>  Hmm. "Told to" implies hierarchy.
>>>>>>>>>>
>>>>>>>>>>  ... or respect to the opinions of the experts , and Joachim is
>>>>>>>>> the UI
>>>>>>>>> expert . When I have radical objections to other people's thoughts
>>>>>>>>> and
>>>>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>>>>>>>> there are underlying technical decisions that make it impossible to
>>>>>>>>> realize some ideas then I express my opinion . This time I don't
>>>>>>>>> think
>>>>>>>>> it was the case . /me studying and learning about UI design , etc
>>>>>>>>> ...
>>>>>>>>> but that's just work in progress . Hence most of the time I won't
>>>>>>>>> criticize UI decisions beyond «evident» issues I might notice.
>>>>>>>>>
>>>>>>>>> So to clarify my position , in this particular case i.e. #146 , I
>>>>>>>>> declare myself a completely happy neophyte and *so far* I have no
>>>>>>>>> strong arguments in favor or against any of both approaches .
>>>>>>>>> Please
>>>>>>>>> get to an agreement . In the meantime , if I have something to say
>>>>>>>>> I'll say it . Just let me know what needs to be done to continue
>>>>>>>>> work
>>>>>>>>> needed to finish patches  for #146 , please .
>>>>>>>>>
>>>>>>>>> ;)
>>>>>>>>>
>>>>>>>>>  This is why we need more decisions to be made here. No one person
>>>>>>>> is
>>>>>>>>
>>>>>>>>  going
>>>>>>>
>>>>>> to be right on every decision.
>>>>>>
>>>>>>> For some reason I didn't get the impression from the discussion in
>>>>>>>> the
>>>>>>>> ticket that it would result in immediate edits. If more people were
>>>>>>>> watching the discussion, this might have been caught earlier as
>>>>>>>>
>>>>>>>>  something
>>>>>>>
>>>>>> that people would frown upon. Maybe.
>>>>>>
>>>>>>> Anyway, personally I want to see in-place edits implemented such that
>>>>>>>>
>>>>>>>>  the
>>>>>>>
>>>>>> changes are not sent immediately but should be submitted with a single
>>>>>>
>>>>>>> button.
>>>>>>>>
>>>>>>>> I would probably be attempting to effectively use the existing form
>>>>>>>> to
>>>>>>>> send the data - I suspect that at some point we will want the old
>>>>>>>> form
>>>>>>>> hidden but it should probably be available for js disabled
>>>>>>>> situations.
>>>>>>>>
>>>>>>>> For me, that would be enough work on the ticket. After that we can
>>>>>>>>
>>>>>>>>  build
>>>>>>>
>>>>>> on that work with things like indicating which fields are edited and
>>>>>>
>>>>>>> perhaps making it easier to comment on the changes (the comment field
>>>>>>>>
>>>>>>>>  is
>>>>>>>
>>>>>> way down the page on long tickets). I would also be interested in
>>>>>>
>>>>>>> whether
>>>>>>>
>>>>>> people would want to see a confirmation that the user should move away
>>>>>>
>>>>>>> from
>>>>>>>
>>>>>> a page when there are edits that are not submitted.
>>>>>>
>>>>>>> Cheers,
>>>>>>>>     Gary
>>>>>>>>
>>>>>>>>
>>>>>>>>
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
OK,

Given the lack of further discussion, I will attempt to propose a 
solution that begins to fit the requirements:

 1. Initial access to a page shows the potentially editable fields in
    the view state which should more or less match the current view
    subject to differences specified below
 2. If the user has the appropriate permissions to modify the ticket, a
    button is added to toggle between editable and view states (keyboard
    shortcuts for these actions would also be nice enhancements for later.)
 3. In the editable state, all fields will be changed to the appropriate
    kind of control for the field
      * Any fields that the user does not have permission to change
        should be locked in a way that is obvious - I would probably say
        that it is better to be changed to a locked control to make it
        feel that it is locked on purpose
 4. A field that is changed relative to the original state should
    provide an indication of this status in both edit and view states.
 5. A submit button should be available from either edit or view states
    - active when there are changes that can be submitted.
 6. For javascript turned off on the browser, behaviour should revert
    back to the current separate form with an appropriate links to skip
    down to it. With javascript on, the form is hidden and the
    associated navigation item is then not required.

Or something like that. So, apart from a clear idea of how we clearly 
mark fields as edited, are there any other holes in this? It is also 
worth considering if this fits with the current mechanisms for guarding 
against conflicts dues to concurrent edits.

Cheers,
     Gary

On 06/11/12 06:08, Peter Koželj wrote:
> On 5 November 2012 16:17, Jure Zitnik <ju...@digiverse.si> wrote:
>
>> On 11/5/12 12:44 PM, Gary Martin wrote:
>>
>>> Individual confirmation on every field? That sounds like the same thing as
>>> an immediate save. I think that so far the consensus is that we don't want
>>> that.
>>>
>> +1
>      +1
>
>>
>>   I've been using a few developers at apachecon as sounding boards as I am
>>> worried that things might be more complicated than necessary. The solution
>>> that would seem most efficient would be that all the fields that are
>>> editable are considered to be in an editable state already. The problem
>>> with this is then how it is made abundantly clear that a field is editable
>>> - and it would be nice to see when a field has been edited too.
>>>
>>> I am not yet convinced that a button to make all fields editable is the
>>> right approach at the moment - it seems like a step you shouldn't need.
>>>
>> I think that the ticket could be shown as read only initially, with the
>> scroll spy component being visible from start (I think that was discussed
>> in another thread already). As the scroll spy already includes the 'Modify
>> ticket' button, clicking that button would enable 'edit mode' which would
>> replace ticket fields inline (read only for editable) - that is, w/o
>> scrolling to the 'Modify ticket' section. So, I would go for one button to
>> enable the 'edit' state and one button for submission.
>
> +100 :)
>
>
>>
>>   Other than that, a submit all changes button would probably work well.
>> +1
>>
>      +1
>
>> Cheers,
>> Jure
>>
>>
>>   Cheers,
>>>       Gary
>>>
>>> On 5 November 2012 10:21, Joachim Dreimann <joachim.dreimann@wandisco.com
>>> **>wrote:
>>>
>>>   I notice that there were no replies to my last message (see below) and
>>>> the
>>>> ticket has therefore been put on hold. We've made no progress in a whole
>>>> month on an issue all seemed to agree was important.
>>>>
>>>> The question remains:
>>>>
>>>>> Should we enable the 'edit' state for all fields using one button and
>>>>>
>>>> submit using one button, or should we take Jira's approach of asking for
>>>> individual confirmation on every field?
>>>>
>>>>
>>>> - Joe
>>>>
>>>> On 5 Oct 2012, at 20:10, Joe Dreimann <joachim.dreimann@wandisco.com**>
>>>> wrote:
>>>>
>>>>   Ok, that sounds like we have a decision: All are in favour of
>>>> non-immediate saves for edits.
>>>>
>>>>> Now, should we enable the 'edit' state for all fields using one button
>>>>>
>>>> and submit using one button, or should we take Jira's approach of asking
>>>> for individual confirmation on every field?
>>>>
>>>>>   http://www.youtube.com/watch?**feature=player_detailpage&v=**
>>>> EsQ__dR6Nrw#t=59s<http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s>
>>>>
>>>>> I'm bringing up Jira because it's used in a very similar context as
>>>>>
>>>> Bloodhound.
>>>>
>>>>> Cheers,
>>>>> Joe
>>>>>
>>>>> ________________________
>>>>> @jdreimann - Twitter
>>>>> Sent from my phone
>>>>>
>>>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
>>>>>
>>>>>   I too am strongly against inline editing causing auto-save. Ticket
>>>>>> changes must be intended and atomical!
>>>>>> 1. Tickets are versioned and this messes up the ticket history
>>>>>> 2. Multiple ticket notifications get sent out
>>>>>> 3. Any ticket statistics get incorrect
>>>>>> 4. In bigger enterprise environments tracking systems are integrated
>>>>>>
>>>>> with
>>>>> other infrastructure, which means unintended inconsistencies are
>>>>> propagated
>>>>> to other systems as well
>>>>>> 5. Companies will offen grant their customers access to tracking system
>>>>>>
>>>>> and
>>>>> last person that I want to burdon with this, is my client.
>>>>>> 6. If this works only for half of the tickt's fields, it is
>>>>>>
>>>>> inconsistent!
>>>>> And the problem will just be worse when we try to get rid of that
>>>>> "Modify"
>>>>> section.
>>>>>> I do find the proposed concept appealing for things like user
>>>>>>
>>>>> preferences
>>>>> but even for that we would need to weight pros and cons.
>>>>>> Peter
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <gary.martin@wandisco.com
>>>>>>
>>>>> wrote:
>>>>>
>>>>>>> Olemis Lang <ol...@gmail.com> wrote:
>>>>>>>
>>>>>>>   On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>>>>>>
>>>>>>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>>>>>>
>>>>>>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <gary.martin@wandisco.com
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>>>>>>>>>>>> [...]
>>>>>>>>>>> As a user using a web application with the server 50 hops away
>>>>>>>>>>> with
>>>>>>>>>>>
>>>>>>>>>> a
>>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>>>>>>>>>> make
>>>>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>>>>>>>>> (even
>>>>>>>>> worse! then I don't know in what order the server actually receives
>>>>>>>>>> the
>>>>>>>>> requests).
>>>>>>>>>> ... if you take a look at #146 attachments you'll notice that my
>>>>>>>>>>
>>>>>>>>> first
>>>>>>>>> proposal included submit button for select fields . I was told to
>>>>>>>>>> revert that .
>>>>>>>>>>
>>>>>>>>> Hmm. "Told to" implies hierarchy.
>>>>>>>>>
>>>>>>>> ... or respect to the opinions of the experts , and Joachim is the UI
>>>>>>>> expert . When I have radical objections to other people's thoughts
>>>>>>>> and
>>>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>>>>>>> there are underlying technical decisions that make it impossible to
>>>>>>>> realize some ideas then I express my opinion . This time I don't
>>>>>>>> think
>>>>>>>> it was the case . /me studying and learning about UI design , etc ...
>>>>>>>> but that's just work in progress . Hence most of the time I won't
>>>>>>>> criticize UI decisions beyond «evident» issues I might notice.
>>>>>>>>
>>>>>>>> So to clarify my position , in this particular case i.e. #146 , I
>>>>>>>> declare myself a completely happy neophyte and *so far* I have no
>>>>>>>> strong arguments in favor or against any of both approaches . Please
>>>>>>>> get to an agreement . In the meantime , if I have something to say
>>>>>>>> I'll say it . Just let me know what needs to be done to continue work
>>>>>>>> needed to finish patches  for #146 , please .
>>>>>>>>
>>>>>>>> ;)
>>>>>>>>
>>>>>>> This is why we need more decisions to be made here. No one person is
>>>>>>>
>>>>>> going
>>>>> to be right on every decision.
>>>>>>> For some reason I didn't get the impression from the discussion in the
>>>>>>> ticket that it would result in immediate edits. If more people were
>>>>>>> watching the discussion, this might have been caught earlier as
>>>>>>>
>>>>>> something
>>>>> that people would frown upon. Maybe.
>>>>>>> Anyway, personally I want to see in-place edits implemented such that
>>>>>>>
>>>>>> the
>>>>> changes are not sent immediately but should be submitted with a single
>>>>>>> button.
>>>>>>>
>>>>>>> I would probably be attempting to effectively use the existing form to
>>>>>>> send the data - I suspect that at some point we will want the old form
>>>>>>> hidden but it should probably be available for js disabled situations.
>>>>>>>
>>>>>>> For me, that would be enough work on the ticket. After that we can
>>>>>>>
>>>>>> build
>>>>> on that work with things like indicating which fields are edited and
>>>>>>> perhaps making it easier to comment on the changes (the comment field
>>>>>>>
>>>>>> is
>>>>> way down the page on long tickets). I would also be interested in
>>>>>> whether
>>>>> people would want to see a confirmation that the user should move away
>>>>>> from
>>>>> a page when there are edits that are not submitted.
>>>>>>> Cheers,
>>>>>>>     Gary
>>>>>>>
>>>>>>>


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Peter Koželj <pe...@digiverse.si>.
On 5 November 2012 16:17, Jure Zitnik <ju...@digiverse.si> wrote:

> On 11/5/12 12:44 PM, Gary Martin wrote:
>
>> Individual confirmation on every field? That sounds like the same thing as
>> an immediate save. I think that so far the consensus is that we don't want
>> that.
>>
>
> +1

    +1

>
>
>  I've been using a few developers at apachecon as sounding boards as I am
>> worried that things might be more complicated than necessary. The solution
>> that would seem most efficient would be that all the fields that are
>> editable are considered to be in an editable state already. The problem
>> with this is then how it is made abundantly clear that a field is editable
>> - and it would be nice to see when a field has been edited too.
>>
>> I am not yet convinced that a button to make all fields editable is the
>> right approach at the moment - it seems like a step you shouldn't need.
>>
>
> I think that the ticket could be shown as read only initially, with the
> scroll spy component being visible from start (I think that was discussed
> in another thread already). As the scroll spy already includes the 'Modify
> ticket' button, clicking that button would enable 'edit mode' which would
> replace ticket fields inline (read only for editable) - that is, w/o
> scrolling to the 'Modify ticket' section. So, I would go for one button to
> enable the 'edit' state and one button for submission.


+100 :)


>
>
>  Other than that, a submit all changes button would probably work well.
>>
> +1
>
    +1

>
> Cheers,
> Jure
>
>
>  Cheers,
>>      Gary
>>
>> On 5 November 2012 10:21, Joachim Dreimann <joachim.dreimann@wandisco.com
>> **>wrote:
>>
>>  I notice that there were no replies to my last message (see below) and
>>> the
>>> ticket has therefore been put on hold. We've made no progress in a whole
>>> month on an issue all seemed to agree was important.
>>>
>>> The question remains:
>>>
>>>> Should we enable the 'edit' state for all fields using one button and
>>>>
>>> submit using one button, or should we take Jira's approach of asking for
>>> individual confirmation on every field?
>>>
>>>
>>> - Joe
>>>
>>> On 5 Oct 2012, at 20:10, Joe Dreimann <joachim.dreimann@wandisco.com**>
>>> wrote:
>>>
>>>  Ok, that sounds like we have a decision: All are in favour of
>>>>
>>> non-immediate saves for edits.
>>>
>>>> Now, should we enable the 'edit' state for all fields using one button
>>>>
>>> and submit using one button, or should we take Jira's approach of asking
>>> for individual confirmation on every field?
>>>
>>>>
>>>>  http://www.youtube.com/watch?**feature=player_detailpage&v=**
>>> EsQ__dR6Nrw#t=59s<http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s>
>>>
>>>> I'm bringing up Jira because it's used in a very similar context as
>>>>
>>> Bloodhound.
>>>
>>>> Cheers,
>>>> Joe
>>>>
>>>> ________________________
>>>> @jdreimann - Twitter
>>>> Sent from my phone
>>>>
>>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
>>>>
>>>>  I too am strongly against inline editing causing auto-save. Ticket
>>>>> changes must be intended and atomical!
>>>>> 1. Tickets are versioned and this messes up the ticket history
>>>>> 2. Multiple ticket notifications get sent out
>>>>> 3. Any ticket statistics get incorrect
>>>>> 4. In bigger enterprise environments tracking systems are integrated
>>>>>
>>>> with
>>>
>>>> other infrastructure, which means unintended inconsistencies are
>>>>>
>>>> propagated
>>>
>>>> to other systems as well
>>>>> 5. Companies will offen grant their customers access to tracking system
>>>>>
>>>> and
>>>
>>>> last person that I want to burdon with this, is my client.
>>>>> 6. If this works only for half of the tickt's fields, it is
>>>>>
>>>> inconsistent!
>>>
>>>> And the problem will just be worse when we try to get rid of that
>>>>>
>>>> "Modify"
>>>
>>>> section.
>>>>>
>>>>> I do find the proposed concept appealing for things like user
>>>>>
>>>> preferences
>>>
>>>> but even for that we would need to weight pros and cons.
>>>>>
>>>>> Peter
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <gary.martin@wandisco.com
>>>>>
>>>> wrote:
>>>>
>>>>>
>>>>>> Olemis Lang <ol...@gmail.com> wrote:
>>>>>>
>>>>>>  On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>
>>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>>>>>
>>>>>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>>
>>>>>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>>>>>
>>>>>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <gary.martin@wandisco.com
>>>>>>>>>>>>> >
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> [...]
>>>>>>>>>
>>>>>>>>>> As a user using a web application with the server 50 hops away
>>>>>>>>>> with
>>>>>>>>>>
>>>>>>>>> a
>>>>>>>
>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>>>>>>>>>>
>>>>>>>>> make
>>>>>>>
>>>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>>>>>>>>>
>>>>>>>>> (even
>>>>>>>
>>>>>>>> worse! then I don't know in what order the server actually receives
>>>>>>>>>>
>>>>>>>>> the
>>>>>>>
>>>>>>>> requests).
>>>>>>>>>>
>>>>>>>>> ... if you take a look at #146 attachments you'll notice that my
>>>>>>>>>
>>>>>>>> first
>>>>>>>
>>>>>>>> proposal included submit button for select fields . I was told to
>>>>>>>>> revert that .
>>>>>>>>>
>>>>>>>> Hmm. "Told to" implies hierarchy.
>>>>>>>>
>>>>>>> ... or respect to the opinions of the experts , and Joachim is the UI
>>>>>>> expert . When I have radical objections to other people's thoughts
>>>>>>> and
>>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>>>>>> there are underlying technical decisions that make it impossible to
>>>>>>> realize some ideas then I express my opinion . This time I don't
>>>>>>> think
>>>>>>> it was the case . /me studying and learning about UI design , etc ...
>>>>>>> but that's just work in progress . Hence most of the time I won't
>>>>>>> criticize UI decisions beyond «evident» issues I might notice.
>>>>>>>
>>>>>>> So to clarify my position , in this particular case i.e. #146 , I
>>>>>>> declare myself a completely happy neophyte and *so far* I have no
>>>>>>> strong arguments in favor or against any of both approaches . Please
>>>>>>> get to an agreement . In the meantime , if I have something to say
>>>>>>> I'll say it . Just let me know what needs to be done to continue work
>>>>>>> needed to finish patches  for #146 , please .
>>>>>>>
>>>>>>> ;)
>>>>>>>
>>>>>> This is why we need more decisions to be made here. No one person is
>>>>>>
>>>>> going
>>>
>>>> to be right on every decision.
>>>>>>
>>>>>> For some reason I didn't get the impression from the discussion in the
>>>>>> ticket that it would result in immediate edits. If more people were
>>>>>> watching the discussion, this might have been caught earlier as
>>>>>>
>>>>> something
>>>
>>>> that people would frown upon. Maybe.
>>>>>>
>>>>>> Anyway, personally I want to see in-place edits implemented such that
>>>>>>
>>>>> the
>>>
>>>> changes are not sent immediately but should be submitted with a single
>>>>>> button.
>>>>>>
>>>>>> I would probably be attempting to effectively use the existing form to
>>>>>> send the data - I suspect that at some point we will want the old form
>>>>>> hidden but it should probably be available for js disabled situations.
>>>>>>
>>>>>> For me, that would be enough work on the ticket. After that we can
>>>>>>
>>>>> build
>>>
>>>> on that work with things like indicating which fields are edited and
>>>>>> perhaps making it easier to comment on the changes (the comment field
>>>>>>
>>>>> is
>>>
>>>> way down the page on long tickets). I would also be interested in
>>>>>>
>>>>> whether
>>>
>>>> people would want to see a confirmation that the user should move away
>>>>>>
>>>>> from
>>>
>>>> a page when there are edits that are not submitted.
>>>>>>
>>>>>> Cheers,
>>>>>>    Gary
>>>>>>
>>>>>>
>>>
>>
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Jure Zitnik <ju...@digiverse.si>.
On 11/5/12 12:44 PM, Gary Martin wrote:
> Individual confirmation on every field? That sounds like the same thing as
> an immediate save. I think that so far the consensus is that we don't want
> that.

+1

> I've been using a few developers at apachecon as sounding boards as I am
> worried that things might be more complicated than necessary. The solution
> that would seem most efficient would be that all the fields that are
> editable are considered to be in an editable state already. The problem
> with this is then how it is made abundantly clear that a field is editable
> - and it would be nice to see when a field has been edited too.
>
> I am not yet convinced that a button to make all fields editable is the
> right approach at the moment - it seems like a step you shouldn't need.

I think that the ticket could be shown as read only initially, with the 
scroll spy component being visible from start (I think that was 
discussed in another thread already). As the scroll spy already includes 
the 'Modify ticket' button, clicking that button would enable 'edit 
mode' which would replace ticket fields inline (read only for editable) 
- that is, w/o scrolling to the 'Modify ticket' section. So, I would go 
for one button to enable the 'edit' state and one button for submission.

> Other than that, a submit all changes button would probably work well.
+1

Cheers,
Jure

> Cheers,
>      Gary
>
> On 5 November 2012 10:21, Joachim Dreimann <jo...@wandisco.com>wrote:
>
>> I notice that there were no replies to my last message (see below) and the
>> ticket has therefore been put on hold. We've made no progress in a whole
>> month on an issue all seemed to agree was important.
>>
>> The question remains:
>>> Should we enable the 'edit' state for all fields using one button and
>> submit using one button, or should we take Jira's approach of asking for
>> individual confirmation on every field?
>>
>>
>> - Joe
>>
>> On 5 Oct 2012, at 20:10, Joe Dreimann <jo...@wandisco.com>
>> wrote:
>>
>>> Ok, that sounds like we have a decision: All are in favour of
>> non-immediate saves for edits.
>>> Now, should we enable the 'edit' state for all fields using one button
>> and submit using one button, or should we take Jira's approach of asking
>> for individual confirmation on every field?
>>>
>> http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s
>>> I'm bringing up Jira because it's used in a very similar context as
>> Bloodhound.
>>> Cheers,
>>> Joe
>>>
>>> ________________________
>>> @jdreimann - Twitter
>>> Sent from my phone
>>>
>>> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
>>>
>>>> I too am strongly against inline editing causing auto-save. Ticket
>>>> changes must be intended and atomical!
>>>> 1. Tickets are versioned and this messes up the ticket history
>>>> 2. Multiple ticket notifications get sent out
>>>> 3. Any ticket statistics get incorrect
>>>> 4. In bigger enterprise environments tracking systems are integrated
>> with
>>>> other infrastructure, which means unintended inconsistencies are
>> propagated
>>>> to other systems as well
>>>> 5. Companies will offen grant their customers access to tracking system
>> and
>>>> last person that I want to burdon with this, is my client.
>>>> 6. If this works only for half of the tickt's fields, it is
>> inconsistent!
>>>> And the problem will just be worse when we try to get rid of that
>> "Modify"
>>>> section.
>>>>
>>>> I do find the proposed concept appealing for things like user
>> preferences
>>>> but even for that we would need to weight pros and cons.
>>>>
>>>> Peter
>>>>
>>>>
>>>>
>>>>
>>>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <gary.martin@wandisco.com
>>> wrote:
>>>>>
>>>>> Olemis Lang <ol...@gmail.com> wrote:
>>>>>
>>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>>>>> [...]
>>>>>>>>> As a user using a web application with the server 50 hops away with
>>>>>> a
>>>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>>>>>> make
>>>>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>>>>> (even
>>>>>>>>> worse! then I don't know in what order the server actually receives
>>>>>> the
>>>>>>>>> requests).
>>>>>>>> ... if you take a look at #146 attachments you'll notice that my
>>>>>> first
>>>>>>>> proposal included submit button for select fields . I was told to
>>>>>>>> revert that .
>>>>>>> Hmm. "Told to" implies hierarchy.
>>>>>> ... or respect to the opinions of the experts , and Joachim is the UI
>>>>>> expert . When I have radical objections to other people's thoughts and
>>>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>>>>> there are underlying technical decisions that make it impossible to
>>>>>> realize some ideas then I express my opinion . This time I don't think
>>>>>> it was the case . /me studying and learning about UI design , etc ...
>>>>>> but that's just work in progress . Hence most of the time I won't
>>>>>> criticize UI decisions beyond «evident» issues I might notice.
>>>>>>
>>>>>> So to clarify my position , in this particular case i.e. #146 , I
>>>>>> declare myself a completely happy neophyte and *so far* I have no
>>>>>> strong arguments in favor or against any of both approaches . Please
>>>>>> get to an agreement . In the meantime , if I have something to say
>>>>>> I'll say it . Just let me know what needs to be done to continue work
>>>>>> needed to finish patches  for #146 , please .
>>>>>>
>>>>>> ;)
>>>>> This is why we need more decisions to be made here. No one person is
>> going
>>>>> to be right on every decision.
>>>>>
>>>>> For some reason I didn't get the impression from the discussion in the
>>>>> ticket that it would result in immediate edits. If more people were
>>>>> watching the discussion, this might have been caught earlier as
>> something
>>>>> that people would frown upon. Maybe.
>>>>>
>>>>> Anyway, personally I want to see in-place edits implemented such that
>> the
>>>>> changes are not sent immediately but should be submitted with a single
>>>>> button.
>>>>>
>>>>> I would probably be attempting to effectively use the existing form to
>>>>> send the data - I suspect that at some point we will want the old form
>>>>> hidden but it should probably be available for js disabled situations.
>>>>>
>>>>> For me, that would be enough work on the ticket. After that we can
>> build
>>>>> on that work with things like indicating which fields are edited and
>>>>> perhaps making it easier to comment on the changes (the comment field
>> is
>>>>> way down the page on long tickets). I would also be interested in
>> whether
>>>>> people would want to see a confirmation that the user should move away
>> from
>>>>> a page when there are edits that are not submitted.
>>>>>
>>>>> Cheers,
>>>>>    Gary
>>>>>
>>
>


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
Individual confirmation on every field? That sounds like the same thing as
an immediate save. I think that so far the consensus is that we don't want
that.

I've been using a few developers at apachecon as sounding boards as I am
worried that things might be more complicated than necessary. The solution
that would seem most efficient would be that all the fields that are
editable are considered to be in an editable state already. The problem
with this is then how it is made abundantly clear that a field is editable
- and it would be nice to see when a field has been edited too.

I am not yet convinced that a button to make all fields editable is the
right approach at the moment - it seems like a step you shouldn't need.

Other than that, a submit all changes button would probably work well.

Cheers,
    Gary

On 5 November 2012 10:21, Joachim Dreimann <jo...@wandisco.com>wrote:

> I notice that there were no replies to my last message (see below) and the
> ticket has therefore been put on hold. We've made no progress in a whole
> month on an issue all seemed to agree was important.
>
> The question remains:
> > Should we enable the 'edit' state for all fields using one button and
> submit using one button, or should we take Jira's approach of asking for
> individual confirmation on every field?
>
>
> - Joe
>
> On 5 Oct 2012, at 20:10, Joe Dreimann <jo...@wandisco.com>
> wrote:
>
> > Ok, that sounds like we have a decision: All are in favour of
> non-immediate saves for edits.
> >
> > Now, should we enable the 'edit' state for all fields using one button
> and submit using one button, or should we take Jira's approach of asking
> for individual confirmation on every field?
> >
> >
> http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s
> >
> > I'm bringing up Jira because it's used in a very similar context as
> Bloodhound.
> >
> > Cheers,
> > Joe
> >
> > ________________________
> > @jdreimann - Twitter
> > Sent from my phone
> >
> > On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
> >
> >> I too am strongly against inline editing causing auto-save. Ticket
> >> changes must be intended and atomical!
> >> 1. Tickets are versioned and this messes up the ticket history
> >> 2. Multiple ticket notifications get sent out
> >> 3. Any ticket statistics get incorrect
> >> 4. In bigger enterprise environments tracking systems are integrated
> with
> >> other infrastructure, which means unintended inconsistencies are
> propagated
> >> to other systems as well
> >> 5. Companies will offen grant their customers access to tracking system
> and
> >> last person that I want to burdon with this, is my client.
> >> 6. If this works only for half of the tickt's fields, it is
> inconsistent!
> >> And the problem will just be worse when we try to get rid of that
> "Modify"
> >> section.
> >>
> >> I do find the proposed concept appealing for things like user
> preferences
> >> but even for that we would need to weight pros and cons.
> >>
> >> Peter
> >>
> >>
> >>
> >>
> >> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <gary.martin@wandisco.com
> >wrote:
> >>
> >>>
> >>>
> >>> Olemis Lang <ol...@gmail.com> wrote:
> >>>
> >>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> >>>>> On 05.10.2012 05:17, Olemis Lang wrote:
> >>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> >>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
> >>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
> >>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
> >>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com>
> >>>>>>>>>> wrote:
> >>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
> >>>>>> [...]
> >>>>>>> As a user using a web application with the server 50 hops away with
> >>>> a
> >>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
> >>>> make
> >>>>>>> generates a POST request to somewhere; even if it's an async XHR
> >>>> (even
> >>>>>>> worse! then I don't know in what order the server actually receives
> >>>> the
> >>>>>>> requests).
> >>>>>> ... if you take a look at #146 attachments you'll notice that my
> >>>> first
> >>>>>> proposal included submit button for select fields . I was told to
> >>>>>> revert that .
> >>>>>
> >>>>> Hmm. "Told to" implies hierarchy.
> >>>>
> >>>> ... or respect to the opinions of the experts , and Joachim is the UI
> >>>> expert . When I have radical objections to other people's thoughts and
> >>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
> >>>> there are underlying technical decisions that make it impossible to
> >>>> realize some ideas then I express my opinion . This time I don't think
> >>>> it was the case . /me studying and learning about UI design , etc ...
> >>>> but that's just work in progress . Hence most of the time I won't
> >>>> criticize UI decisions beyond «evident» issues I might notice.
> >>>>
> >>>> So to clarify my position , in this particular case i.e. #146 , I
> >>>> declare myself a completely happy neophyte and *so far* I have no
> >>>> strong arguments in favor or against any of both approaches . Please
> >>>> get to an agreement . In the meantime , if I have something to say
> >>>> I'll say it . Just let me know what needs to be done to continue work
> >>>> needed to finish patches  for #146 , please .
> >>>>
> >>>> ;)
> >>>
> >>> This is why we need more decisions to be made here. No one person is
> going
> >>> to be right on every decision.
> >>>
> >>> For some reason I didn't get the impression from the discussion in the
> >>> ticket that it would result in immediate edits. If more people were
> >>> watching the discussion, this might have been caught earlier as
> something
> >>> that people would frown upon. Maybe.
> >>>
> >>> Anyway, personally I want to see in-place edits implemented such that
> the
> >>> changes are not sent immediately but should be submitted with a single
> >>> button.
> >>>
> >>> I would probably be attempting to effectively use the existing form to
> >>> send the data - I suspect that at some point we will want the old form
> >>> hidden but it should probably be available for js disabled situations.
> >>>
> >>> For me, that would be enough work on the ticket. After that we can
> build
> >>> on that work with things like indicating which fields are edited and
> >>> perhaps making it easier to comment on the changes (the comment field
> is
> >>> way down the page on long tickets). I would also be interested in
> whether
> >>> people would want to see a confirmation that the user should move away
> from
> >>> a page when there are edits that are not submitted.
> >>>
> >>> Cheers,
> >>>   Gary
> >>>
>
>


-- 
Gary Martin
Lead Developer | WANdisco <http://www.wandisco.com/>
*
*
**
*Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
*

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Joachim Dreimann <jo...@wandisco.com>.
I notice that there were no replies to my last message (see below) and the ticket has therefore been put on hold. We've made no progress in a whole month on an issue all seemed to agree was important.

The question remains:
> Should we enable the 'edit' state for all fields using one button and submit using one button, or should we take Jira's approach of asking for individual confirmation on every field?


- Joe

On 5 Oct 2012, at 20:10, Joe Dreimann <jo...@wandisco.com> wrote:

> Ok, that sounds like we have a decision: All are in favour of non-immediate saves for edits.
> 
> Now, should we enable the 'edit' state for all fields using one button and submit using one button, or should we take Jira's approach of asking for individual confirmation on every field?
> 
> http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s
> 
> I'm bringing up Jira because it's used in a very similar context as Bloodhound.
> 
> Cheers,
> Joe
> 
> ________________________
> @jdreimann - Twitter
> Sent from my phone
> 
> On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:
> 
>> I too am strongly against inline editing causing auto-save. Ticket
>> changes must be intended and atomical!
>> 1. Tickets are versioned and this messes up the ticket history
>> 2. Multiple ticket notifications get sent out
>> 3. Any ticket statistics get incorrect
>> 4. In bigger enterprise environments tracking systems are integrated with
>> other infrastructure, which means unintended inconsistencies are propagated
>> to other systems as well
>> 5. Companies will offen grant their customers access to tracking system and
>> last person that I want to burdon with this, is my client.
>> 6. If this works only for half of the tickt's fields, it is inconsistent!
>> And the problem will just be worse when we try to get rid of that "Modify"
>> section.
>> 
>> I do find the proposed concept appealing for things like user preferences
>> but even for that we would need to weight pros and cons.
>> 
>> Peter
>> 
>> 
>> 
>> 
>> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <ga...@wandisco.com>wrote:
>> 
>>> 
>>> 
>>> Olemis Lang <ol...@gmail.com> wrote:
>>> 
>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com>
>>>>>>>>>> wrote:
>>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>>> [...]
>>>>>>> As a user using a web application with the server 50 hops away with
>>>> a
>>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>>>> make
>>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>>> (even
>>>>>>> worse! then I don't know in what order the server actually receives
>>>> the
>>>>>>> requests).
>>>>>> ... if you take a look at #146 attachments you'll notice that my
>>>> first
>>>>>> proposal included submit button for select fields . I was told to
>>>>>> revert that .
>>>>> 
>>>>> Hmm. "Told to" implies hierarchy.
>>>> 
>>>> ... or respect to the opinions of the experts , and Joachim is the UI
>>>> expert . When I have radical objections to other people's thoughts and
>>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>>> there are underlying technical decisions that make it impossible to
>>>> realize some ideas then I express my opinion . This time I don't think
>>>> it was the case . /me studying and learning about UI design , etc ...
>>>> but that's just work in progress . Hence most of the time I won't
>>>> criticize UI decisions beyond «evident» issues I might notice.
>>>> 
>>>> So to clarify my position , in this particular case i.e. #146 , I
>>>> declare myself a completely happy neophyte and *so far* I have no
>>>> strong arguments in favor or against any of both approaches . Please
>>>> get to an agreement . In the meantime , if I have something to say
>>>> I'll say it . Just let me know what needs to be done to continue work
>>>> needed to finish patches  for #146 , please .
>>>> 
>>>> ;)
>>> 
>>> This is why we need more decisions to be made here. No one person is going
>>> to be right on every decision.
>>> 
>>> For some reason I didn't get the impression from the discussion in the
>>> ticket that it would result in immediate edits. If more people were
>>> watching the discussion, this might have been caught earlier as something
>>> that people would frown upon. Maybe.
>>> 
>>> Anyway, personally I want to see in-place edits implemented such that the
>>> changes are not sent immediately but should be submitted with a single
>>> button.
>>> 
>>> I would probably be attempting to effectively use the existing form to
>>> send the data - I suspect that at some point we will want the old form
>>> hidden but it should probably be available for js disabled situations.
>>> 
>>> For me, that would be enough work on the ticket. After that we can build
>>> on that work with things like indicating which fields are edited and
>>> perhaps making it easier to comment on the changes (the comment field is
>>> way down the page on long tickets). I would also be interested in whether
>>> people would want to see a confirmation that the user should move away from
>>> a page when there are edits that are not submitted.
>>> 
>>> Cheers,
>>>   Gary
>>> 


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Joe Dreimann <jo...@wandisco.com>.
Ok, that sounds like we have a decision: All are in favour of non-immediate saves for edits.

Now, should we enable the 'edit' state for all fields using one button and submit using one button, or should we take Jira's approach of asking for individual confirmation on every field?

http://www.youtube.com/watch?feature=player_detailpage&v=EsQ__dR6Nrw#t=59s

I'm bringing up Jira because it's used in a very similar context as Bloodhound.

Cheers,
Joe

________________________
@jdreimann - Twitter
Sent from my phone

On 5 Oct 2012, at 09:29, Peter Koželj <pe...@digiverse.si> wrote:

> I too am strongly against inline editing causing auto-save. Ticket
> changes must be intended and atomical!
> 1. Tickets are versioned and this messes up the ticket history
> 2. Multiple ticket notifications get sent out
> 3. Any ticket statistics get incorrect
> 4. In bigger enterprise environments tracking systems are integrated with
> other infrastructure, which means unintended inconsistencies are propagated
> to other systems as well
> 5. Companies will offen grant their customers access to tracking system and
> last person that I want to burdon with this, is my client.
> 6. If this works only for half of the tickt's fields, it is inconsistent!
> And the problem will just be worse when we try to get rid of that "Modify"
> section.
> 
> I do find the proposed concept appealing for things like user preferences
> but even for that we would need to weight pros and cons.
> 
> Peter
> 
> 
> 
> 
> On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <ga...@wandisco.com>wrote:
> 
>> 
>> 
>> Olemis Lang <ol...@gmail.com> wrote:
>> 
>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>> On 05.10.2012 05:17, Olemis Lang wrote:
>>>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com>
>>>>>>>>> wrote:
>>>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>> [...]
>>>>>> As a user using a web application with the server 50 hops away with
>>> a
>>>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>>> make
>>>>>> generates a POST request to somewhere; even if it's an async XHR
>>> (even
>>>>>> worse! then I don't know in what order the server actually receives
>>> the
>>>>>> requests).
>>>>> ... if you take a look at #146 attachments you'll notice that my
>>> first
>>>>> proposal included submit button for select fields . I was told to
>>>>> revert that .
>>>> 
>>>> Hmm. "Told to" implies hierarchy.
>>> 
>>> ... or respect to the opinions of the experts , and Joachim is the UI
>>> expert . When I have radical objections to other people's thoughts and
>>> ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>>> there are underlying technical decisions that make it impossible to
>>> realize some ideas then I express my opinion . This time I don't think
>>> it was the case . /me studying and learning about UI design , etc ...
>>> but that's just work in progress . Hence most of the time I won't
>>> criticize UI decisions beyond «evident» issues I might notice.
>>> 
>>> So to clarify my position , in this particular case i.e. #146 , I
>>> declare myself a completely happy neophyte and *so far* I have no
>>> strong arguments in favor or against any of both approaches . Please
>>> get to an agreement . In the meantime , if I have something to say
>>> I'll say it . Just let me know what needs to be done to continue work
>>> needed to finish patches  for #146 , please .
>>> 
>>> ;)
>> 
>> This is why we need more decisions to be made here. No one person is going
>> to be right on every decision.
>> 
>> For some reason I didn't get the impression from the discussion in the
>> ticket that it would result in immediate edits. If more people were
>> watching the discussion, this might have been caught earlier as something
>> that people would frown upon. Maybe.
>> 
>> Anyway, personally I want to see in-place edits implemented such that the
>> changes are not sent immediately but should be submitted with a single
>> button.
>> 
>> I would probably be attempting to effectively use the existing form to
>> send the data - I suspect that at some point we will want the old form
>> hidden but it should probably be available for js disabled situations.
>> 
>> For me, that would be enough work on the ticket. After that we can build
>> on that work with things like indicating which fields are edited and
>> perhaps making it easier to comment on the changes (the comment field is
>> way down the page on long tickets). I would also be interested in whether
>> people would want to see a confirmation that the user should move away from
>> a page when there are edits that are not submitted.
>> 
>> Cheers,
>>   Gary
>> 

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Peter Koželj <pe...@digiverse.si>.
I too am strongly against inline editing causing auto-save. Ticket
changes must be intended and atomical!
1. Tickets are versioned and this messes up the ticket history
2. Multiple ticket notifications get sent out
3. Any ticket statistics get incorrect
4. In bigger enterprise environments tracking systems are integrated with
other infrastructure, which means unintended inconsistencies are propagated
to other systems as well
5. Companies will offen grant their customers access to tracking system and
last person that I want to burdon with this, is my client.
6. If this works only for half of the tickt's fields, it is inconsistent!
And the problem will just be worse when we try to get rid of that "Modify"
section.

I do find the proposed concept appealing for things like user preferences
but even for that we would need to weight pros and cons.

Peter




On Fri, Oct 5, 2012 at 9:52 AM, Gary Martin <ga...@wandisco.com>wrote:

>
>
> Olemis Lang <ol...@gmail.com> wrote:
>
> >On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> >> On 05.10.2012 05:17, Olemis Lang wrote:
> >>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> >>>> On 04.10.2012 18:33, Olemis Lang wrote:
> >>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
> >>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
> >>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com>
> >>>>>>> wrote:
> >>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
> >>> [...]
> >>>> As a user using a web application with the server 50 hops away with
> >a
> >>>> 1.5 second ping time, I'd be very, very pissed off if every click I
> >make
> >>>> generates a POST request to somewhere; even if it's an async XHR
> >(even
> >>>> worse! then I don't know in what order the server actually receives
> >the
> >>>> requests).
> >>>>
> >>> ... if you take a look at #146 attachments you'll notice that my
> >first
> >>> proposal included submit button for select fields . I was told to
> >>> revert that .
> >>
> >> Hmm. "Told to" implies hierarchy.
> >
> >... or respect to the opinions of the experts , and Joachim is the UI
> >expert . When I have radical objections to other people's thoughts and
> >ideas (e.g. on the subject of WikiMacros ) or even when I agree but
> >there are underlying technical decisions that make it impossible to
> >realize some ideas then I express my opinion . This time I don't think
> >it was the case . /me studying and learning about UI design , etc ...
> >but that's just work in progress . Hence most of the time I won't
> >criticize UI decisions beyond «evident» issues I might notice.
> >
> >So to clarify my position , in this particular case i.e. #146 , I
> >declare myself a completely happy neophyte and *so far* I have no
> >strong arguments in favor or against any of both approaches . Please
> >get to an agreement . In the meantime , if I have something to say
> >I'll say it . Just let me know what needs to be done to continue work
> >needed to finish patches  for #146 , please .
> >
> >;)
>
> This is why we need more decisions to be made here. No one person is going
> to be right on every decision.
>
> For some reason I didn't get the impression from the discussion in the
> ticket that it would result in immediate edits. If more people were
> watching the discussion, this might have been caught earlier as something
> that people would frown upon. Maybe.
>
> Anyway, personally I want to see in-place edits implemented such that the
> changes are not sent immediately but should be submitted with a single
> button.
>
> I would probably be attempting to effectively use the existing form to
> send the data - I suspect that at some point we will want the old form
> hidden but it should probably be available for js disabled situations.
>
> For me, that would be enough work on the ticket. After that we can build
> on that work with things like indicating which fields are edited and
> perhaps making it easier to comment on the changes (the comment field is
> way down the page on long tickets). I would also be interested in whether
> people would want to see a confirmation that the user should move away from
> a page when there are edits that are not submitted.
>
> Cheers,
>     Gary
>

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.

Olemis Lang <ol...@gmail.com> wrote:

>On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>> On 05.10.2012 05:17, Olemis Lang wrote:
>>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com>
>>>>>>> wrote:
>>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>> [...]
>>>> As a user using a web application with the server 50 hops away with
>a
>>>> 1.5 second ping time, I'd be very, very pissed off if every click I
>make
>>>> generates a POST request to somewhere; even if it's an async XHR
>(even
>>>> worse! then I don't know in what order the server actually receives
>the
>>>> requests).
>>>>
>>> ... if you take a look at #146 attachments you'll notice that my
>first
>>> proposal included submit button for select fields . I was told to
>>> revert that .
>>
>> Hmm. "Told to" implies hierarchy.
>
>... or respect to the opinions of the experts , and Joachim is the UI
>expert . When I have radical objections to other people's thoughts and
>ideas (e.g. on the subject of WikiMacros ) or even when I agree but
>there are underlying technical decisions that make it impossible to
>realize some ideas then I express my opinion . This time I don't think
>it was the case . /me studying and learning about UI design , etc ...
>but that's just work in progress . Hence most of the time I won't
>criticize UI decisions beyond «evident» issues I might notice.
>
>So to clarify my position , in this particular case i.e. #146 , I
>declare myself a completely happy neophyte and *so far* I have no
>strong arguments in favor or against any of both approaches . Please
>get to an agreement . In the meantime , if I have something to say
>I'll say it . Just let me know what needs to be done to continue work
>needed to finish patches  for #146 , please .
>
>;)

This is why we need more decisions to be made here. No one person is going to be right on every decision.

For some reason I didn't get the impression from the discussion in the ticket that it would result in immediate edits. If more people were watching the discussion, this might have been caught earlier as something that people would frown upon. Maybe.

Anyway, personally I want to see in-place edits implemented such that the changes are not sent immediately but should be submitted with a single button.

I would probably be attempting to effectively use the existing form to send the data - I suspect that at some point we will want the old form hidden but it should probably be available for js disabled situations.

For me, that would be enough work on the ticket. After that we can build on that work with things like indicating which fields are edited and perhaps making it easier to comment on the changes (the comment field is way down the page on long tickets). I would also be interested in whether people would want to see a confirmation that the user should move away from a page when there are edits that are not submitted.

Cheers,
    Gary

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> On 05.10.2012 05:17, Olemis Lang wrote:
>> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>>> On 04.10.2012 18:33, Olemis Lang wrote:
>>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com>
>>>>>> wrote:
>>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>> [...]
>>> As a user using a web application with the server 50 hops away with a
>>> 1.5 second ping time, I'd be very, very pissed off if every click I make
>>> generates a POST request to somewhere; even if it's an async XHR (even
>>> worse! then I don't know in what order the server actually receives the
>>> requests).
>>>
>> ... if you take a look at #146 attachments you'll notice that my first
>> proposal included submit button for select fields . I was told to
>> revert that .
>
> Hmm. "Told to" implies hierarchy.

... or respect to the opinions of the experts , and Joachim is the UI
expert . When I have radical objections to other people's thoughts and
ideas (e.g. on the subject of WikiMacros ) or even when I agree but
there are underlying technical decisions that make it impossible to
realize some ideas then I express my opinion . This time I don't think
it was the case . /me studying and learning about UI design , etc ...
but that's just work in progress . Hence most of the time I won't
criticize UI decisions beyond «evident» issues I might notice.

So to clarify my position , in this particular case i.e. #146 , I
declare myself a completely happy neophyte and *so far* I have no
strong arguments in favor or against any of both approaches . Please
get to an agreement . In the meantime , if I have something to say
I'll say it . Just let me know what needs to be done to continue work
needed to finish patches  for #146 , please .

;)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Branko Čibej <br...@wandisco.com>.
On 05.10.2012 05:17, Olemis Lang wrote:
> On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
>> On 04.10.2012 18:33, Olemis Lang wrote:
>>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
>>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
> [...]
>>>> I don't like the inconsistency there. Personally I would store up the
>>>> changes, marking which fields are altered in some way and provide a
>>>> means to submit those changes as a set.
>>>>
>>> That's the way in-place editing works [1]_
>>>
>>> .. [1] jEditable # How does in place editing work?
>>>         (http://www.appelsiini.net/projects/jeditable)
> [...]
>> Ticket changes should be complete and intentional,
> +1
>
>> not
>> something that happens because some bit of code downloaded from
>> somewhere happens to "work that way".
>>
> I think you are misunderstanding my previous comment . Firstly
> in-place edits happen one at a time , at least that's what they are
> meant to be . What I said should be interpreted as «that's the common
> way of doing things» , not as /me saying «we have to do it that way
> because everybody does» . I did it that way because I was told to do
> it that way . Indeed ...
>
>> As a user using a web application with the server 50 hops away with a
>> 1.5 second ping time, I'd be very, very pissed off if every click I make
>> generates a POST request to somewhere; even if it's an async XHR (even
>> worse! then I don't know in what order the server actually receives the
>> requests).
>>
> ... if you take a look at #146 attachments you'll notice that my first
> proposal included submit button for select fields . I was told to
> revert that .

Hmm. "Told to" implies hierarchy. Ain't no such thing in an Apache
project. What gives? If you don't agree with someone's ideas about a
feature, surely the thing to do is to discuss the various pros and cons
on this list. The log for that ticket isn't exactly a glaring example,
but it's worrying.

-- Brane

P.S.: Yes I know that BH development is funded. <mentor>Regardless,
things should happen by consensus of project members, clearly expressed
on the mailing list, not because of "told to".</mentor>

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 10/4/12, Branko Čibej <br...@wandisco.com> wrote:
> On 04.10.2012 18:33, Olemis Lang wrote:
>> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
>>>>>> On 03/10/12 20:50, Olemis Lang wrote:
[...]
>>
>>> I don't like the inconsistency there. Personally I would store up the
>>> changes, marking which fields are altered in some way and provide a
>>> means to submit those changes as a set.
>>>
>> That's the way in-place editing works [1]_
>>
>> .. [1] jEditable # How does in place editing work?
>>         (http://www.appelsiini.net/projects/jeditable)
>
[...]
>
> Ticket changes should be complete and intentional,

+1

> not
> something that happens because some bit of code downloaded from
> somewhere happens to "work that way".
>

I think you are misunderstanding my previous comment . Firstly
in-place edits happen one at a time , at least that's what they are
meant to be . What I said should be interpreted as «that's the common
way of doing things» , not as /me saying «we have to do it that way
because everybody does» . I did it that way because I was told to do
it that way . Indeed ...

> As a user using a web application with the server 50 hops away with a
> 1.5 second ping time, I'd be very, very pissed off if every click I make
> generates a POST request to somewhere; even if it's an async XHR (even
> worse! then I don't know in what order the server actually receives the
> requests).
>

... if you take a look at #146 attachments you'll notice that my first
proposal included submit button for select fields . I was told to
revert that .

[...]
> Right
> now it looks like someone's crowing, "Look ma, no hands!" just before
> they fall on their face.
>

I'd rather say it looks like

kid - Hey ma , what is Polyethylene terephthalate for ?
ma - It's used to produce plastic bottles , like those for soft-drinks ... :)
dad - Oh no ! At Hong-Kong they raise building from the ground up with that

PS: Please decide what you are going to do about this feature so that
I can continue with it . I'm hoping we'll still can reuse at least the
custom visual editors already implemented in submitted patches .

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Branko Čibej <br...@wandisco.com>.
On 04.10.2012 18:33, Olemis Lang wrote:
> On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
>> On 04/10/12 16:54, Joachim Dreimann wrote:
>>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
>>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>>    - Decide how to notify in-place modifications (verbose vs quiet ,
>>>>> configurable ? , ...)
>>>> Does this mean that each change individually updates the ticket on the
>>>> server? I thought that we would be going with users submitting all
>>>> changes once they are happy with the new state of the ticket.
>>>>
>>> I would expect every radio button / drop down change to save immediately,
> FWIW , that's the way it works now
>
>>> users should only need to confirm textfields or similar where incomplete
>>> information would be very likely if we save after every letter or when the
>>> box loses focus.
>>>
> Text and text area fields submit information on clicking Submit button
> and cancel edits on blur and on ESC key pressed . Nonetheless the
> later is the only way to cancel wiki text area edits because wiki
> toolbar will not work if editor vanishes on blur .
>
>> I don't like the inconsistency there. Personally I would store up the
>> changes, marking which fields are altered in some way and provide a
>> means to submit those changes as a set.
>>
> That's the way in-place editing works [1]_
>
> .. [1] jEditable # How does in place editing work?
>         (http://www.appelsiini.net/projects/jeditable)

As someone coming from the version-control world, and because issue
tracking contains /some/ elements of version control if only because it
maintains a history timeline ... I think this sort of thing requires
just a bit more thought than pointing at an implementation of some UI
component. Ticket changes should be complete and intentional, not
something that happens because some bit of code downloaded from
somewhere happens to "work that way".

As a user using a web application with the server 50 hops away with a
1.5 second ping time, I'd be very, very pissed off if every click I make
generates a POST request to somewhere; even if it's an async XHR (even
worse! then I don't know in what order the server actually receives the
requests).

I very strongly suggest you all take another look at in-place editing
from an issue-tracking functionality and usability point of view. Right
now it looks like someone's crowing, "Look ma, no hands!" just before
they fall on their face.

-- Brane

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 10/4/12, Gary Martin <ga...@wandisco.com> wrote:
> On 04/10/12 16:54, Joachim Dreimann wrote:
>> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
>>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>>    - Decide how to notify in-place modifications (verbose vs quiet ,
>>>> configurable ? , ...)
>>> Does this mean that each change individually updates the ticket on the
>>> server? I thought that we would be going with users submitting all
>>> changes once they are happy with the new state of the ticket.
>>>
>> I would expect every radio button / drop down change to save immediately,

FWIW , that's the way it works now

>> users should only need to confirm textfields or similar where incomplete
>> information would be very likely if we save after every letter or when the
>> box loses focus.
>>

Text and text area fields submit information on clicking Submit button
and cancel edits on blur and on ESC key pressed . Nonetheless the
later is the only way to cancel wiki text area edits because wiki
toolbar will not work if editor vanishes on blur .

>
> I don't like the inconsistency there. Personally I would store up the
> changes, marking which fields are altered in some way and provide a
> means to submit those changes as a set.
>

That's the way in-place editing works [1]_

.. [1] jEditable # How does in place editing work?
        (http://www.appelsiini.net/projects/jeditable)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
On 04/10/12 16:54, Joachim Dreimann wrote:
> On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
>>> On 03/10/12 20:50, Olemis Lang wrote:
>>>    - Decide how to notify in-place modifications (verbose vs quiet ,
>>> configurable ? , ...)
>> Does this mean that each change individually updates the ticket on the server? I thought that we would be going with users submitting all changes once they are happy with the new state of the ticket.
>>
> I would expect every radio button / drop down change to save immediately, users should only need to confirm textfields or similar where incomplete information would be very likely if we save after every letter or when the box loses focus.
>
> Joe
>

I don't like the inconsistency there. Personally I would store up the 
changes, marking which fields are altered in some way and provide a 
means to submit those changes as a set.

Cheers,
     Gary



Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Joachim Dreimann <jo...@wandisco.com>.
On 4 Oct 2012, at 12:01, Gary Martin <ga...@wandisco.com> wrote:
>> On 03/10/12 20:50, Olemis Lang wrote:
>>   - Decide how to notify in-place modifications (verbose vs quiet ,
>> configurable ? , ...)
> 
> Does this mean that each change individually updates the ticket on the server? I thought that we would be going with users submitting all changes once they are happy with the new state of the ticket.
> 

I would expect every radio button / drop down change to save immediately, users should only need to confirm textfields or similar where incomplete information would be very likely if we save after every letter or when the box loses focus.

Joe


Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Gary Martin <ga...@wandisco.com>.
On 03/10/12 20:50, Olemis Lang wrote:
> On 10/3/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
>> #146: Inline editing of objects
> [...]
>> Comment (by olemis):
> [...]
>>   New features
>>   are :
>>
>>     1. Wiki toolbar buttons are usable now
> [...]
>>     1. In  place edits take place and are reflected correctly in the UI .
> [...]
>
> At the moment major pending improvements related to this ticket are :
>
>    - Decide how to notify in-place modifications (verbose vs quiet ,
> configurable ? , ...)

Does this mean that each change individually updates the ticket on the 
server? I thought that we would be going with users submitting all 
changes once they are happy with the new state of the ticket.

Cheers,
     Gary

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Olemis Lang <ol...@gmail.com>.
On 10/3/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #146: Inline editing of objects
[...]
> Comment (by olemis):
[...]
>
>  New features
>  are :
>
>    1. Wiki toolbar buttons are usable now
[...]
>    1. In  place edits take place and are reflected correctly in the UI .
[...]

At the moment major pending improvements related to this ticket are :

  - Decide how to notify in-place modifications (verbose vs quiet ,
configurable ? , ...)
  - Do not show «Click to edit» placeholder in assigned wiki textarea fields
  - In-place editors for description (+ tags) inside well
  - Implement in-place editing for ticket view inside a single component
  - Error handling
  - Recovery strategy

About the later , there should be informative elements to know whether
in-place submission failed (e.g. on collisions ... ) . What about at
least using validation states [1]_ to highlight in the UI ticket
fields for which submission failed .

.. [1] Validation states
        (http://twitter.github.com/bootstrap/base-css.html#forms)

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

Re: [Apache Bloodhound] #146: Inline editing of objects

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#146: Inline editing of objects
--------------------------+-----------------------
  Reporter:  jdreimann    |      Owner:  olemis
      Type:  enhancement  |     Status:  accepted
  Priority:  critical     |  Milestone:  Release 2
 Component:  dashboard    |    Version:
Resolution:               |   Keywords:
--------------------------+-----------------------

Comment (by olemis):

 I've added one or two more patches and refreshed all others . New features
 are :

   1. Wiki toolbar buttons are usable now
   1. By default in-place submit requests are sent to current URL
      with `inplace = submit` and form token set .
   1. Hence requests handled by ticket module are intercepted to
       handle in-place submit requests .
   1. However , some refactorings are needed mainly because
       the former characteristics imply that in-place edits must be
       powered by a single component (instead of two like it
       happens now).
   1. I've moved helper functions related to tickets (i.e. `create`
 function borrowed
       from TracHacks:XmlRpcPlugin @ !r12099 ) onto a separate module .
 I've also incorporated
       `TicketRPC`'s `update` and `get` methods .
   1. The version of `update` method incorporated has been slightly
 modified considering [http://trac-hacks.org/ticket/9921#comment:1 this
 comment]
   1. All rpc methods have been slightly modified to use them as standalone
       functions .
   1. In place components in new module so as to enable / disable at once .
   1. In  place edits take place and are reflected correctly in the UI .
   1. Minor changes to ticket templates .

 '''PS''': I've update [comment:14 patch order] too.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/146#comment:20>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker