[GitHub] [beam] ElessarST commented on a change in pull request #15700: [BEAM-12987] [Playground] Add page UI elements

[GitBox <gi...@apache.org>]

ElessarST commented on a change in pull request #15700:
URL: https://github.com/apache/beam/pull/15700#discussion_r726821230



##########
File path: playground/frontend/lib/components/toggle_theme_button/toggle_theme_button.dart
##########
@@ -31,16 +32,13 @@ class ToggleThemeButton extends StatelessWidget {
   Widget build(BuildContext context) {
     return Consumer<ThemeProvider>(builder: (context, theme, child) {
       final text = theme.isDarkMode ? kLightMode : kDartMode;
-      final icon = theme.isDarkMode
-          ? Icons.light_mode_outlined
-          : Icons.mode_night_outlined;
       return Padding(
         padding: const EdgeInsets.symmetric(
           vertical: kSmSpacing,
           horizontal: kMdSpacing,
         ),
         child: TextButton.icon(
-          icon: Icon(icon),
+          icon: SvgPicture.asset("theme.svg"),

Review comment:
       Thanks, I moved all assets names to a const file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org