You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-cvs@httpd.apache.org by jo...@apache.org on 2009/02/28 09:25:31 UTC

svn commit: r748790 - in /httpd/apreq/trunk/library: cookie.c t/cookie.c

Author: joes
Date: Sat Feb 28 08:25:30 2009
New Revision: 748790

URL: http://svn.apache.org/viewvc?rev=748790&view=rev
Log:
don't change the tests,
they were right the first time ;-)

Modified:
    httpd/apreq/trunk/library/cookie.c
    httpd/apreq/trunk/library/t/cookie.c

Modified: httpd/apreq/trunk/library/cookie.c
URL: http://svn.apache.org/viewvc/httpd/apreq/trunk/library/cookie.c?rev=748790&r1=748789&r2=748790&view=diff
==============================================================================
--- httpd/apreq/trunk/library/cookie.c (original)
+++ httpd/apreq/trunk/library/cookie.c Sat Feb 28 08:25:30 2009
@@ -382,16 +382,7 @@
 
             status = get_pair(p, &hdr, &name, &nlen, &value, &vlen, 0);
 
-            switch (status) {
-
-            case APREQ_ERROR_NOTOKEN:
-                rv = status;
-                /* fall thru */
-
-            case APR_SUCCESS:
-                break;
-
-            default:
+            if (status != APR_SUCCESS) {
                 c = NULL;
                 rv = status;
                 goto parse_cookie_error;

Modified: httpd/apreq/trunk/library/t/cookie.c
URL: http://svn.apache.org/viewvc/httpd/apreq/trunk/library/t/cookie.c?rev=748790&r1=748789&r2=748790&view=diff
==============================================================================
--- httpd/apreq/trunk/library/t/cookie.c (original)
+++ httpd/apreq/trunk/library/t/cookie.c Sat Feb 28 08:25:30 2009
@@ -110,8 +110,8 @@
 
     AT_str_eq(apr_table_get(jar, "a"), "1");
 
-    /* accept wacky cookies that don't have an '=' sign */
-    AT_not_null(apr_table_get(jar, "bad"));
+    /* ignore wacky cookies that don't have an '=' sign */
+    AT_is_null(apr_table_get(jar, "bad"));
 
     /* accept wacky cookies that contain multiple '=' */
     AT_str_eq(apr_table_get(jar, "ns"), "foo=1&bar=2");