You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2017/03/24 11:56:02 UTC
Review Request 57908: Xsd for virtual fact
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/
-----------------------------------------------------------
Review request for lens and Rajat Khandelwal.
Repository: lens
Description
-------
Xsd for virtual fact
Diffs
-----
lens-api/src/main/resources/cube-0.1.xsd 060eb43
Diff: https://reviews.apache.org/r/57908/diff/1/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
> On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote:
> > Can you also add one example xml file for virtual fact in examples?
Will do
> On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/cube-0.1.xsd
> > Lines 172 (patched)
> > <https://reviews.apache.org/r/57908/diff/2/?file=1673842#file1673842line172>
> >
> > we need to add `filter` somewhere inside the fact definition.
filter will be added as a property. I will add it in the sample xml
> On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/cube-0.1.xsd
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/57908/diff/2/?file=1673842#file1673842line184>
> >
> > By extending, we'll have to specify everything that we specify for fact table, which would mean columns would need to be provided. I don't think extension is something we need to use in this case.
Will do.
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170019
-----------------------------------------------------------
On March 24, 2017, 12:15 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 24, 2017, 12:15 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
>
>
> Diff: https://reviews.apache.org/r/57908/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/cube-0.1.xsd
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/57908/diff/2/?file=1673842#file1673842line184>
> >
> > By extending, we'll have to specify everything that we specify for fact table, which would mean columns would need to be provided. I don't think extension is something we need to use in this case.
>
> Rajitha R wrote:
> Will do.
I agree. Extending fact doesnt look right. We should add new entity - with definition containing parent fact, base cube, start and end times, weight, the filter and properties.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170019
-----------------------------------------------------------
On March 27, 2017, 9:55 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:55 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170019
-----------------------------------------------------------
Can you also add one example xml file for virtual fact in examples?
lens-api/src/main/resources/cube-0.1.xsd
Lines 172 (patched)
<https://reviews.apache.org/r/57908/#comment242750>
we need to add `filter` somewhere inside the fact definition.
lens-api/src/main/resources/cube-0.1.xsd
Lines 184 (patched)
<https://reviews.apache.org/r/57908/#comment242749>
By extending, we'll have to specify everything that we specify for fact table, which would mean columns would need to be provided. I don't think extension is something we need to use in this case.
- Rajat Khandelwal
On March 24, 2017, 5:45 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 24, 2017, 5:45 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
>
>
> Diff: https://reviews.apache.org/r/57908/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 27, 2017, 4:54 p.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/57908/diff/4/?file=1676661#file1676661line25>
> >
> > I think filter will only be where clauses. conditions on measures are part of having clauses. We can keep one more property for having clauses.
>
> Amareshwari Sriramadasu wrote:
> Filters should be mandatory as well, can add one more XProperties with mandatory filter properties.
>
> Puneet Gupta wrote:
> Any more thoughts on how virtual fact will evolve in future? We can consider those to have the xsd defined in a generic way (and may be not have filter as mandatory element/property). Rajitha has captured some like hiding some columns in virtual fact or dropping some storages.
>
> Rajitha R wrote:
> Won't making the filters mandatory restrict virtual fact to be used always with a filter? If there is a need to define a fact without a filter but say dropping a storage or anything similar, virtual facts can't be used. Should we have it defined this way?
Plus, it's possible to work around the mandatory-ness of filters. Putting `1=1` shouldn't be favorable over not putting anything at all.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
-----------------------------------------------------------
On March 27, 2017, 3:25 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 3:25 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Puneet Gupta <pu...@gmail.com>.
> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 22 (patched)
> > <https://reviews.apache.org/r/57908/diff/4/?file=1676661#file1676661line22>
> >
> > We need to make weight mandatory.
Shoudn't we keep this optional. It can be borrowed from parent in that case ?
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
-----------------------------------------------------------
On March 27, 2017, 9:55 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:55 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 22 (patched)
> > <https://reviews.apache.org/r/57908/diff/4/?file=1676661#file1676661line22>
> >
> > We need to make weight mandatory.
>
> Puneet Gupta wrote:
> Shoudn't we keep this optional. It can be borrowed from parent in that case ?
Yes. Agree with Puneet . @Rajat would you still want it mandatory..?
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
-----------------------------------------------------------
On March 28, 2017, 7:22 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 7:22 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/57908/diff/4/?file=1676661#file1676661line25>
> >
> > I think filter will only be where clauses. conditions on measures are part of having clauses. We can keep one more property for having clauses.
Filters should be mandatory as well, can add one more XProperties with mandatory filter properties.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
-----------------------------------------------------------
On March 27, 2017, 9:55 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:55 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Puneet Gupta <pu...@gmail.com>.
> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/57908/diff/4/?file=1676661#file1676661line25>
> >
> > I think filter will only be where clauses. conditions on measures are part of having clauses. We can keep one more property for having clauses.
>
> Amareshwari Sriramadasu wrote:
> Filters should be mandatory as well, can add one more XProperties with mandatory filter properties.
Any more thoughts on how virtual fact will evolve in future? We can consider those to have the xsd defined in a generic way (and may be not have filter as mandatory element/property). Rajitha has captured some like hiding some columns in virtual fact or dropping some storages.
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
-----------------------------------------------------------
On March 27, 2017, 9:55 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:55 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/57908/diff/4/?file=1676661#file1676661line25>
> >
> > I think filter will only be where clauses. conditions on measures are part of having clauses. We can keep one more property for having clauses.
>
> Amareshwari Sriramadasu wrote:
> Filters should be mandatory as well, can add one more XProperties with mandatory filter properties.
>
> Puneet Gupta wrote:
> Any more thoughts on how virtual fact will evolve in future? We can consider those to have the xsd defined in a generic way (and may be not have filter as mandatory element/property). Rajitha has captured some like hiding some columns in virtual fact or dropping some storages.
Won't making the filters mandatory restrict virtual fact to be used always with a filter? If there is a need to define a fact without a filter but say dropping a storage or anything similar, virtual facts can't be used. Should we have it defined this way?
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
-----------------------------------------------------------
On March 27, 2017, 9:55 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:55 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
-----------------------------------------------------------
lens-examples/src/main/resources/virtualfact1.xml
Lines 22 (patched)
<https://reviews.apache.org/r/57908/#comment242943>
We need to make weight mandatory.
lens-examples/src/main/resources/virtualfact1.xml
Lines 25 (patched)
<https://reviews.apache.org/r/57908/#comment242942>
I think filter will only be where clauses. conditions on measures are part of having clauses. We can keep one more property for having clauses.
- Rajat Khandelwal
On March 27, 2017, 3:25 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 3:25 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170712
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd
Lines 190 (patched)
<https://reviews.apache.org/r/57908/#comment243601>
Having filter on a virtual fact does not make sense to me. As having is usually associated with a query and it is over aggregates.
- Amareshwari Sriramadasu
On March 28, 2017, 7:22 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 7:22 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170283
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On March 28, 2017, 12:52 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 12:52 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review171429
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 31, 2017, 1:20 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 1:20 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 1d8a624
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170821
-----------------------------------------------------------
lens-examples/src/main/resources/virtualfact1.xml
Lines 22 (patched)
<https://reviews.apache.org/r/57908/#comment243695>
Yeah we can borrow from the source fact.
- Rajat Khandelwal
On March 31, 2017, 6:50 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 6:50 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 1d8a624
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/
-----------------------------------------------------------
(Updated March 31, 2017, 1:20 p.m.)
Review request for lens and Rajat Khandelwal.
Changes
-------
Changes for review comments
Repository: lens
Description
-------
Xsd for virtual fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 1d8a624
lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
Diff: https://reviews.apache.org/r/57908/diff/6/
Changes: https://reviews.apache.org/r/57908/diff/5-6/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
> On March 30, 2017, 5:26 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/cube-0.1.xsd
> > Lines 179-180 (patched)
> > <https://reviews.apache.org/r/57908/diff/5/?file=1677438#file1677438line179>
> >
> > Are we planning to add this functionality, right now? If not, can you please remove this documentation.
> >
> > If we are adding, can we build more clarity on the usecase?
removed them from documentation for now.
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170530
-----------------------------------------------------------
On March 31, 2017, 1:20 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 1:20 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 1d8a624
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Puneet Gupta <pu...@gmail.com>.
> On March 30, 2017, 5:26 a.m., Amareshwari Sriramadasu wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 25-26 (patched)
> > <https://reviews.apache.org/r/57908/diff/5/?file=1677439#file1677439line25>
> >
> > Should these be fields on cube or fields on fact? If fields from fact, then expresssions or join chains defined in cube, may not be getting used. I feel these should be from cube fields, to give users more control.
Will we validate this filter ? as in the fileds used in the filter are valid or not. If we are not validating the filter and just using it it the last phase (after candidate is picked and we are about to write the query for it) , user should be able to specify any fileds in the filter (cueb,fact,etc).
Also the filter has no time specific validity. Say filter1 for time range 1 and filter2 for time range 2.
We can think about this further.
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170530
-----------------------------------------------------------
On March 28, 2017, 7:22 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 7:22 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170530
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd
Lines 179-180 (patched)
<https://reviews.apache.org/r/57908/#comment243379>
Are we planning to add this functionality, right now? If not, can you please remove this documentation.
If we are adding, can we build more clarity on the usecase?
lens-examples/src/main/resources/virtualfact1.xml
Lines 25-26 (patched)
<https://reviews.apache.org/r/57908/#comment243380>
Should these be fields on cube or fields on fact? If fields from fact, then expresssions or join chains defined in cube, may not be getting used. I feel these should be from cube fields, to give users more control.
- Amareshwari Sriramadasu
On March 28, 2017, 7:22 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 7:22 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Xsd for virtual fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 060eb43
> lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57908/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/
-----------------------------------------------------------
(Updated March 28, 2017, 7:22 a.m.)
Review request for lens and Rajat Khandelwal.
Changes
-------
Changes post comments
Repository: lens
Description
-------
Xsd for virtual fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 060eb43
lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
Diff: https://reviews.apache.org/r/57908/diff/5/
Changes: https://reviews.apache.org/r/57908/diff/4-5/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/
-----------------------------------------------------------
(Updated March 27, 2017, 9:55 a.m.)
Review request for lens and Rajat Khandelwal.
Changes
-------
Adding sample virtual fact xml
Repository: lens
Description
-------
Xsd for virtual fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 060eb43
lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION
Diff: https://reviews.apache.org/r/57908/diff/4/
Changes: https://reviews.apache.org/r/57908/diff/3-4/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/
-----------------------------------------------------------
(Updated March 27, 2017, 9:51 a.m.)
Review request for lens and Rajat Khandelwal.
Repository: lens
Description
-------
Xsd for virtual fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 060eb43
Diff: https://reviews.apache.org/r/57908/diff/3/
Changes: https://reviews.apache.org/r/57908/diff/2-3/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 57908: Xsd for virtual fact
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/
-----------------------------------------------------------
(Updated March 24, 2017, 12:15 p.m.)
Review request for lens and Rajat Khandelwal.
Repository: lens
Description
-------
Xsd for virtual fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 060eb43
Diff: https://reviews.apache.org/r/57908/diff/2/
Changes: https://reviews.apache.org/r/57908/diff/1-2/
Testing
-------
Thanks,
Rajitha R