You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by am...@apache.org on 2007/07/12 11:38:51 UTC
svn commit: r555549 - in
/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src:
main/java/org/apache/cayenne/remote/
main/java/org/apache/cayenne/remote/service/
test/java/org/apache/cayenne/remote/
Author: amaniatis
Date: Thu Jul 12 02:38:50 2007
New Revision: 555549
URL: http://svn.apache.org/viewvc?view=rev&rev=555549
Log:
Add additional detail in the exception message for three tier, including the detail of the message type and the original cause of the exception. I know toString() isn't needed in the interface, but I included it to help document what it represents.
Modified:
cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/ClientMessage.java
cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/service/BaseRemoteService.java
cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/test/java/org/apache/cayenne/remote/MockMessage.java
Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/ClientMessage.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/ClientMessage.java?view=diff&rev=555549&r1=555548&r2=555549
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/ClientMessage.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/ClientMessage.java Thu Jul 12 02:38:50 2007
@@ -29,4 +29,9 @@
*/
public interface ClientMessage extends Serializable {
+ /**
+ * Returns a description of the type of message.
+ */
+ public String toString();
+
}
Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/service/BaseRemoteService.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/service/BaseRemoteService.java?view=diff&rev=555549&r1=555548&r2=555549
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/service/BaseRemoteService.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/remote/service/BaseRemoteService.java Thu Jul 12 02:38:50 2007
@@ -158,15 +158,16 @@
// recast the exception to a guaranteed serializable form
StringBuffer buffer = new StringBuffer();
- buffer.append("Exception processing message ").append(
- message.getClass().getName());
+ buffer.append("Exception processing message ")
+ .append(message.getClass().getName())
+ .append(" of type ").append(message.toString());
String exceptionText = th.getLocalizedMessage();
if (exceptionText != null) {
buffer.append(". Root cause: ").append(exceptionText);
}
- throw new CayenneRuntimeException(buffer.toString());
+ throw new CayenneRuntimeException(buffer.toString(), th);
}
}
Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/test/java/org/apache/cayenne/remote/MockMessage.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/test/java/org/apache/cayenne/remote/MockMessage.java?view=diff&rev=555549&r1=555548&r2=555549
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/test/java/org/apache/cayenne/remote/MockMessage.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/test/java/org/apache/cayenne/remote/MockMessage.java Thu Jul 12 02:38:50 2007
@@ -39,4 +39,8 @@
public DataChannel getLastChannel() {
return lastChannel;
}
+
+ public String toString() {
+ return "Mock message";
+ }
}