You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/29 22:25:58 UTC
[GitHub] [pulsar] nemecec opened a new pull request #10444: Improve Docker Compose README.md
nemecec opened a new pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444
### Motivation
Docker Compose `README.md` could be better.
### Modifications
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#issuecomment-903381527
@nemecec could you please re-run the tests? After they pass successfully, we can merge this PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nemecec commented on a change in pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
nemecec commented on a change in pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#discussion_r627781415
##########
File path: docker-compose/standalone-dashboard/README.MD
##########
@@ -20,26 +20,22 @@
-->
# Docker Compose
-In this folder path run the following command to start the cluster
+To start the cluster, run the following command in this folder:
Review comment:
Replaced "this" with "the current".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nemecec commented on a change in pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
nemecec commented on a change in pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#discussion_r627781651
##########
File path: docker-compose/standalone-dashboard/README.MD
##########
@@ -20,26 +20,22 @@
-->
# Docker Compose
-In this folder path run the following command to start the cluster
+To start the cluster, run the following command in this folder:
```
docker-compose up
```
-## Urls
+## Available endpoints
-Assuming localhost the the following endpoint will be available
+The following endpoints will be available (assuming Docker Compose exposes ports on `localhost`):
Review comment:
Applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#issuecomment-903702074
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nemecec commented on a change in pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
nemecec commented on a change in pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#discussion_r627781755
##########
File path: docker-compose/standalone-dashboard/README.MD
##########
@@ -20,26 +20,22 @@
-->
# Docker Compose
-In this folder path run the following command to start the cluster
+To start the cluster, run the following command in this folder:
```
docker-compose up
```
-## Urls
+## Available endpoints
-Assuming localhost the the following endpoint will be available
+The following endpoints will be available (assuming Docker Compose exposes ports on `localhost`):
+* [web-dashboard](http://localhost:80) - Pulsar dashboard, shows various metrics and metadata information about the cluster
+* `http://localhost:8080` - broker HTTP REST API URL, for both administrative tasks and for topic lookup by producers and consumers
+* `pulsar://locahost:6650` - broker binary protocol URL, for all data transfers by producers and consumers
Review comment:
Applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nemecec commented on pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
nemecec commented on pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#issuecomment-903550870
Even if the tests fail -- surely they are not failing because of this change as this is just a documentation change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#issuecomment-903527983
@nemecec I approved and the tests are running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#issuecomment-903381165
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nemecec commented on pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
nemecec commented on pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#issuecomment-903513672
> @nemecec could you please re-run the tests? After they pass successfully, we can merge this PR, thanks.
I do not have enough permissions to trigger a re-run. I pushed an empty commit to trigger it but now it is waiting for one of the maintainers to approve the re-run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10444: Improve Docker Compose README.md
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10444:
URL: https://github.com/apache/pulsar/pull/10444#discussion_r627028783
##########
File path: docker-compose/standalone-dashboard/README.MD
##########
@@ -20,26 +20,22 @@
-->
# Docker Compose
-In this folder path run the following command to start the cluster
+To start the cluster, run the following command in this folder:
```
docker-compose up
```
-## Urls
+## Available endpoints
-Assuming localhost the the following endpoint will be available
+The following endpoints will be available (assuming Docker Compose exposes ports on `localhost`):
Review comment:
```suggestion
The following endpoints are available (assuming Docker Compose exposes ports on `localhost`):
```
##########
File path: docker-compose/standalone-dashboard/README.MD
##########
@@ -20,26 +20,22 @@
-->
# Docker Compose
-In this folder path run the following command to start the cluster
+To start the cluster, run the following command in this folder:
Review comment:
in which folder?
##########
File path: docker-compose/standalone-dashboard/README.MD
##########
@@ -20,26 +20,22 @@
-->
# Docker Compose
-In this folder path run the following command to start the cluster
+To start the cluster, run the following command in this folder:
```
docker-compose up
```
-## Urls
+## Available endpoints
-Assuming localhost the the following endpoint will be available
+The following endpoints will be available (assuming Docker Compose exposes ports on `localhost`):
+* [web-dashboard](http://localhost:80) - Pulsar dashboard, shows various metrics and metadata information about the cluster
+* `http://localhost:8080` - broker HTTP REST API URL, for both administrative tasks and for topic lookup by producers and consumers
+* `pulsar://locahost:6650` - broker binary protocol URL, for all data transfers by producers and consumers
Review comment:
```suggestion
* `pulsar://locahost:6650` - broker binary protocol URL, for all data transferred by producers and consumers
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org